Page MenuHomePhabricator
Create Task
Maniphest T249207

Switch from @codingStandardsIgnore to phpcs tags
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The tags to exempt code from codesniffing such as @codingStandardsIgnoreLine excempt the code from all codesniffing.

Since we recently had an issue with this we're switching over to use the more modern phpcs tags which allows for a specific sniff to be exempted e.g. through phpcs:ignore Generic.Files.LineLength

More info on the new syntax is available here: https://www.axelerant.com/resources/team-blog/php_codesniffer-ignoring-standards

Details

SubjectRepoBranchLines +/-
Switch from @codingStandardsIgnore to phpcs tagsmediawiki/extensions/Wikispeechmaster+2 -4
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Apr 2 2020, 11:01 AM
Lokal_Profil set the point value for this task to 1.
Lokal_Profil moved this task from Unsorted to Code hygiene and deployment requirements [MW Extension] on the Wikispeech-Text-to-Speech board.

The only reason I'm licking this one now is so that we don't forget about this solution (since the @codingStandardsIgnoreLine disspaeared from the final version of the patch where this issue was raised)

Lokal_Profil renamed this task from Switch from @codingStandards to phpcs tags to Switch from @codingStandardsIgnore to phpcs tags.Apr 2 2020, 11:04 AM
gerritbot added a comment.Apr 2 2020, 11:09 AM

Change 585474 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[mediawiki/extensions/Wikispeech@master] Switch from @codingStandardsIgnore to phpcs tags

https://gerrit.wikimedia.org/r/585474

gerritbot added a project: Patch-For-Review.Apr 2 2020, 11:09 AM
Sebastian_Berlin-WMSE added a comment.Apr 3 2020, 1:22 PM

Where did you find what rules are available?

gerritbot added a comment.Apr 3 2020, 1:24 PM

Change 585474 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Switch from @codingStandardsIgnore to phpcs tags

https://gerrit.wikimedia.org/r/585474

Lokal_Profil mentioned this in rEWIS044eba0f5d54: Switch from @codingStandardsIgnore to phpcs tags.Apr 3 2020, 1:45 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2020, 2:23 PM
Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.Apr 6 2020, 6:48 AM
Sebastian_Berlin-WMSE moved this task from Backlog to Done on the Wikispeech-Jobrunner (Sprint) board.
Lokal_Profil added a comment.Apr 6 2020, 7:00 PM
In T249207#6026273, @Sebastian_Berlin-WMSE wrote:

Where did you find what rules are available?

IIRC I dug into vendor/mediawiki/mediawiki-codesniffer/MediaWiki/Sniffs/ and grepped around a bit

Lokal_Profil moved this task from 📥 Backlog to ☑️ Done on the User-LokalProfil board.Apr 6 2020, 8:00 PM
Stashbot mentioned this in T244344: Remove the HtmlGenerator class.Apr 7 2020, 8:34 AM
Stashbot mentioned this in T244345: Remove the Util class for PHP tests.
Stashbot mentioned this in T246085: Document re-architecturing decision (storage of utterances).

Mentioned in SAL (#wikimedia-cloud) [2020-04-07T08:34:28Z] <wm-bot> <sebastian-berlin-wmse> !log wikispeech Deploy latest from Git master: 85fa89a (T244344, T244345), f79fe03, 956e507, 66da277, 18c20c7 (T246085), 044eba0 (T249207), 2f98bef (T203161), 7aa7556 (T245823), 43e26a2

Stashbot mentioned this in T203161: Restrict access to Wikispeech functionality to certain users.Apr 7 2020, 8:34 AM
Stashbot mentioned this in T245823: Log error on invalid configuration values.
Sebastian_Berlin-WMSE closed this task as Resolved.Apr 16 2020, 9:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits