Page MenuHomePhabricator
Create Task
Maniphest T244345

Remove the Util class for PHP tests
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This is currently only used for one class that should itself be removed (T243384). Furthermore, the only method it has is for calling private methods, which probably indicates that something is wrong with the tests. If we really need it, there is a MediaWiki class for it.

Details

SubjectRepoBranchLines +/-
Wikispeech: Remove use of Utils.phpmediawiki/extensions/Wikispeechmaster+0 -34
Wikispeech: Remove HtmlGeneratormediawiki/extensions/Wikispeechmaster+0 -332
Wikispeech: Remove use of Utils.phpmediawiki/extensions/Wikispeechmaster+0 -6
Wikispeech: Remove use of Utils.phpmediawiki/extensions/Wikispeechmaster+0 -28
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedkalleT244345 Remove the Util class for PHP tests
 ResolvedkalleT243384 Remove `require` from PHP tests

Event Timeline

Sebastian_Berlin-WMSE created this task.Feb 5 2020, 11:16 AM
Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptFeb 5 2020, 11:16 AM
Sebastian_Berlin-WMSE added a subtask: T243384: Remove `require` from PHP tests.Feb 5 2020, 11:17 AM
Lokal_Profil moved this task from Incoming to Backlog on the Wikispeech-Jobrunner board.Feb 6 2020, 10:46 AM
Sebastian_Berlin-WMSE set the point value for this task to 2.Feb 19 2020, 11:39 AM
Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.

This is only used by HtmlGeneratorTest, so do this after that one is removed (T244344).

kalle claimed this task.Feb 20 2020, 8:31 AM
kalle moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.
gerritbot added a comment.Feb 20 2020, 10:43 AM

Change 573545 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove use of Utils.php

https://gerrit.wikimedia.org/r/573545

gerritbot added a project: Patch-For-Review.Feb 20 2020, 10:43 AM

Change 573546 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove use of Utils.php

https://gerrit.wikimedia.org/r/573546

gerritbot added a comment.Feb 20 2020, 12:39 PM

Change 573569 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove HtmlGenerator

https://gerrit.wikimedia.org/r/573569

gerritbot added a comment.Feb 20 2020, 12:44 PM

Change 573572 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove use of Utils.php

https://gerrit.wikimedia.org/r/573572

gerritbot added a comment.Feb 20 2020, 12:47 PM

Change 573546 abandoned by Karl Wettin (WMSE):
Wikispeech: Remove use of Utils.php

Reason:
I messed up the branching, starting over from scratch.

https://gerrit.wikimedia.org/r/573546

gerritbot added a comment.Feb 20 2020, 12:48 PM

Change 573545 abandoned by Karl Wettin (WMSE):
Wikispeech: Remove use of Utils.php

Reason:
I messed up the branching, starting over from scratch.

https://gerrit.wikimedia.org/r/573545

Lokal_Profil closed subtask T243384: Remove `require` from PHP tests as Resolved.Feb 21 2020, 10:54 AM
kalle added a project: User-kalle.Feb 25 2020, 10:37 AM
Lokal_Profil moved this task from 🥴 Backlog to 🤠 This week on the User-kalle board.Feb 25 2020, 10:44 AM
kalle moved this task from 🤠 This week to 🤔 Awaits action on the User-kalle board.Feb 25 2020, 10:47 AM
gerritbot added a comment.Feb 26 2020, 9:20 AM

Change 573569 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove HtmlGenerator

https://gerrit.wikimedia.org/r/573569

kalle mentioned this in rEWIS8a3cc99dc002: Wikispeech: Remove HtmlGenerator.Feb 26 2020, 9:20 AM
Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Feb 26 2020, 11:21 AM
Stashbot mentioned this in T206485: Set root: true in eslintrc.json.Feb 26 2020, 2:26 PM
Stashbot mentioned this in T179229: Decide whether we want the package-lock.json to commit or ignore.
Stashbot mentioned this in T234597: Phase out PHPUnit expected exception annotations from tests.
Stashbot mentioned this in T243384: Remove `require` from PHP tests.

Mentioned in SAL (#wikimedia-cloud) [2020-02-26T14:26:33Z] <kalle_> Deploy latest from Git master: 20d9123, d8447da (T206485), f1f1143, 07e603c, cbfb487 (T179229), 0a7a488, bcd8507, 3225fe2, ebbad49 (T234597), b831a16, 879bc31, 52931bc, 24aa5aa, 93c9f0b, 90df124 (T243384), 1dbe811, 8a3cc99 (T244345), 624274d (T167300, T243376)

Stashbot mentioned this in T167300: Sensible default values in extension.json (WikispeechServerUrl).Feb 26 2020, 2:26 PM
Stashbot mentioned this in T243376: Determine if an upgrade to manifest version 2 in extension.json is useful.
gerritbot added a comment.Feb 27 2020, 8:31 AM

Change 573572 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove use of Utils.php

https://gerrit.wikimedia.org/r/573572

gerritbot added a comment.Feb 28 2020, 1:14 PM

Change 573572 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove use of Utils.php

https://gerrit.wikimedia.org/r/573572

Sebastian_Berlin-WMSE mentioned this in rEWIS85fa89a53645: Wikispeech: Remove use of Utils.php.Feb 28 2020, 1:18 PM
Sebastian_Berlin-WMSE removed a project: Patch-For-Review.Mar 9 2020, 1:09 PM
Sebastian_Berlin-WMSE closed this task as Resolved.Mar 9 2020, 1:15 PM
Stashbot mentioned this in T244344: Remove the HtmlGenerator class.Apr 7 2020, 8:34 AM

Mentioned in SAL (#wikimedia-cloud) [2020-04-07T08:34:28Z] <wm-bot> <sebastian-berlin-wmse> !log wikispeech Deploy latest from Git master: 85fa89a (T244344, T244345), f79fe03, 956e507, 66da277, 18c20c7 (T246085), 044eba0 (T249207), 2f98bef (T203161), 7aa7556 (T245823), 43e26a2

Stashbot mentioned this in T246085: Document re-architecturing decision (storage of utterances).Apr 7 2020, 8:34 AM
Stashbot mentioned this in T249207: Switch from @codingStandardsIgnore to phpcs tags.
Stashbot mentioned this in T203161: Restrict access to Wikispeech functionality to certain users.
Stashbot mentioned this in T245823: Log error on invalid configuration values.
Jopparn moved this task from 🤔 Awaits action to 🤯 Done on the User-kalle board.Aug 11 2020, 11:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL