Page MenuHomePhabricator
Create Task
Maniphest T243376

Determine if an upgrade to manifest version 2 in extension.json is useful
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

See mw:Manual:Extension.json/Schema for info about the difference between the versions. If the extension already requires 1.29+ we can just change and everything should be fine. If not, we should not change as per the recommendations on the page above.

Details

SubjectRepoBranchLines +/-
Bump manifest version up from 1 to 2mediawiki/extensions/Wikispeechmaster+95 -51
Bump manifest version up from 1 to 2mediawiki/extensions/Wikispeechmaster+4 -1
Customize query in gerrit

Related Objects

Mentioned In
T244345: Remove the Util class for PHP tests
T243384: Remove `require` from PHP tests
T234597: Phase out PHPUnit expected exception annotations from tests
T179229: Decide whether we want the package-lock.json to commit or ignore
T206485: Set root: true in eslintrc.json
rEWIS624274d63b11: Bump manifest version up from 1 to 2
T167300: Sensible default values in extension.json (WikispeechServerUrl)
Mentioned Here
T167300: Sensible default values in extension.json (WikispeechServerUrl)
T179229: Decide whether we want the package-lock.json to commit or ignore
T206485: Set root: true in eslintrc.json
T234597: Phase out PHPUnit expected exception annotations from tests
T243384: Remove `require` from PHP tests
T244345: Remove the Util class for PHP tests
rEWIS20d9123e26f5: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
rEWISd8447da7a283: build: Set "root": true, in .eslintrc.json
rEWISf1f11438ad13: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
rEWIS07e603c36161: Variation improvements to the Wikispeech includes/ dir
rEWIScbfb48785055: build: Updating npm dependencies for security issues
rEWISbcd8507dc041: build: Updating dependencies
rEWIS3225fe24c38b: build: Updating js-yaml to 3.13.1
rEWISebbad49ed2d4: build: Bump mediawiki-codesniffer to 28.0.0 and make a pass
rEWISb831a16f07d0: build: Updating grunt-banana-checker to 0.8.1
rEWIS879bc3102ead: build: Updating mediawiki/minus-x to 0.3.2
rEWIS52931bc131f4: build: Updating npm dependencies
rEWIS24aa5aabd1db: build: Updating dependencies
rEWIS93c9f0b19af4: build: Updating composer dependencies
rEWIS90df124ace42: Remove "require once"-statements in test cases
rEWIS1dbe811f59f7: build: Updating npm dependencies
rEWIS624274d63b11: Bump manifest version up from 1 to 2
rEWIS8a3cc99dc002: Wikispeech: Remove HtmlGenerator

Event Timeline

Sebastian_Berlin-WMSE created this task.Jan 22 2020, 9:37 AM
Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptJan 22 2020, 9:37 AM
Addshore subscribed.Jan 22 2020, 10:09 AM
Lokal_Profil updated the task description. (Show Details)Jan 24 2020, 8:35 AM
Lokal_Profil updated the task description. (Show Details)
Lokal_Profil moved this task from Player to Code hygiene and deployment requirements [MW Extension] on the Wikispeech-Text-to-Speech board.Jan 30 2020, 11:03 AM
Sebastian_Berlin-WMSE updated the task description. (Show Details)Jan 30 2020, 11:51 AM
Sebastian_Berlin-WMSE moved this task from Incoming to Proposed for next sprint on the Wikispeech-Jobrunner board.
Lokal_Profil moved this task from Proposed for next sprint to Sprint on the Wikispeech-Jobrunner board.Feb 6 2020, 10:43 AM
Lokal_Profil edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.
Lokal_Profil renamed this task from Upgrade to manifest version 2 in extension.json to Determine if an upgrade to manifest version 2 in extension.json is useful.Feb 6 2020, 11:07 AM
Lokal_Profil added a project: User-kalle.
Lokal_Profil set the point value for this task to 4.
Lokal_Profil added subscribers: kalle, Lokal_Profil.

We'll use this for @kalle to familiarise himself with the extension part of the codebase

Lokal_Profil moved this task from 🥴 Backlog to 🤠 This week on the User-kalle board.Feb 11 2020, 9:25 AM
Lokal_Profil added a comment.Feb 18 2020, 2:11 PM

While you are figuring out which verison we require you can add this to mw:Extension:Wikispeech using the mediawiki parameter and extension.json using "requires": {"MediaWiki": ">= 1.xx.x"}

gerritbot added a comment.Feb 18 2020, 2:57 PM

Change 572896 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Bump manifest version up from 1 to 2

https://gerrit.wikimedia.org/r/572896

gerritbot added a project: Patch-For-Review.Feb 18 2020, 2:58 PM
kalle added a comment.Feb 18 2020, 3:20 PM

Oups. My bad. Note to self, run tests before committing for review. I'm at it.

Sebastian_Berlin-WMSE moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.Feb 19 2020, 11:18 AM
Lokal_Profil assigned this task to kalle.Feb 19 2020, 11:23 AM
gerritbot added a comment.Feb 19 2020, 3:06 PM

Change 573304 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Merge remote-tracking branch 'origin/master' into T243376

https://gerrit.wikimedia.org/r/573304

kalle mentioned this in T167300: Sensible default values in extension.json (WikispeechServerUrl).Feb 20 2020, 7:55 AM
gerritbot added a comment.Feb 20 2020, 12:31 PM

Change 573566 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Bump manifest version up from 1 to 2

https://gerrit.wikimedia.org/r/573566

gerritbot added a comment.Feb 20 2020, 12:48 PM

Change 573304 abandoned by Karl Wettin (WMSE):
Merge remote-tracking branch 'origin/master' into T243376

Reason:
I messed up the branching, starting over from scratch.

https://gerrit.wikimedia.org/r/573304

gerritbot added a comment.Feb 20 2020, 12:48 PM

Change 572896 abandoned by Karl Wettin (WMSE):
Bump manifest version up from 1 to 2

Reason:
I messed up the branching, starting over from scratch.

https://gerrit.wikimedia.org/r/572896

kalle moved this task from 🤠 This week to 🤔 Awaits action on the User-kalle board.Feb 25 2020, 10:47 AM
gerritbot added a comment.Feb 25 2020, 3:27 PM

Change 573566 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Bump manifest version up from 1 to 2

https://gerrit.wikimedia.org/r/573566

kalle mentioned this in rEWIS624274d63b11: Bump manifest version up from 1 to 2.Feb 25 2020, 3:53 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2020, 4:10 PM
Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Feb 26 2020, 9:16 AM
Stashbot mentioned this in T206485: Set root: true in eslintrc.json.Feb 26 2020, 2:26 PM
Stashbot mentioned this in T179229: Decide whether we want the package-lock.json to commit or ignore.
Stashbot mentioned this in T234597: Phase out PHPUnit expected exception annotations from tests.
Stashbot mentioned this in T243384: Remove `require` from PHP tests.
Stashbot mentioned this in T244345: Remove the Util class for PHP tests.

Mentioned in SAL (#wikimedia-cloud) [2020-02-26T14:26:33Z] <kalle_> Deploy latest from Git master: 20d9123, d8447da (T206485), f1f1143, 07e603c, cbfb487 (T179229), 0a7a488, bcd8507, 3225fe2, ebbad49 (T234597), b831a16, 879bc31, 52931bc, 24aa5aa, 93c9f0b, 90df124 (T243384), 1dbe811, 8a3cc99 (T244345), 624274d (T167300, T243376)

kalle moved this task from 🤔 Awaits action to 🤯 Done on the User-kalle board.Feb 27 2020, 2:46 PM
Sebastian_Berlin-WMSE closed this task as Resolved.Mar 9 2020, 1:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL