Page MenuHomePhabricator
Create Task
Maniphest T179229

Decide whether we want the package-lock.json to commit or ignore
Closed, ResolvedPublic
Actions

Description

npm version 5 adds a package-lock.json [1] to each repository. Do we want to have this committed or ignored?

I would suggest not to commit the file, because composer.lock is also not committed. This file has the same effect and should handled the same.

There are two extensions at the moment having this file committed:

AdvancedSearch - I0f591d75d0a7b8755b446398e753507b36db15b1
WikibaseLexeme - Icc91a224e264c9b33df70254958b0af95a463d03

A decision before many developer using npm5 and committing this would be nice to have a specification how to handle this.
In case of ignore, mediawiki core, all extensions and all skins with node_module in .gitignore should get a line added to its .gitignore. Committed files should be removed.

[1] https://docs.npmjs.com/files/package-lock.json

Details

SubjectRepoBranchLines +/-
Add package-lock.jsonmediawiki/extensions/Wikibasemaster+5 K -0
Merging from 8e360ba4f276823b5327927ee7b5b737b0e1cf84:wikidata/query/gui-deployproduction+1 -1
Commit package-lock.jsonwikidata/query/guimaster+7 K -12
build: add package-lock filemediawiki/extensions/RevisionSlidermaster+5 K -0
Build: add package-lock filemediawiki/extensions/TextExtractsmaster+1 K -0
Build: add package-lock filemediawiki/extensions/MobileFrontendmaster+12 K -0
Build: add package-lock filemediawiki/extensions/Popupsmaster+12 K -0
Build: add package-lock filemediawiki/skins/MinervaNeuemaster+6 K -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Repository Identity mentioned this in rEPCE66f6cf53fe0d: build: Updating grunt to 1.3.0.Jan 2 2021, 6:01 PM
Restricted Repository Identity mentioned this in rEPGT60ddf9675e9d: build: Updating grunt to 1.3.0.Jan 2 2021, 6:06 PM
Restricted Repository Identity mentioned this in rEPROcb5c1d4997ad: build: Updating grunt to 1.3.0.Jan 2 2021, 6:12 PM
Restricted Repository Identity mentioned this in rEPTQ0c8f254ab38f: build: Updating grunt to 1.3.0.Jan 2 2021, 6:28 PM
Restricted Repository Identity mentioned this in rEQSL06fcc2ae5b97: build: Updating grunt to 1.3.0.Jan 2 2021, 6:32 PM
Restricted Repository Identity mentioned this in rERGU58af5f743d41: build: Updating grunt to 1.3.0.Jan 2 2021, 6:37 PM
Restricted Repository Identity mentioned this in rERACa4fafe82aa5e: build: Updating grunt to 1.3.0.Jan 2 2021, 6:49 PM
Restricted Repository Identity mentioned this in rERQT23b72176cecf: build: Updating grunt to 1.3.0.Jan 2 2021, 6:58 PM
Restricted Repository Identity mentioned this in rEPCT8e230ab2f4c6: build: Updating grunt to 1.3.0.Jan 2 2021, 7:11 PM
Restricted Repository Identity mentioned this in rEPRZc7dcbe5e4870: build: Updating grunt to 1.3.0.Jan 2 2021, 7:17 PM
Restricted Repository Identity mentioned this in rERXB377911e6cba4: build: Updating grunt to 1.3.0.Jan 2 2021, 7:44 PM
Restricted Repository Identity mentioned this in rERIC68f83a6135c2: build: Updating grunt to 1.3.0.Jan 2 2021, 7:50 PM
Umherirrender mentioned this in rERPGe1912c80eaf9: build: Updating grunt to 1.3.0.Jan 2 2021, 7:52 PM
Restricted Repository Identity mentioned this in rEQCSee7fa659d79d: build: Updating grunt to 1.3.0.Jan 2 2021, 7:57 PM
Restricted Repository Identity mentioned this in rEQGV4b234643e878: build: Updating grunt to 1.3.0.Jan 2 2021, 8:00 PM
Restricted Repository Identity mentioned this in rEQRS1d36654286ae: build: Updating grunt to 1.3.0.Jan 2 2021, 8:09 PM
Restricted Repository Identity mentioned this in rERSE6a09852e613a: build: Updating grunt to 1.3.0.Jan 2 2021, 9:09 PM
Restricted Repository Identity mentioned this in rESECd04036a3c367: build: Updating dependencies.Jan 2 2021, 10:59 PM
Restricted Repository Identity mentioned this in rESNG464d54058c7c: build: Updating dependencies.Jan 2 2021, 11:50 PM
Restricted Repository Identity mentioned this in rESHM2d694778afc8: build: Updating dependencies.Jan 3 2021, 12:15 AM
Restricted Repository Identity mentioned this in rESMX0367c7dd4745: build: Updating dependencies.Jan 3 2021, 1:28 AM
Restricted Repository Identity mentioned this in rESHH63c6ba90571c: build: Updating grunt to 1.3.0.Jan 3 2021, 1:53 AM
Restricted Repository Identity mentioned this in rESRDd96d0e5e123d: build: Updating dependencies.Jan 3 2021, 2:10 AM
Legoktm mentioned this in rERLSc7575eebb78e: build: Updating dependencies.Jan 3 2021, 2:48 AM
Restricted Repository Identity mentioned this in rESSO2d6daeee527d: build: Updating grunt to 1.3.0.Jan 3 2021, 3:06 AM
Restricted Repository Identity mentioned this in rESTLH4f69e026e219: build: Updating grunt to 1.3.0.Jan 3 2021, 4:19 AM
Restricted Repository Identity mentioned this in rESHG55ed820d896a: build: Updating npm dependencies.Jan 3 2021, 4:50 AM
Restricted Repository Identity mentioned this in rETSA95987979ea99: build: Updating dependencies.Jan 3 2021, 5:15 AM
Restricted Repository Identity mentioned this in rETSTa73729e0a5e1: build: Updating dependencies.Jan 3 2021, 6:26 AM
Restricted Repository Identity mentioned this in rESCC5a1e73ee1813: build: Updating dependencies.Jan 3 2021, 8:09 AM
Restricted Repository Identity mentioned this in rEURD11d6a482f142: build: Updating dependencies.Jan 3 2021, 8:48 AM
Restricted Repository Identity mentioned this in rEULK783a7b302093: build: Updating dependencies.Jan 3 2021, 9:35 AM
Restricted Repository Identity mentioned this in rEUCA8fc221714e3b: build: Updating dependencies.Jan 3 2021, 10:27 AM
Restricted Repository Identity mentioned this in rEVRC48078e9f2dec: build: Updating dependencies.Jan 3 2021, 10:48 AM
Restricted Repository Identity mentioned this in rEUPE84e4f174b8cd: build: Updating grunt to 1.3.0.
Restricted Repository Identity mentioned this in rEULLa7e778bd4822: build: Updating grunt to 1.3.0.Jan 3 2021, 11:11 AM
Restricted Repository Identity mentioned this in rEHIE8c72ceaa8341: build: Updating dependencies.Jan 3 2021, 5:29 PM
Restricted Repository Identity mentioned this in rEXFA09df9fbb9479: build: Updating dependencies.Jan 3 2021, 5:38 PM
Restricted Repository Identity mentioned this in rSEXA0b73b5ac6d24: build: Updating grunt to 1.3.0.Jan 3 2021, 5:43 PM
Restricted Repository Identity mentioned this in rSEXAMPLE0b73b5ac6d24: build: Updating grunt to 1.3.0.Jan 3 2021, 5:51 PM
Restricted Repository Identity mentioned this in rMSBC165a28015943: build: Updating grunt to 1.3.0.Jan 3 2021, 6:14 PM
Restricted Repository Identity mentioned this in rSHASe6d6bba2cba0: build: Updating grunt to 1.3.0.Jan 3 2021, 7:01 PM
Restricted Repository Identity mentioned this in rMSMA9d1943c4657d: build: Updating npm dependencies.Jan 3 2021, 7:41 PM
Legoktm mentioned this in rEWIS789566c612a5: build: Updating dependencies.Jan 3 2021, 7:45 PM
Restricted Repository Identity mentioned this in rMSPObc3419f1a880: build: Updating grunt to 1.3.0.Jan 3 2021, 7:48 PM
Legoktm mentioned this in R1893:28e33ae5f794: build: Updating grunt to 1.3.0.Jan 3 2021, 8:34 PM
Restricted Repository Identity mentioned this in rMSCP1c0d6ae8c89d: build: Updating eslint-config-wikimedia to 0.17.0.Jan 3 2021, 11:30 PM
Restricted Repository Identity mentioned this in rECOG6601d5dc8aea: build: Updating dependencies.Jan 4 2021, 2:17 AM
Restricted Repository Identity mentioned this in rELNSf16353c5cf86: build: Updating grunt to 1.3.0.Jan 4 2021, 6:42 AM
Restricted Repository Identity mentioned this in rELIS5de0ec20dc2f: build: Updating grunt to 1.3.0.Jan 4 2021, 8:24 AM
zeljkofilipin unsubscribed.Jan 4 2021, 3:01 PM
Umherirrender mentioned this in rELDBaa2b9dce6a2c: build: Updating dependencies.Jan 7 2021, 10:50 AM
Restricted Repository Identity mentioned this in rESPRbd2ca1090ab1: build: Updating grunt to 1.3.0.Jan 13 2021, 1:33 AM
LibUp-bot mentioned this in rEBUA73b6086a4d96: build: Updating grunt to 1.3.0.Jan 15 2021, 2:03 PM
LibUp-bot mentioned this in rEBSESedf0a573b154: build: Updating grunt to 1.3.0.Jan 15 2021, 2:30 PM
LibUp-bot mentioned this in rEBTCd57170863356: build: Updating grunt to 1.3.0.Jan 15 2021, 2:40 PM
LibUp-bot mentioned this in rEBSJf304241eb13f: build: Updating grunt to 1.3.0.Jan 15 2021, 3:11 PM
LibUp-bot mentioned this in rEWPLa728fd9c2e1e: build: Updating grunt to 1.3.0.Jan 23 2021, 11:31 AM
Umherirrender mentioned this in rEMAS75ca48873750: build: Updating dependencies.Jan 23 2021, 12:02 PM
LibUp-bot mentioned this in rEPFU9a799199b556: build: Updating grunt to 1.3.0.Jan 23 2021, 12:25 PM
Umherirrender mentioned this in rEPI6c6ae04a5255: build: Updating dependencies.Jan 23 2021, 12:33 PM
LibUp-bot mentioned this in rEPS29aaeb70896c: build: Updating dependencies.Jan 23 2021, 12:50 PM
LibUp-bot mentioned this in rEMPDadb1979dea15: build: Updating grunt to 1.3.0.Jan 23 2021, 1:55 PM
LibUp-bot mentioned this in rEBKJbfdf31412de9: build: Updating grunt to 1.3.0.Apr 6 2021, 6:56 PM
LibUp-bot mentioned this in rEBKJfc2146d60293: build: Updating dependencies.Apr 6 2021, 8:26 PM
LibUp-bot mentioned this in rEATH2bc8b237c94d: build: Updating grunt to 1.3.0.Apr 8 2021, 11:37 AM
LibUp-bot mentioned this in rEPGE84dbcec65ef8: build: Updating grunt to 1.4.0.May 12 2021, 10:57 AM
LibUp-bot mentioned this in rECPDeebbfa0139ab: build: Updating grunt to 1.4.0.May 14 2021, 7:04 PM
LibUp-bot mentioned this in rECPD36be8bc072a5: build: Updating grunt to 1.4.0.May 14 2021, 10:42 PM
LibUp-bot mentioned this in rWLWIa61779a3661e: build: Updating composer dependencies.May 15 2021, 3:34 PM
Jdforrester-WMF mentioned this in rMLDOad88ec5b5ee0: build: Updating composer dependencies.May 15 2021, 8:11 PM
LibUp-bot mentioned this in rEEDAacd60e6a7c21: build: Updating grunt to 1.4.0.May 30 2021, 11:03 AM
LibUp-bot mentioned this in rEEDA6a52f8a623bd: build: Updating grunt to 1.4.0.Jul 22 2021, 5:38 PM
hashar mentioned this in T291196: Add yarn to docker-registry.wikimedia.org/releng/node* images.Oct 23 2021, 8:45 AM
LibUp-bot mentioned this in rECDC3204b37cfa71: build: Updating npm dependencies.Feb 6 2022, 12:31 PM
LibUp-bot mentioned this in rECPDff0bd32de356: build: Updating dependencies.Apr 14 2022, 11:43 PM
LibUp-bot mentioned this in rERETb41289e329a8: build: Updating eslint-config-wikimedia to 0.22.1.Apr 18 2022, 11:45 AM
LibUp-bot mentioned this in rECPD928dfc0de548: build: Updating npm dependencies.May 22 2022, 1:01 PM
LibUp-bot mentioned this in rERET44f09469f18a: build: Updating grunt to 1.5.3.Jun 19 2022, 7:18 PM
LibUp-bot mentioned this in rETHBfba8dd64c61b: build: Updating grunt-banana-checker to 0.10.0.Oct 7 2022, 9:51 AM
Umherirrender mentioned this in rEPHS1bae94f66690: build: Updating dependencies.Nov 25 2022, 12:54 PM
LibUp-bot mentioned this in rEPPMc762320876af: build: Updating dependencies.Dec 2 2022, 9:02 PM
LibUp-bot mentioned this in rEARF3417af1da6f6: build: Updating composer dependencies.Feb 6 2023, 8:38 PM
Umherirrender mentioned this in rEOSA6947f8e77bee: build: Updating npm dependencies.Apr 29 2023, 7:01 PM
LibUp-bot mentioned this in rEBWA7cdf7286fecb: build: Updating npm dependencies.May 2 2023, 7:07 AM
LibUp-bot mentioned this in rEEUS5d7bef19fad2: build: Updating npm dependencies for security issues.May 25 2023, 5:57 PM
LibUp-bot mentioned this in rEOAL1757215530e5: build: Updating npm dependencies for security issues.May 25 2023, 6:04 PM
Umherirrender mentioned this in rELDRddbe9d89e8e5: build: Updating npm dependencies for security issues.May 25 2023, 6:35 PM
LibUp-bot mentioned this in rEPRZa186bd7ec244: build: Updating npm dependencies for security issues.May 25 2023, 6:53 PM
LibUp-bot mentioned this in rENBV01251cfc21e9: build: Updating npm dependencies for security issues.
LibUp-bot mentioned this in rENBUefb024be39bf: build: Updating npm dependencies for security issues.
LibUp-bot mentioned this in rEMMH31e136df035f: build: Updating npm dependencies for security issues.May 25 2023, 6:55 PM
LibUp-bot mentioned this in rELNTab111a4035a5: build: Updating npm dependencies for security issues.
LibUp-bot mentioned this in rEMNLd2bca21ba294: build: Updating npm dependencies for security issues.
LibUp-bot mentioned this in rEMMEf133884507fd: build: Updating npm dependencies for security issues.May 25 2023, 6:58 PM
LibUp-bot mentioned this in rSHAS8b7fc2547e6c: build: Updating npm dependencies for security issues.May 25 2023, 7:00 PM
LibUp-bot mentioned this in rELTGec2d7ee4c445: build: Updating npm dependencies for security issues.May 25 2023, 7:05 PM
LibUp-bot mentioned this in rEQSL1faef283bf03: build: Updating npm dependencies for security issues.May 25 2023, 7:11 PM
LibUp-bot mentioned this in rEPEMf5d0e9d256e5: build: Updating dependencies.Feb 8 2024, 2:34 AM
LibUp-bot mentioned this in rEWNRc6189b61dcc2: build: Updating composer dependencies.Sun, Apr 21, 5:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL