Page MenuHomePhabricator

Set root: true in eslintrc.json
Closed, ResolvedPublic

Description

"npm test" should be fully independent of whatever directory hierarchy the extension is checked out to. Per @Krinkle, this hasn't been an issue since most eslint config entries don't inherit, except "globals", which we've started recently using. So we should explicitly set "root": true, as was done in MobileFrontend to keep extensions and skins fully independent of MediaWiki core.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ExternalGuidancemaster+1 -0
mediawiki/extensions/SecurePollmaster+1 -0
mediawiki/extensions/WikibaseQualityExternalValidationmaster+2 -2
mediawiki/extensions/WikibaseQualitymaster+1 -0
mediawiki/extensions/ArticleFeedbackv5master+1 -0
mediawiki/extensions/Collectionmaster+1 -0
mediawiki/extensions/ElectronPdfServicemaster+1 -0
mediawiki/extensions/UploadWizardmaster+1 -0
mediawiki/extensions/TwoColConflictmaster+1 -0
mediawiki/extensions/AdvancedSearchmaster+10 -4
mediawiki/extensions/RevisionSlidermaster+1 -0
mediawiki/extensions/TemplateWizardmaster+1 -0
mediawiki/extensions/Graphmaster+2 -1
mediawiki/extensions/Mathmaster+1 -0
mediawiki/extensions/WikibaseLexememaster+18 -7
mediawiki/extensions/Citemaster+18 -7
mediawiki/extensions/Wikibasemaster+28 -11
mediawiki/extensions/Wikidata.orgmaster+1 -0
mediawiki/extensions/Flowmaster+1 -0
mediawiki/extensions/VisualEditormaster+1 -0
mediawiki/extensions/TimedMediaHandlermaster+1 -0
mediawiki/extensions/CentralNoticemaster+7 -1
mediawiki/extensions/MultimediaViewermaster+1 -0
mediawiki/extensions/Citoidmaster+1 -0
mediawiki/extensions/ShowMemaster+1 -0
mediawiki/extensions/AJAXPollmaster+1 -0
mediawiki/extensions/DeletePagesForGoodmaster+1 -0
mediawiki/extensions/UniversalLanguageSelectormaster+1 -0
mediawiki/extensions/ContentTranslationmaster+1 -0
mediawiki/extensions/Translatemaster+1 -0
mediawiki/extensions/MassMessagemaster+1 -0
mediawiki/extensions/ExtensionDistributormaster+1 -0
mediawiki/extensions/GrowthExperimentsmaster+1 -0
mediawiki/extensions/Gadgetsmaster+1 -0
mediawiki/extensions/Lintermaster+1 -0
mediawiki/extensions/CentralAuthmaster+1 -0
mediawiki/extensions/ConfirmEditmaster+1 -0
mediawiki/extensions/BetaFeaturesmaster+1 -0
mediawiki/extensions/ArticleCreationWorkflowmaster+1 -0
mediawiki/extensions/PageImagesmaster+1 -0
mediawiki/extensions/CodeMirrormaster+1 -0
mediawiki/extensions/GettingStartedmaster+1 -0
mediawiki/extensions/FileAnnotationsmaster+1 -0
mediawiki/extensions/CheckUsermaster+1 -0
mediawiki/extensions/Kartographermaster+1 -0
mediawiki/extensions/CookieWarningmaster+1 -0
mediawiki/extensions/InputBoxmaster+1 -0
mediawiki/extensions/CategoryTreemaster+1 -0
mediawiki/extensions/CharInsertmaster+1 -0
mediawiki/extensions/AbuseFiltermaster+1 -0
mediawiki/extensions/PageViewInfomaster+1 -1
mediawiki/extensions/BoilerPlatemaster+1 -0
mediawiki/extensions/Newslettermaster+9 -8
mediawiki/extensions/ReadingListsmaster+1 -0
mediawiki/extensions/ArticlePlaceholdermaster+1 -0
mediawiki/extensions/Wikispeechmaster+1 -0
mediawiki/extensions/AddHTMLMetaAndTitlemaster+1 -0
mediawiki/extensions/3Dmaster+1 -0
mediawiki/extensions/ForcePreviewmaster+2 -1
mediawiki/extensions/FlaggedRevsmaster+1 -0
mediawiki/extensions/Commentsmaster+8 -1
mediawiki/extensions/ApiFeatureUsagemaster+2 -2
mediawiki/extensions/PageAssessmentsmaster+1 -0
mediawiki/extensions/LiquidThreadsmaster+1 -0
mediawiki/extensions/CodeEditormaster+1 -0
mediawiki/skins/apexmaster+1 -0
mediawiki/extensions/PropertySuggestermaster+2 -1
mediawiki/extensions/SecureAuthmaster+1 -0
mediawiki/extensions/TemplateDatamaster+1 -0
mediawiki/extensions/TitleBlacklistmaster+2 -1
mediawiki/extensions/Scribuntomaster+1 -0
mediawiki/extensions/GuidedTourmaster+1 -0
mediawiki/extensions/SendGridmaster+1 -0
mediawiki/extensions/QuickSurveysmaster+2 -2
mediawiki/extensions/PageTriagemaster+1 -0
mediawiki/extensions/Sentrymaster+1 -0
mediawiki/skins/Materialmaster+1 -0
mediawiki/extensions/PronunciationRecordingmaster+1 -0
mediawiki/extensions/MobileAppmaster+1 -0
mediawiki/extensions/Quizmaster+1 -0
mediawiki/extensions/ProofreadPagemaster+1 -0
mediawiki/extensions/ReplaceTextmaster+1 -0
mediawiki/extensions/UserAgreementmaster+16 -15
mediawiki/extensions/TranslationNotificationsmaster+1 -0
mediawiki/extensions/TemplateSandboxmaster+1 -0
mediawiki/skins/Metrolookmaster+1 -0
mediawiki/extensions/WikimediaBadgesmaster+1 -0
mediawiki/extensions/WikibaseQualityConstraintsmaster+4 -1
mediawiki/extensions/Echomaster+1 -0
mediawiki/extensions/Scoremaster+1 -0
mediawiki/extensions/WikidataPageBannermaster+2 -2
mediawiki/extensions/SyntaxHighlight_GeSHimaster+1 -0
mediawiki/extensions/WikiEditormaster+1 -0
mediawiki/extensions/cldrmaster+1 -0
mediawiki/extensions/TocTreemaster+1 -0
mediawiki/extensions/WikiLovemaster+1 -0
mediawiki/skins/Timelessmaster+1 -0
mediawiki/extensions/Wikisourcemaster+7 -1
mediawiki/extensions/WikimediaMessagesmaster+1 -0
mediawiki/extensions/GeoDatamaster+1 -0
mediawiki/extensions/TextExtractsmaster+1 -0
mediawiki/extensions/UrlShortenermaster+2 -1
mediawiki/extensions/GlobalPreferencesmaster+1 -0
mediawiki/extensions/examplesmaster+1 -0
mediawiki/extensions/Thanksmaster+1 -0
mediawiki/skins/Vectormaster+1 -0
mediawiki/extensions/wikihieromaster+1 -0
mediawiki/extensions/WikimediaEventsmaster+1 -0
mediawiki/extensions/PerformanceInspectormaster+1 -0
Show related patches Customize query in gerrit

Related Objects

Mentioned In
rEDSC29f3a8d4bd03: build: Updating dependencies
rMSRAbc6393a31c08: build: Updating npm dependencies
rEAKLf314891cb722: build: Updating eslint-config-wikimedia to 0.18.2
rEPS29aaeb70896c: build: Updating dependencies
rEPI6c6ae04a5255: build: Updating dependencies
rWSWFcc6fc04cbef3: build: Updating eslint-config-wikimedia to 0.17.0
rMSCP1c0d6ae8c89d: build: Updating eslint-config-wikimedia to 0.17.0
rEWIS789566c612a5: build: Updating dependencies
rMSMA9d1943c4657d: build: Updating npm dependencies
rEHIE8c72ceaa8341: build: Updating dependencies
rESCC5a1e73ee1813: build: Updating dependencies
rETSTa73729e0a5e1: build: Updating dependencies
rETSA95987979ea99: build: Updating dependencies
rESHG55ed820d896a: build: Updating npm dependencies
rERLSc7575eebb78e: build: Updating dependencies
rESHM2d694778afc8: build: Updating dependencies
rESECd04036a3c367: build: Updating dependencies
rEPRRcbc86bcaab20: build: Updating dependencies
rELINT0e7795052deb: build: Updating dependencies
rEEPS100dfaaaafef: build: Updating dependencies
rEDPGf6cd99c32e4a: build: Updating dependencies
rEBOPa795bd8e95bd: build: Updating dependencies
rEAFU4c036462ceec: build: Updating dependencies
rSMNBc3f80c402b2a: build: Updating grunt to 1.3.0
rEPUA4dcb66661653: build: Updating npm dependencies
T243376: Determine if an upgrade to manifest version 2 in extension.json is useful
T167300: Sensible default values in extension.json (WikispeechServerUrl)
T244345: Remove the Util class for PHP tests
T243384: Remove `require` from PHP tests
T234597: Phase out PHPUnit expected exception annotations from tests
T179229: Decide whether we want the package-lock.json to commit or ignore
rECIRc76439a934af: build: Updating dependencies
rETST260446e122a6: Use json extension for .eslintrc
T225325: LibraryUpgrader CI normalisation tasks, June/July 2019
rESCC088cfa7ebb5b: build: Set "root": true, in .eslintrc.json
rESEC47ec6bf014d0: build: Set "root": true, in .eslintrc.json
rMSMA27b5e6dc05f7: build: Set "root": true, in .eslintrc.json
rESHM1822aa41db41: build: Set "root": true, in .eslintrc.json
rEWISd8447da7a283: build: Set "root": true, in .eslintrc.json
rEWSO5232c3d6fc17: build: Set "root": true, in .eslintrc.json
rEPS3999f7decbfc: build: Set "root": true, in .eslintrc.json
rESCC0cc297810282: build: Set "root": true, in .eslintrc.json
rEQS63fac5f3b201: build: Set "root": true, in .eslintrc.json
rESNG301e26b29cc4: build: Set "root": true, in .eslintrc.json
rETHRa837beb7efc8: build: Set "root": true, in .eslintrc.json
rEWLE4f5c0481dd12: build: Set "root": true, in .eslintrc.json
rEASR60bdb345a7dd: build: Set "root": true, in .eslintrc.json
rEPI81c71edc4502: build: Set "root": true, in .eslintrc.json
rEUAG7b81af717e99: build: Set "root": true, in .eslintrc.json
rERLS8192f7c41a77: build: Set "root": true, in .eslintrc.json
rEBOP396d2716ca58: build: Set "root": true, in .eslintrc.json
rERSL46f3ca653c77: build: Set "root": true, in .eslintrc.json
rEGREc441ac798910: build: Set "root": true, in .eslintrc.json
rELINT1cd89bbd5025: build: Set "root": true, in .eslintrc.json
rECW4c52bdcfdf04: build: Set "root": true, in .eslintrc.json
rEEPSc28ef388cb81: build: Set "root": true, in .eslintrc.json
Mentioned Here
T167300: Sensible default values in extension.json (WikispeechServerUrl)
T179229: Decide whether we want the package-lock.json to commit or ignore
T234597: Phase out PHPUnit expected exception annotations from tests
T243376: Determine if an upgrade to manifest version 2 in extension.json is useful
T243384: Remove `require` from PHP tests
T244345: Remove the Util class for PHP tests
rEWIS20d9123e26f5: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
rEWISd8447da7a283: build: Set "root": true, in .eslintrc.json
rEWISf1f11438ad13: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
rEWIS07e603c36161: Variation improvements to the Wikispeech includes/ dir
rEWIScbfb48785055: build: Updating npm dependencies for security issues
rEWISbcd8507dc041: build: Updating dependencies
rEWIS3225fe24c38b: build: Updating js-yaml to 3.13.1
rEWISebbad49ed2d4: build: Bump mediawiki-codesniffer to 28.0.0 and make a pass
rEWISb831a16f07d0: build: Updating grunt-banana-checker to 0.8.1
rEWIS879bc3102ead: build: Updating mediawiki/minus-x to 0.3.2
rEWIS52931bc131f4: build: Updating npm dependencies
rEWIS24aa5aabd1db: build: Updating dependencies
rEWIS93c9f0b19af4: build: Updating composer dependencies
rEWIS90df124ace42: Remove "require once"-statements in test cases
rEWIS1dbe811f59f7: build: Updating npm dependencies
rEWIS624274d63b11: Bump manifest version up from 1 to 2
rEWIS8a3cc99dc002: Wikispeech: Remove HtmlGenerator

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 480299 merged by jenkins-bot:
[mediawiki/extensions/ApiFeatureUsage@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480299

Change 480303 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480303

Change 480300 merged by jenkins-bot:
[mediawiki/extensions/ArticleCreationWorkflow@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480300

Change 480318 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480318

Change 480327 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480327

Change 480329 merged by jenkins-bot:
[mediawiki/extensions/ForcePreview@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480329

Change 480294 merged by jenkins-bot:
[mediawiki/extensions/3D@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480294

Change 480297 merged by jenkins-bot:
[mediawiki/extensions/AddHTMLMetaAndTitle@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480297

Change 480307 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480307

Change 480345 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480345

Change 480304 merged by jenkins-bot:
[mediawiki/extensions/BoilerPlate@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480304

Change 480319 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480319

Change 480330 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480330

Change 480309 merged by jenkins-bot:
[mediawiki/extensions/CharInsert@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480309

Change 480339 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480339

Change 480305 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480305

Change 480337 merged by jenkins-bot:
[mediawiki/extensions/InputBox@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480337

Change 480326 merged by jenkins-bot:
[mediawiki/extensions/FileAnnotations@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480326

Change 480325 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480325

Change 480332 merged by jenkins-bot:
[mediawiki/extensions/GettingStarted@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480332

Change 480335 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480335

Change 480341 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480341

Change 480320 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480320

Change 480374 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480374

Change 480377 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480377

Change 480322 merged by jenkins-bot:
[mediawiki/extensions/DeletePagesForGood@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480322

Change 480295 merged by jenkins-bot:
[mediawiki/extensions/AJAXPoll@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480295

Change 480364 merged by jenkins-bot:
[mediawiki/extensions/ShowMe@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480364

Change 480308 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480308

Change 480344 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480344

Change 480314 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480314

Change 480371 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480371

Change 480381 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480381

Change 480328 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480328

Change 480384 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480384

Change 480385 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480385

Change 480389 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480389

Change 480334 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480334

Change 480342 merged by jenkins-bot:
[mediawiki/extensions/Math@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480342

Change 480313 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480313

Change 480368 merged by MaxSem:
[mediawiki/extensions/TemplateWizard@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480368

Change 480358 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480358

Change 480298 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480298

Change 480376 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480376

Change 480378 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480378

Change 480324 merged by Umherirrender:
[mediawiki/extensions/ElectronPdfService@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480324

Change 480317 merged by Umherirrender:
[mediawiki/extensions/Collection@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480317

Change 480301 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480301

Change 480386 abandoned by Krinkle:
build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480386

Change 480388 abandoned by Krinkle:
build: Set "root": true, in .eslintrc.json

https://gerrit.wikimedia.org/r/480388

Change 515146 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SecurePoll@master] Set root: true in .eslintrc.json

https://gerrit.wikimedia.org/r/515146

Change 515147 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ExternalGuidance@master] Set root: true in .eslintrc.json

https://gerrit.wikimedia.org/r/515147

Change 515147 merged by jenkins-bot:
[mediawiki/extensions/ExternalGuidance@master] Set root: true in .eslintrc.json

https://gerrit.wikimedia.org/r/515147

Change 515146 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Set root: true in .eslintrc.json

https://gerrit.wikimedia.org/r/515146

Umherirrender triaged this task as Lowest priority.

Done for all extensions and skins on gerrit.wikimedia.org