Remove `require` from PHP tests
Closed, ResolvedPublic12 Estimated Story Points
Actions

Assigned To

Authored By

	Sebastian_Berlin-WMSE
	Jan 22 2020, 11:23 AM

Description

require should not be needed in the unittests. It may be as easy to just remove those lines and check that it still works.

Details

	Subject	Repo	Branch	Lines +/-
	Remove "require once"-statements in test cases	mediawiki/extensions/Wikispeech	master	+2 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kalle	T244345 Remove the Util class for PHP tests
		Resolved		kalle	T243384 Remove `require` from PHP tests

Event Timeline

Sebastian_Berlin-WMSE created this task.Jan 22 2020, 11:23 AM

Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptJan 22 2020, 11:23 AM

Addshore subscribed.Jan 22 2020, 11:42 AM

I want to work on this issue

Lokal_Profil moved this task from Unsorted to Player on the Wikispeech-Text-to-Speech board.Jan 24 2020, 8:54 AM

Lokal_Profil moved this task from Player to Code hygiene and deployment requirements [MW Extension] on the Wikispeech-Text-to-Speech board.Jan 30 2020, 11:03 AM

Sebastian_Berlin-WMSE updated the task description. (Show Details)Jan 30 2020, 11:45 AM

Sebastian_Berlin-WMSE moved this task from Incoming to Proposed for next sprint on the Wikispeech-Jobrunner board.

Sebastian_Berlin-WMSE mentioned this in T244345: Remove the Util class for PHP tests.Feb 5 2020, 11:16 AM

Sebastian_Berlin-WMSE added a parent task: T244345: Remove the Util class for PHP tests.

Lokal_Profil moved this task from Proposed for next sprint to Sprint on the Wikispeech-Jobrunner board.Feb 6 2020, 10:43 AM

Lokal_Profil edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.

We'll use this as a first task for @kalle to get the whole Vagrant/gerrit/code review etc. setup going. As such the times estimate is fairly unrelated to the actual coding needed.

Lokal_Profil moved this task from 🥴 Backlog to 🤠 This week on the User-kalle board.Feb 11 2020, 9:25 AM

Change 572838 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Removed "require once"-statements in test cases

https://gerrit.wikimedia.org/r/572838

gerritbot added a project: Patch-For-Review.Feb 18 2020, 11:06 AM

Change 572838 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Remove "require once"-statements in test cases

https://gerrit.wikimedia.org/r/572838

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 9:10 AM

kalle mentioned this in rEWIS90df124ace42: Remove "require once"-statements in test cases.Feb 19 2020, 9:14 AM

Sebastian_Berlin-WMSE moved this task from Backlog to Done on the Wikispeech-Jobrunner (Sprint) board.Feb 19 2020, 11:18 AM

Lokal_Profil assigned this task to kalle.Feb 19 2020, 11:22 AM

kalle moved this task from 🤠 This week to 🤯 Done on the User-kalle board.Feb 20 2020, 7:53 AM

Lokal_Profil closed this task as Resolved.Feb 21 2020, 10:54 AM

Lokal_Profil awarded a token.