This class was created before Javascript was used to request utterances. It may become relevant again if and when we want to implement support for non-Javascript usage. For now though, we should remove since it's just dead code.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Wikispeech: Remove HtmlGenerator | mediawiki/extensions/Wikispeech | master | +0 -331 |
Related Objects
- Mentioned In
- T245823: Log error on invalid configuration values
T203161: Restrict access to Wikispeech functionality to certain users
T249207: Switch from @codingStandardsIgnore to phpcs tags
T246085: Document re-architecturing decision (storage of utterances)
rEWIS85fa89a53645: Wikispeech: Remove use of Utils.php
T244345: Remove the Util class for PHP tests - Mentioned Here
- T203161: Restrict access to Wikispeech functionality to certain users
T244345: Remove the Util class for PHP tests
T245823: Log error on invalid configuration values
T246085: Document re-architecturing decision (storage of utterances)
T249207: Switch from @codingStandardsIgnore to phpcs tags
rEWIS85fa89a53645: Wikispeech: Remove use of Utils.php
rEWISf79fe03b52eb: build: Updating acorn to 7.1.1
rEWIS956e50726f11: build: Updating minimist to 1.2.5
rEWIS66da277b9ca8: build: Updating mkdirp to 0.5.3
rEWIS18c20c760728: Add ADR "Store synthesized audio in MediaWiki extension"
rEWIS044eba0f5d54: Switch from @codingStandardsIgnore to phpcs tags
rEWIS2f98befc212a: Add API action for requesting speech synthesis
rEWIS43e26a230428: build: Updating postcss-sass to 0.4.4
rEWIS7aa7556c5eb2: Log warning on invalid manifest configuration values
Event Timeline
Is the following a correct interpretation?
WikispeechHook#onParserAfterTidy is the only thing referencing HTMLGenerator, but since there is no ParserAfterTidy registered in our manifest we can simply delete HTMLGenerator and remove WikispeechHook#onParserAfterTidy without further delay.
Or am I missing something defined in JS, or perhaps something we extend from the extension library which execute the hook?
That is correct.
The first implementation stored utterances as HTML elements when rendering the page. This is now handled with Ajax in the Javascript modules (specifically Storage).
Change 573523 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove HtmlGenerator
The last two days I've been getting a lot of
kalle@musa:~/projekt/wikimedia/Wikispeech$ git review -R You are about to submit multiple commits. This is expected if you are submitting a commit that is dependent on one or more in-review commits, or if you are submitting multiple self-contained but dependent changes. Otherwise you should consider squashing your changes into one commit before submitting (for indivisible changes) or submitting from separate branches (for independent changes). The outstanding commits are: 5e0cd09 (HEAD -> T244344) Wikispeech: Remove HtmlGenerator e3a81dd (T243376) Merge remote-tracking branch 'origin/master' into T243376 a55bb35 Bump manifest version up from 1 to 2 Do you really want to submit the above commits? Type 'yes' to confirm, other to cancel: yes
This is all good, right? This is due to the other tickets sent to review that has not yet been +2:ed? Or do I have a messed up local repo?
Change 573569 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove HtmlGenerator
Change 573523 abandoned by Karl Wettin (WMSE):
Wikispeech: Remove HtmlGenerator
Reason:
I messed up the branching, starting over from scratch.
Change 573572 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Remove use of Utils.php
The change above is not related to this task. It should be https://gerrit.wikimedia.org/r/573569.