Page MenuHomePhabricator
Create Task
Maniphest T246085

Document re-architecturing decision (storage of utterances)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Document (in an ADR) the re-architecturing motivation, decision and consequences.

Add the decision and related diagrams to the project log

Publish the the final version of the ADR in the repo (under /docs/adr/).

Details

SubjectRepoBranchLines +/-
Add ADR "Store synthesized audio in MediaWiki extension"mediawiki/extensions/Wikispeechmaster+138 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lokal_Profil created this task.Feb 25 2020, 10:18 AM
Lokal_Profil added subscribers: • kalle, Sebastian_Berlin-WMSE.Feb 25 2020, 10:23 AM

For project log see T246086

@Sebastian_Berlin-WMSE @kalle Can you have a read through of the ADR draft and see if we captured everything from our discussion and the comments in the site visit notes.

Also identify diagrams/tables etc. that should be added to the entry in the Project log.

Lokal_Profil moved this task from Unsorted to Documentation on the Wikispeech-Text-to-Speech board.Feb 25 2020, 10:23 AM
Lokal_Profil updated the task description. (Show Details)Feb 25 2020, 11:22 AM
Lokal_Profil updated the task description. (Show Details)
Lokal_Profil added projects: User-LokalProfil, User-Sebastian_Berlin-WMSE, User-kalle.Feb 25 2020, 1:54 PM

Adding to all of our boards for drafting and proofreading

Lokal_Profil moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.Feb 25 2020, 1:55 PM
Lokal_Profil renamed this task from Document re-architecturing decision to Document re-architecturing decision (storage of utterances).Mar 9 2020, 1:40 PM
Lokal_Profil edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.

ADR text has been created

Lokal_Profil set the point value for this task to 2.Mar 11 2020, 1:43 PM
Sebastian_Berlin-WMSE moved this task from This Week to Waitin' on the User-Sebastian_Berlin-WMSE board.Mar 11 2020, 4:04 PM
Sebastian_Berlin-WMSE moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.
gerritbot added a comment.Mar 12 2020, 7:07 AM

Change 578981 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Add ADR "Store synthesized audio in MediaWiki extension"

https://gerrit.wikimedia.org/r/578981

gerritbot added a project: Patch-For-Review.Mar 12 2020, 7:07 AM
Lokal_Profil moved this task from 📥 Backlog to 🔬 to Review on the User-LokalProfil board.Mar 18 2020, 3:59 PM
Sebastian_Berlin-WMSE moved this task from Waitin' to This Week on the User-Sebastian_Berlin-WMSE board.Mar 19 2020, 9:25 AM
Sebastian_Berlin-WMSE changed the point value for this task from 2 to 1.
gerritbot added a comment.Mar 24 2020, 9:30 AM

Change 578981 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Add ADR "Store synthesized audio in MediaWiki extension"

https://gerrit.wikimedia.org/r/578981

gerritbot added a comment.Mar 25 2020, 12:06 PM

Change 578981 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Add ADR "Store synthesized audio in MediaWiki extension"

https://gerrit.wikimedia.org/r/578981

Sebastian_Berlin-WMSE mentioned this in rEWIS18c20c760728: Add ADR "Store synthesized audio in MediaWiki extension".Mar 25 2020, 12:11 PM
Sebastian_Berlin-WMSE moved this task from This Week to Done on the User-Sebastian_Berlin-WMSE board.Mar 31 2020, 7:43 AM
Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.
Lokal_Profil closed this task as Resolved.Mar 31 2020, 8:24 AM
Lokal_Profil assigned this task to Sebastian_Berlin-WMSE.
Lokal_Profil removed a project: Patch-For-Review.
Stashbot mentioned this in T244344: Remove the HtmlGenerator class.Apr 7 2020, 8:34 AM
Stashbot mentioned this in T244345: Remove the Util class for PHP tests.

Mentioned in SAL (#wikimedia-cloud) [2020-04-07T08:34:28Z] <wm-bot> <sebastian-berlin-wmse> !log wikispeech Deploy latest from Git master: 85fa89a (T244344, T244345), f79fe03, 956e507, 66da277, 18c20c7 (T246085), 044eba0 (T249207), 2f98bef (T203161), 7aa7556 (T245823), 43e26a2

Stashbot mentioned this in T249207: Switch from @codingStandardsIgnore to phpcs tags.Apr 7 2020, 8:34 AM
Stashbot mentioned this in T203161: Restrict access to Wikispeech functionality to certain users.
Stashbot mentioned this in T245823: Log error on invalid configuration values.
Lokal_Profil added a comment.May 26 2020, 7:23 AM

Added to project log

Jopparn moved this task from 🔬 to Review to ☑️ Done on the User-LokalProfil board.Jun 3 2020, 6:06 PM
Jopparn moved this task from 🥴 Backlog to 🤯 Done on the User-kalle board.Aug 11 2020, 11:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits