.thebox {
  background: #fef6e7;
  border: 1px solid #ac6600;
  border-radius: 2px;
  padding: 16px;
}

@Prtksxna This is almost the specification for a MessageWidget with type 'warning': https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#MessageWidget-type-warning Shall we just use that instead?

Change 586327 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Improve "no results" message in Compare tab

https://gerrit.wikimedia.org/r/586327

In T249254#6031465, @Tchanders wrote:

@Prtksxna This is almost the specification for a MessageWidget with type 'warning': https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#MessageWidget-type-warning Shall we just use that instead?

Yes! I forgot this existed. Thanks for pointing it out @Tchanders

• Don't show the Filters box

@dmaza asks a question about this on the patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/586327/1/src/SpecialInvestigate.php@240

Essentially: if there are no results because of a filter that was just added, it would probably make sense for the user to be able to remove that filter again.

In T249254#6033305, @Tchanders wrote:

• Don't show the Filters box

@dmaza asks a question about this on the patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/586327/1/src/SpecialInvestigate.php@240

Essentially: if there are no results because of a filter that was just added, it would probably make sense for the user to be able to remove that filter again.

Related to this, should the message include something about checking your filters if you have no results?

In T249254#6033305, @Tchanders wrote:

@dmaza asks a question about this on the patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/586327/1/src/SpecialInvestigate.php@240
Essentially: if there are no results because of a filter that was just added, it would probably make sense for the user to be able to remove that filter again.

Yeah, that makes sense. So we now have two cases when the Compare tab could be empty:

1. We don't have any data in the last 90 days on the users / IPs
2. The user has added too many filters

In T249254#6033312, @Tchanders wrote:

Related to this, should the message include something about checking your filters if you have no results?

Yeah that would make sense. Suggesting that the user try removing some filters to get results: There were no results matching this filtering criteria. Try removing some filters to broaden the search.

Thanks @Prtksxna.

So we now have two cases when the Compare tab could be empty:

1. We don't have any data in the last 90 days on the users / IPs
2. The user has added too many filters

Distinguishing between these two situations is not trivial - e.g. checking if the lack of results is due to filters or to lack of activity would involve doing another query without the filters.

We could do this:

• If no filters - hide the filters input and show: There are no results: there have been no edits from these users or IPs in the last 90 days.
• If there are filters - keep the filters input and show: There are no results matching these filtering criteria. Try removing some filters to broaden the search. (It might be the case that even without the filters there will be no results, but the user will see the correct message once they remove all the filters.)

Sounds good to me, @Tchanders.

Change 586327 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Improve "no results" message in Compare tab

https://gerrit.wikimedia.org/r/586327

No results when filtering: