[Bug] mobile-html edit history is undefined
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• bearND
	Apr 6 2020, 7:05 PM

Description

Impact: The view edits history subtitle shows undefined for any page updated 2 or more days ago.

Steps to Reproduce:

Open any English mobile-html page in dev environment, e.g. http://localhost:8888/en.wikipedia.org/v1/page/mobile-html/Cat
In the browser DevTools JavaScript console add a Footer with editedDaysAgo specified

pcs.c1.Footer.add({
  title: 'Cat',
  menu: {
    items: [pcs.c1.Footer.MenuItemType.lastEdited],
    fragment: "pcs-menu",
    editedDaysAgo: 3
  },
  readMore: {}
})

Observe the string in the subtitle under "View edit history"

Actual Results:
"undefined"

Expected Results:
"Updated 3 days ago"

Details

	Subject	Repo	Branch	Lines +/-
	Fix "updated x days ago" message	mediawiki/services/mobileapps	master	+79 -4

Customize query in gerrit

Related Objects

Mentioned In: T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki

Event Timeline

• bearND created this task.Apr 6 2020, 7:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2020, 7:05 PM

• bearND claimed this task.Apr 6 2020, 7:05 PM

• bearND moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.

• bearND edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

• bearND moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

LGoto triaged this task as High priority.Apr 7 2020, 3:36 PM

• bearND updated the task description. (Show Details)Apr 7 2020, 3:38 PM

Change 587344 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Fix "updated x days ago" message

https://gerrit.wikimedia.org/r/587344

gerritbot added a project: Patch-For-Review.Apr 7 2020, 9:27 PM

• bearND moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 7 2020, 9:37 PM

Change 587344 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Fix "updated x days ago" message

https://gerrit.wikimedia.org/r/587344

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 1:10 PM

• bearND moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 8 2020, 3:51 PM

Deployed earlier today.

This will make all translations where singular (or the "first") form does not equal 1 wrong unless they manually add =1, which causes the same issue as English currently?

Alternative solutions would be to make separate messages for "Today" and "Yesterday" and "$1 days ago".

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).Apr 20 2021, 11:14 AM

MSantos moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.

Aklapper removed • bearND as the assignee of this task.Apr 26 2021, 3:46 PM

@Nikerabbit I've just checked editedDaysAgo parameter with values 1 for 'Yesterday' and 0 for 'Today'. It seems it works as expected.

cc: @MSantos

Thanks, @vadim-kovalenko.

Seems to be resolved. I'll be bold and resolve the task but please @Nikerabbit let us know if we are missing anything else.

I suggest to test:

Chinese (zh-Hant or zh-Hans) which does not have separate plural form, so by my reading the middle value in {{PLURAL:$1|更新于昨天|更新于$1天前|0=更新于今天}} is not reachable.
Macedonian (mk) with values like 1, 21, 31, 41, 51, 61 which may all show "yesterday" of {{PLURAL:$1|Подновено вчера|Подновено пред $1 дена|0=Подновено денес}}

There are also other languages but they have not yet updated their translations.

vadim-kovalenko mentioned this in T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.May 30 2022, 2:09 PM

	F34853720: last edit.png
	Dec 7 2021, 10:06 AM

[Bug] mobile-html edit history is undefinedClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

[Bug] mobile-html edit history is undefined
Closed, ResolvedPublicBUG REPORT
Actions