Page MenuHomePhabricator
Create Task
Maniphest T249839

Fix Flow InvalidDataException in CI builds
Open, MediumPublic
Actions

Description

The wmf-quibble-vendor-mysql-php72-docker job currently produces some MediaWiki errors when run for Wikibase:

2020-04-09 15:46:20 3635404b8896 wikidb-unittest_: [9b01f02504b973423eaf9dfb] [no req] Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vk6sex9zmk7f9zay
2020-04-09 15:46:20 3635404b8896 wikidb-unittest_: [9b01f02504b973423eaf9dfb] [no req] Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vk6sex9zmm6ge1a2
2020-04-09 15:46:21 3635404b8896 wikidb-unittest_: [9b01f02504b973423eaf9dfb] [no req] Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vk6seyhalf1j47i2
2020-04-09 15:46:21 3635404b8896 wikidb-unittest_: [9b01f02504b973423eaf9dfb] [no req] Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vk6seyhalh0k89h6

(I don’t know if that also happens for Flow builds, I haven’t tried it out yet.)

Details can be found in the full mw-error.log. That file is supposed to be empty, and the build is supposed to fail if it isn’t (T246358) – but before that can happen, we need to ensure we don’t produce MediaWiki server errors.

  • Flow NotifiedUsersTest::testWatchingTopic (2 exceptions)
  • Flow NotifiedUsersTest::testWatchingBoard (2 exceptions)
4 exceptions
2020-06-15 18:37:12 05a48c428a20 wikidb-unittest_: [f5cbf9bb57a368368af80ba6] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vocay5tmqsilfnu9
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f9cb54bd793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(173): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(48): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingTopic()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(75): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(134): require(string)
#27 {main}



2020-06-15 18:37:12 05a48c428a20 wikidb-unittest_: [f5cbf9bb57a368368af80ba6] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vocay5tmquhmjptd
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f9cb54bd793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(187): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(48): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingTopic()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(75): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(134): require(string)
#27 {main}



2020-06-15 18:37:12 05a48c428a20 wikidb-unittest_: [f5cbf9bb57a368368af80ba6] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vocay5tmr2dqzxpt
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f9cb54bd793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(173): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(80): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingBoard()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(75): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(134): require(string)
#27 {main}



2020-06-15 18:37:12 05a48c428a20 wikidb-unittest_: [f5cbf9bb57a368368af80ba6] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vocay5tmr4cs3zox
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f9cb54bd793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(187): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(80): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingBoard()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(75): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(134): require(string)
#27 {main}

Details

SubjectRepoBranchLines +/-
tests: Disable NotifiedUsersTest::testWatchingTopic and ::testWatchingBoardmediawiki/extensions/Flowmaster+24 -0
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 9 2020, 4:13 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 9 2020, 4:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lucas_Werkmeister_WMDE mentioned this in T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty.Apr 9 2020, 4:14 PM
hashar updated the task description. (Show Details)Apr 10 2020, 1:08 PM
hashar triaged this task as Medium priority.Apr 10 2020, 1:12 PM
• Pablo-WMDE subscribed.Apr 14 2020, 11:06 AM
Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.May 18 2020, 9:36 PM
kostajh subscribed.May 28 2020, 5:40 PM

(I don’t know if that also happens for Flow builds, I haven’t tried it out yet.)

It does happen for regular Flow builds, e.g. this one.

2020-05-28 17:03:41 3f224b0eb726 wikidb-unittest_: [493a2d9e1b09d2fd0dd7191e] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vn828rf67dec5m24
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f7ba041a793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(173): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(48): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingTopic()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#27 {main}
2020-05-28 17:03:41 3f224b0eb726 wikidb-unittest_: [493a2d9e1b09d2fd0dd7191e] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vn828rf67fdd9o18
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f7ba041a793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(187): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(48): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingTopic()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#27 {main}
2020-05-28 17:03:41 3f224b0eb726 wikidb-unittest_: [493a2d9e1b09d2fd0dd7191e] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vn828rf67n9hpvxo
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f7ba041a793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(173): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(80): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingBoard()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#27 {main}
2020-05-28 17:03:41 3f224b0eb726 wikidb-unittest_: [493a2d9e1b09d2fd0dd7191e] [no req]   Flow\Exception\InvalidDataException from line 120 of /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php: Invalid metadata for topic|post revision vn828rf67p8itxws
#0 /workspace/src/extensions/Flow/includes/Data/Listener/NotificationListener.php(59): Flow\Data\Listener\NotificationListener->notifyPostChange(string, Flow\Model\PostRevision, array)
#1 /workspace/src/extensions/Flow/includes/Data/Listener/DeferredInsertLifecycleHandler.php(36): Flow\Data\Listener\NotificationListener->onAfterInsert(Flow\Model\PostRevision, array, array)
#2 /workspace/src/includes/deferred/MWCallableUpdate.php(38): Flow\Data\Listener\DeferredInsertLifecycleHandler->Flow\Data\Listener\{closure}()
#3 /workspace/src/includes/deferred/DeferredUpdates.php(466): MWCallableUpdate->doUpdate()
#4 /workspace/src/includes/deferred/DeferredUpdates.php(343): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple)
#5 /workspace/src/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, class@anonymous�/workspace/src/includes/debug/logger/LogCapturingSpi.php0x7f7ba041a793, BufferingStatsdDataFactory, string)
#6 /workspace/src/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#7 /workspace/src/includes/deferred/DeferredUpdates.php(490): DeferredUpdates::doUpdates(string)
#8 /workspace/src/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::tryOpportunisticExecute(string)
#9 /workspace/src/includes/deferred/DeferredUpdates.php(148): DeferredUpdates::addUpdate(MWCallableUpdate, integer)
#10 /workspace/src/extensions/Flow/tests/phpunit/PostRevisionTestCase.php(260): DeferredUpdates::addCallableUpdate(Closure)
#11 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(187): Flow\Tests\PostRevisionTestCase->store(Flow\Model\PostRevision)
#12 /workspace/src/extensions/Flow/tests/phpunit/Notifications/NotifiedUsersTest.php(80): Flow\Tests\NotifiedUsersTest->getTestData()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): Flow\Tests\NotifiedUsersTest->testWatchingBoard()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(Flow\Tests\NotifiedUsersTest)
#17 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(437): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#24 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#25 /workspace/src/maintenance/doMaintenance.php(105): PHPUnitMaintClass->execute()
#26 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#27 {main}
Krinkle subscribed.Jun 11 2020, 4:42 PM

@kostajh Some questions/ideas to get on the way:

  • Is this Flow unit test behaving in as expected? E.g. it's asserting something good, but has an async failure that you expect, but aren't yet catching/asserting.
  • Or is it asserting something good, but has an unexpected and real async failure? (either due to bad call in test code, or bug in prod code).
  • Or perhaps the async update is expected to fail / out of scope of the test, and we can flushed/cleared it without letting it run and/or make the prod code not queue the update in this scenario.
Krinkle renamed this task from Fix Flow InvalidDataException in Wikibase CI builds to Fix Flow InvalidDataException in CI builds.Jun 11 2020, 4:47 PM
Krinkle updated the task description. (Show Details)Jun 17 2020, 2:59 PM
gerritbot added a comment.Jun 17 2020, 3:05 PM

Change 606205 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Flow@master] tests: Disable NotifiedUsersTest::testWatchingTopic and ::testWatchingBoard

https://gerrit.wikimedia.org/r/606205

gerritbot added a project: Patch-For-Review.Jun 17 2020, 3:05 PM
Krinkle added a comment.Jun 17 2020, 3:06 PM

I'll give this a few more days, but otherwise I suggest we disable for now so that other teams can move forward.

gerritbot added a comment.Jun 17 2020, 9:34 PM

Change 606205 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] tests: Disable NotifiedUsersTest::testWatchingTopic and ::testWatchingBoard

https://gerrit.wikimedia.org/r/606205

Krinkle removed a parent task: T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty.Jun 17 2020, 9:39 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 17 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 10:10 PM
Addshore added a project: [DEPRECATED] wdwb-tech.Apr 14 2021, 9:38 AM
Addshore moved this task from Inbox to External Realm on the [DEPRECATED] wdwb-tech board.Apr 14 2021, 3:35 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
Krinkle unsubscribed.Apr 15 2021, 9:03 PM
Addshore removed a project: Wikidata-Campsite.Apr 22 2021, 3:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL