Page MenuHomePhabricator

Cindy-the-browser-test-bot should use verified, not code review
Closed, ResolvedPublic

Description

Cindy-the-browser-test-bot should give V+1 instead of CR+1, since it is a bot running tests, not a human reviewing code

The bot can be added to https://gerrit.wikimedia.org/r/#/admin/groups/1729,info (LabelBots) to be able to give V+1, similar to SonarQube Bot (c.f. T240854)

Not sure who is operating the bot, couldn't find a tag for it

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I found https://www.mediawiki.org/wiki/Wikimedia_Discovery/BrowserBot and https://wikitech.wikimedia.org/wiki/Cindy_The_Browser_Test_Bot but am still clueless where to find its public code source.

In general, +1 on this request. See https://www.mediawiki.org/wiki/Topic:Vd6dlh046jfuyhns for a similar discussion about SonarQube bot.

I've asked cloud-services-team to see if they can see what git remote it is set to (if any)

The server is cirrus-browser-bot.eqiad.wmflabs
The code for the bot itself is in /srv/Barry-the-Browser-Test-Bot/barrybot.py

Ok, so the docs are/were wrong, it's running on cirrus-integ.search.eqiad.wmflabs (currently)

[14:17:13] <Krenair> okay so it has a /srv/Barry-the-Browser-Test-Bot/ directory
[14:17:34] <Krenair> it's a git repository which doesn't have any remotes set up
[14:17:39] <Reedy> joy
[14:17:45] <Reedy> Is there a license/copying?
[14:17:51] <Reedy> It's a fork of another bot, so should do
[14:18:15] <Krenair> there's an apache license from Jon Robson at the top of the file
[14:18:24] <Reedy> Yeah, that's expected with how it was forked
[14:18:41] <Krenair> other than that, the only other file is a README
[14:20:26] <Krenair> looks like the last person to touch it was Erik Bernhardson in December 2019

I guess we should get a repo set up for it somewhere and ask @EBernhardson or Discovery-ARCHIVED to add and push to that remote

At some point it was doing V+1 but there was a problem, unfortunately it's been so long I can't find what it was. When i have some time I can try changing it to V+1 and see what happens.

@EBernhardson: Is there any repo so someone could provide a patch, or is this bot a black box for anyone not having CLI access to a specific server?
Asking as using CR instead of V distorts the time-to-review code review metrics. (Non-humans should not CR but V, basically.)

Writing a patch is no problem, it's a 1 line change to the bot which i've already tried. The problem is the bot doesn't have access to v+1 and i have to find time to learn about and execute whatever process is required to get that access.

Writing a patch is no problem, it's a 1 line change to the bot which i've already tried. The problem is the bot doesn't have access to v+1 and i have to find time to learn about and execute whatever process is required to get that access.

I just added Cindy to https://gerrit.wikimedia.org/r/#/admin/groups/1729,members "Group LabelBots"

Bots that want to modify labels for patchsets; e.g., voting V+1 for a patch.

Should cover it

I've started the bot up with the appropriate options for v+1, it should go back through and re-vote on any unmerged patch from the last 2 weeks since they don't have v+1 yet. Will monitor and see how it goes.

EBernhardson claimed this task.

Looks to work as intended.