CU 2.0: Show tool-links underneath IP addresses
Closed, ResolvedPublicMay 5 2020
Actions

Assigned To

Authored By

	Niharika
	Apr 15 2020, 3:57 PM

Description

Goal

In order to find out more information about an IP address CheckUsers need to have an easy way to access tools like geolocate, ip-info etc.
In the current Checkuser tool, that is achieved by having a MediaWiki message that can be configured by the communities. This allows for each community to use tools that work for their needs.
The message is called Checkuser-toollinks.
For this task, we will reuse the same message to display the links.

Mock

The links appear in the dropdown - one per row.

Acceptance criteria

Upon hovering on a cell in the IP column, the list of tools in Checkuser-toollinks message show up at the bottom.
Clicking the link takes one to the respective website with the IP address pre-populated
The website opens in a new tab

Details

Due Date: May 5 2020, 4:00 AM

	Subject	Repo	Branch	Lines +/-
	Show tool links underneath IP addresses	mediawiki/extensions/CheckUser	master	+58 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	May 5 2020	Tchanders	T250290 CU 2.0: Show tool-links underneath IP addresses
		Resolved	May 5 2020	Tchanders	T250051 Buttons in table cells are cluttered and cause a jump on hover

Event Timeline

Niharika triaged this task as Medium priority.Apr 15 2020, 3:57 PM

Niharika created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 3:57 PM

Niharika updated the task description. (Show Details)Apr 15 2020, 4:19 PM

Change 593053 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Show tool links underneath IP addresses

https://gerrit.wikimedia.org/r/593053

gerritbot added a project: Patch-For-Review.Apr 28 2020, 8:19 PM

So far it looks like this:

I realised while doing this that customized icons might be a bit difficult since each wiki can link to different sites. Any ideas @Prtksxna?

This uses the CheckUser message checkuser-toollinks. In CheckUser, checkuser-userlinks-ip is shown next to an IP result for the "Get users" check, whereas checkuser-toollinks is shown under an IP result for the "Get IP addresses" check. For English, checkuser-toollinks is longer.

@Niharika @SPoore Am I right in thinking you're discussing whether to use the existing CheckUser messages or have a new message for Special:Investigate or use something like JsonConfig? If so this could work until then and then should be straightforward to update.

@Niharika @SPoore Am I right in thinking you're discussing whether to use the existing CheckUser messages or have a new message for Special:Investigate or use something like JsonConfig? If so this could work until then and then should be straightforward to update.

We talked to them. The feedback we got seems to indicate that they want to keep the ability to customize the links per-project. As for new message versus existing message, I think it is probably easiest if we go with the existing message as that seems straightforward to do. Having unfamiliar links would probably increase the inertia towards using the tool.

Niharika mentioned this in T246951: CU 2.0: Eventlogging for Special:Investigate [8Hours].Apr 29 2020, 4:03 AM

Tchanders claimed this task.Apr 29 2020, 2:40 PM

ARamirez_WMF moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment board.Apr 29 2020, 4:27 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

dbarratt added a subtask: T250051: Buttons in table cells are cluttered and cause a jump on hover.May 1 2020, 4:42 PM

Niharika updated the task description. (Show Details)May 4 2020, 5:18 PM

Niharika updated the task description. (Show Details)

ARamirez_WMF set Due Date to May 5 2020, 4:00 AM.May 5 2020, 3:45 PM

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 593053 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Show tool links underneath IP addresses

https://gerrit.wikimedia.org/r/593053

dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.May 6 2020, 2:24 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 6 2020, 3:10 PM

I copied the Checkuser-toollinks from enwiki (https://en.wikipedia.org/wiki/MediaWiki:Checkuser-toollinks) on to my local wiki.

@Niharika @Tchanders It doesn't give exactly the same outcome (when compared to current CheckUser). Do we expect the users to change the message?

Special:Investigate:

Special:CheckUser:

@dom_walden Really good find. That's a bug that probably means that we'll have to do this a different way.

We're currently making options for all the links in the message, but looks like there are extra links that we don't want options for.

Unless we can think of a way to filter out those extra links, we may need to make new messages or use JsonConfig (as discussed in T250290#6091934).

Yeah, good catch, @dom_walden. I agree, we should revisit how we do this. I will open a new task for that.

In T250290#6131822, @Niharika wrote:

Yeah, good catch, @dom_walden. I agree, we should revisit how we do this. I will open a new task for that.

OK, I will move this to done, as I don't have anymore testing to do.

dbarratt closed this task as Resolved.May 13 2020, 5:46 PM

dbarratt closed subtask T250051: Buttons in table cells are cluttered and cause a jump on hover as Resolved.

Niharika reopened subtask T250051: Buttons in table cells are cluttered and cause a jump on hover as Open.May 13 2020, 7:30 PM

Niharika mentioned this in T252859: Revisit how we parse CU toollinks [8 Hours].May 15 2020, 8:54 AM

Niharika closed subtask T250051: Buttons in table cells are cluttered and cause a jump on hover as Resolved.Jun 3 2020, 5:57 PM

dbarratt mentioned this in T255504: Decouple Special:Investigate toollinks from Special:CheckUser toollinks.Jun 15 2020, 10:09 PM

Tchanders mentioned this in T257230: Find out which tools check users would like Special:Investigate to link to by default.Jul 6 2020, 5:14 PM

	F31814165: special_investigate_links.png
	May 12 2020, 12:32 PM

	F31785529: image.png
	Apr 28 2020, 8:46 PM

CU 2.0: Show tool-links underneath IP addressesClosed, ResolvedPublicMay 5 2020Actions