Page MenuHomePhabricator

OAuthAuthentication workaround for immediate use
Open, Needs TriagePublic

Description

As discussed in T110460, the OAuthAuthentication extension is currently broken and not working with MediaWiki above version 1.33.
I know there is an ongoing project to modernize the extension and make it work again. Nevertheless it seems to me the work is very long and I don't see a quick solution to it.

Because of this reason, I would propose some quick and dirty patching to the current code to make it work again very soon.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 590638 had a related patch set uploaded (by Luca Mauri; owner: Luca Mauri):
[mediawiki/extensions/OAuthAuthentication@master] Remove reference to wfResetSessionID() and fix error related to LoginForm::successfulLogin()

https://gerrit.wikimedia.org/r/590638

Change 592444 had a related patch set uploaded (by Luca Mauri; owner: Luca Mauri):
[mediawiki/extensions/OAuthAuthentication@master] Remove reference to wfResetSessionID() and fix error related to LoginForm::successfulLogin()

https://gerrit.wikimedia.org/r/592444

Change 590638 abandoned by Luca Mauri:
Remove reference to wfResetSessionID() and fix error related to LoginForm::successfulLogin()

Reason:
Re-done as https://gerrit.wikimedia.org/r/592444

https://gerrit.wikimedia.org/r/590638

Hi @Rxy, thank you for working on this extension!

Can I ask you if we can help someone, somehow, in reviewing this?

My quick and dirty workaround has been to use WSOAuth instead.

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

I don't think it's correct to unassign to @lucamauri. The problem is that no-one is reviewing this: https://gerrit.wikimedia.org/r/c/592444

There's a comment pointing out some problems with that patch.