Page MenuHomePhabricator

Add ability to receive nominornewtalk edits via email
Open, Needs TriagePublicFeature


In the "User Profile" tab of Preferences there is the option to "Email me also for minor edits of pages and files." However, this option does not take into consideration edits marked with nominornewtalk. These edits are usually associated with bots archiving talk pages, meaning that if the "newest edit" is by such a bot, the user will not get an email notification about the change, and thus will not get notified of any further edits to that page.

Please add an additional checkbox or sub-option to allow emails for any minor edit, regardless of whether nominornewtalk is set.

Event Timeline

DannyS712 changed the subtype of this task from "Task" to "Feature Request".
DannyS712 added a project: User-DannyS712.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

(nominornewtalk) isn't really the problem here, as it's behaving as expected. The problem is that minor edits with "Email me also for minor edits of pages and files" unset or (nominornewtalk) prevent notifications for edits after those edits even if no notification is sent.

When a page is edited, notifyOnPageChange() is called to send emails. That then calls out to updateNotificationTimestamp() to get the list of people watching the page. That function collects a list of editors where wl_notificationtimestamp is null, sets the timestamp to the current time, then returns the list.

notifyOnPageChange() then filters that list for users who have enabled email notifications and, if the edit is minor, have enabled notifications for minor edits. However, wl_notificationtimestamp is already set for all watchers regardless of if they will receive a notification or not. Without the notification, they are unlikely to visit the page and reset the timestamp back to null to receive further notifications. wl_notificationtimestamp is also used by Special:Watchlist to determine if an edit has been seen at all, so simply not setting it if no email is sent would break that logic.

Honestly, the reliance on wl_notificationtimestamp to determine whether to email users is the root of a lot of problems; IMO the easiest fix would be the addition of a field that indicates whether the user has been emailed about the page yet.

This problem seems to have now spread to articles, I have a couple dozen pages on my watchlist that I never received notification for, for example this edit by FrescoBot, this edit by QEDKbot, plus edits by BHGbot and Cewbot.

Genuinely curious the status of this - we're almost two years on from two "easy" fixes being proposed, and nothing doing.

kostajh moved this task from Inbox to Triaged on the Growth-Team board.
kostajh subscribed.

Genuinely curious the status of this - we're almost two years on from two "easy" fixes being proposed, and nothing doing.

The answer is that the relevant code isn't maintained by a team. Growth-Team is nominally responsible for Watchlist UI (per but not the backend. Having a patch proposed may help move this along, but no guarantees, unfortunately.

I know this is unlikely to do anything other than annoy the folks watching, but on the off chance it motivates someone... any movement on this?

You can generally assume for all and any tickets that there is no progress apart from what can be seen in a ticket... :)
See also for more context.