Page MenuHomePhabricator
Create Task
Maniphest T251599

(Postgres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function
Closed, ResolvedPublic
Actions

Description

Jenkins failed to merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/588076/ because of a WikiPage query which is failing only on PostgreSQL.

Seems it was once fixed in T23196, but the query has since been rewritten because of actor table migration.

Details

SubjectRepoBranchLines +/-
Encase 'actor_id' value in aggregate functionmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Ammarpad created this task.May 1 2020, 11:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2020, 11:34 AM
daniel renamed this task from Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function to (PostGres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function.May 1 2020, 11:47 AM
daniel subscribed.May 1 2020, 11:51 AM

The failing test is: CreditsActionTest::testOnViewOnExistingPage

Relevant part of the stack trace:
21:55:16 /workspace/src/includes/page/WikiPage.php:1208
21:55:16 /workspace/src/includes/actions/CreditsAction.php:117
21:55:16 /workspace/src/includes/actions/CreditsAction.php:69
21:55:16 /workspace/src/includes/actions/CreditsAction.php:50

Suspicious warning:
PHP Warning: Invalid argument supplied for foreach() in /workspace/src/includes/libs/rdbms/database/Database.php on line 1127

daniel triaged this task as High priority.May 1 2020, 11:52 AM
daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
daniel added subscribers: • Pchelolo, Addshore.

@Pchelolo you said a while ago you might look into putting a postgres mode into MediaWikiDockerDev. Did you get around to doing that? @Addshore, what do you think, how hard would that be? It would be very useful for debugging issues like this one...

daniel moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.May 1 2020, 12:08 PM
gerritbot added a comment.May 1 2020, 12:11 PM

Change 593742 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Add 'actor_id' field to GROUP BY clause, so the query can work in PostGres

https://gerrit.wikimedia.org/r/593742

gerritbot added a project: Patch-For-Review.May 1 2020, 12:11 PM
Ammarpad added a comment.EditedMay 1 2020, 12:25 PM

I have added some details on the above patch commit summary

In T251599#6099743, @daniel wrote:

Suspicious warning:
PHP Warning: Invalid argument supplied for foreach() in /workspace/src/includes/libs/rdbms/database/Database.php on line 1127

Below the query there's a foreach function which is fed the result of the query directly. When the query fails, the value of the variable holding the query result is null and and giving foreach null will always yields that warning

Just notice this is from a different foreach from Database class.

Ammarpad updated the task description. (Show Details)May 1 2020, 12:38 PM
Reedy renamed this task from (PostGres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function to (Postgres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function.May 1 2020, 1:59 PM
Reedy added a project: MediaWiki-General.
• Pchelolo added a comment.May 1 2020, 2:21 PM
In T251599#6099745, @daniel wrote:

@Pchelolo you said a while ago you might look into putting a postgres mode into MediaWikiDockerDev. Did you get around to doing that?

I didn't manage to do the mediawiki-docker-dev one, but I have done it with docker-compose in core repo. I can test this one if needed.

Addshore added a comment.May 2 2020, 6:57 PM
In T251599#6099745, @daniel wrote:

@Pchelolo you said a while ago you might look into putting a postgres mode into MediaWikiDockerDev. Did you get around to doing that? @Addshore, what do you think, how hard would that be? It would be very useful for debugging issues like this one...

Should be trivial if there is a do let image for it (which I believe there is)

daniel moved this task from Later to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.May 8 2020, 10:12 AM
• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).May 12 2020, 2:10 PM
Ammarpad added a comment.Jul 3 2020, 11:37 AM

Hi @daniel what's the status of this task? Should I just skip Postgres in the test for patch that fixes T187518?

Umherirrender closed this task as Resolved.Jul 14 2020, 8:54 PM
Umherirrender assigned this task to Ammarpad.
gerritbot added a comment.Jul 14 2020, 9:14 PM

Change 593742 merged by jenkins-bot:
[mediawiki/core@master] Encase 'actor_id' value in aggregate function

https://gerrit.wikimedia.org/r/593742

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 14 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 14 2020, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits