Page MenuHomePhabricator
Create Task
Maniphest T252176

[Regression pre-wmf.32] The Reply box is opening up automatically after posting a reply
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Open any talk page
  2. Click Reply link next to any comment
  3. Type a reply and post it

Observe that, another reply box is immediately opening up under the newly added comment.

Browser: Chrome.

Environment: Beta

Details

SubjectRepoBranchLines +/-
Manually clear out session storage on teardownmediawiki/extensions/DiscussionToolsmaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.May 7 2020, 10:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2020, 10:50 PM
Ryasmeen triaged this task as High priority.May 7 2020, 10:50 PM
Ryasmeen added a project: Editing-team (Q3 2019-2020 Kanban Board).
Ryasmeen moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.
DannyS712 added a project: Regression.May 8 2020, 4:32 PM
Ryasmeen added subscribers: Esanders, matmarex.May 8 2020, 7:54 PM
matmarex added a comment.May 8 2020, 9:40 PM

It looks like we don't clear the auto-save anymore when posting or discarding the reply. This used to work, but it was actually a bit fragile now that I think of it, I noted that:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/587992

It wasn't clear to me initially how discarding the autosaved version works, since I didn't see any code for that. It turns out that it works because .teardown() calls .clear() which calls .setValue(''), and that empties the autosaved text too.

Ed's work on switching editors refactored a bunch of things in teardown, maybe it broke this.

Esanders added a comment.May 8 2020, 10:06 PM
In T252176#6120185, @matmarex wrote:

Ed's work on switching editors refactored a bunch of things in teardown, maybe it broke this.

Yes, we started detaching the 'change' event sooner...

gerritbot added a comment.May 8 2020, 10:06 PM

Change 595239 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Manually clear out session storage on teardown

https://gerrit.wikimedia.org/r/595239

gerritbot added a project: Patch-For-Review.May 8 2020, 10:06 PM
Esanders moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.May 8 2020, 10:06 PM
gerritbot added a comment.May 8 2020, 10:12 PM

Change 595239 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Manually clear out session storage on teardown

https://gerrit.wikimedia.org/r/595239

matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.May 8 2020, 10:15 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 8 2020, 11:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.May 8 2020, 11:22 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.May 11 2020, 3:12 PM
• ppelberg mentioned this in T253349: Reply tool opens automatically .May 21 2020, 11:40 PM
matmarex merged a task: T253349: Reply tool opens automatically .May 22 2020, 5:02 PM
• ppelberg closed this task as Resolved.Jun 1 2020, 1:46 AM
• ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 1 2020, 1:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL