Page MenuHomePhabricator
Create Task
Maniphest T252702

Reply inserted at the wrong indentation level when the previous message ends in a bullet list
Closed, ResolvedPublic
Actions

Description

Reply is inserted at the wrong indentation level when the previous message ends in a bullet list.

Consider these two examples:

== 1 ==
Comment
* with list ~~~~

== 2 ==
Comment
* with list
and PS ~~~~

They are both comments with no indentation. When you reply to them, the new comments should have indentation of 1, like this:

== 1 ==
Comment
* with list ~~~~
:Expected indentation ~~~~

== 2 ==
Comment
* with list
and PS ~~~~
:Expected indentation ~~~~

But the actual result in case 1 is this:

== 1 ==
Comment
* with list ~~~~
** Actual indentation ~~~~

Details

SubjectRepoBranchLines +/-
Fix indentation level when replying to comments with mixed indentationmediawiki/extensions/DiscussionToolsmaster+107 -60
Add a test case for replies to top-level comments with mixed indentationmediawiki/extensions/DiscussionToolsmaster+31 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.May 13 2020, 6:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2020, 6:00 PM
matmarex mentioned this in T250127: If the first reply includes the other kind of list formatting, then don't add any more (Let me pick * or : myself).May 13 2020, 6:00 PM
ppelberg added a project: Editing-team.May 18 2020, 3:28 PM
Esanders mentioned this in T252708: Child comments inherit indentation from end of parent comment.May 21 2020, 2:54 PM
Esanders added subscribers: EniPort, Esanders.

This was also reported in T252708 by @EniPort on hu.wiki. Diff: https://w.wiki/RT8

Esanders updated the task description. (Show Details)May 21 2020, 3:03 PM
• Whatamidoing-WMF subscribed.Jun 15 2020, 8:09 PM

The actual result in Case 1 might have changed: https://nl.wikipedia.org/w/index.php?title=Overleg_Wikipedia:Universele_gedragscode&type=revision&diff=56535077&oldid=56534101

ppelberg added a parent task: T255841: Create approach to list syntax inheritance.Jun 19 2020, 1:17 AM
ppelberg subscribed.Jul 28 2020, 1:27 AM
In T252702#6225524, @Whatamidoing-WMF wrote:

The actual result in Case 1 might have changed: https://nl.wikipedia.org/w/index.php?title=Overleg_Wikipedia:Universele_gedragscode&type=revision&diff=56535077&oldid=56534101

A question related to the observation @Whatamidoing-WMF made above: @matmarex can you confirm whether this is still an issue?

It appears that in both cases – ==1== and ==2== – comments are being indented at the correct level of indentation (read: they are being indented "once"): https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User_talk%3APpelberg-test%2Fsandbox&type=revision&diff=441225&oldid=441223.

ppelberg edited projects, added Editing-team (Kanban Board), OWC2020 (Reply Tool Opt Out); removed Editing-team.Jul 28 2020, 1:27 AM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg moved this task from Ready to Be Worked On to Incoming on the Editing-team (Kanban Board) board.Jul 29 2020, 3:46 PM
matmarex added a comment.Jul 29 2020, 11:46 PM

Indeed, it looks like this case was accidentally fixed in rEDTO569db3603c10: Improve detecting template-generated multi-line comments. I used git bisect and ran the tests on each commit to find out.

However, when a similar comment is itself a reply instead of top-level, it still behaves incorrectly:

== 3 ==
Lead comment ~~~~
:Comment
:* with list ~~~~

When replying to the second comment in this example, the expected result is:

== 3 ==
Lead comment ~~~~
:Comment
:* with list ~~~~
::Expected indentation ~~~~

But you actually get:

== 3 ==
Lead comment ~~~~
:Comment
:* with list ~~~~
:**Actual indentation ~~~~
gerritbot added a comment.Jul 29 2020, 11:47 PM

Change 617292 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add a test case for replies to top-level comments with mixed indentation

https://gerrit.wikimedia.org/r/617292

gerritbot added a project: Patch-For-Review.Jul 29 2020, 11:47 PM
ppelberg added a comment.Jul 30 2020, 12:01 AM
In T252702#6347165, @matmarex wrote:

Indeed, it looks like this case was accidentally fixed in rEDTO569db3603c10: Improve detecting template-generated multi-line comments. I used git bisect and ran the tests on each commit to find out.

However, when a similar comment is itself a reply instead of top-level, it still behaves incorrectly:

Understood. [i]

To confirm: does https://gerrit.wikimedia.org/r/617292 correct the behavior you described in T252702#6347165 and produce the expected result (also described in T252702#6347165)?

== 3 ==
Lead comment ~~~~
:Comment
:* with list ~~~~
::Expected indentation ~~~~

i. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User_talk%3APpelberg-test%2Fsandbox&type=revision&diff=441807&oldid=441806

matmarex added a comment.Jul 30 2020, 12:03 AM

No, it only adds a test case for examples 1 and 2, so that we don't accidentally un-fix them. I'm working on also fixing example 3.

matmarex claimed this task.Jul 30 2020, 12:03 AM
matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
ppelberg added a comment.Jul 30 2020, 12:23 AM
In T252702#6347186, @matmarex wrote:

No, it only adds a test case for examples 1 and 2, so that we don't accidentally un-fix them. I'm working on also fixing example 3.

Roger that.

gerritbot added a comment.Jul 30 2020, 11:40 AM

Change 617292 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add a test case for replies to top-level comments with mixed indentation

https://gerrit.wikimedia.org/r/617292

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 30 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2020, 12:10 PM
ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (Reply Tool Opt Out) board.Aug 1 2020, 1:54 AM
gerritbot added a comment.Aug 4 2020, 9:37 PM

Change 618400 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix indentation level when replying to comments with mixed indentation

https://gerrit.wikimedia.org/r/618400

gerritbot added a project: Patch-For-Review.Aug 4 2020, 9:37 PM
JTannerWMF moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Aug 5 2020, 5:54 PM
gerritbot added a comment.Aug 10 2020, 10:27 PM

Change 618400 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix indentation level when replying to comments with mixed indentation

https://gerrit.wikimedia.org/r/618400

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.4; 2020-08-11); removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 10 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 11:11 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 11 2020, 4:59 AM
matmarex added a project: Skipped QA.

(no manual QA required, because this is covered by unit tests)

ppelberg closed this task as Resolved.Aug 13 2020, 1:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL