| • AMuigai | |
| May 14 2020, 8:35 PM |
| F31937602: Screen Shot 2020-07-16 at 23.06.19.png | |
| Jul 16 2020, 9:10 PM |
| F31937603: Screen Shot 2020-07-16 at 23.05.20.png | |
| Jul 16 2020, 9:10 PM |
| F31937604: Screen Shot 2020-07-16 at 23.05.10.png | |
| Jul 16 2020, 9:10 PM |
This is about being able to read an article in a RTL language.
Make sure the RTL language entries in the languages list flow RTL
In order to have this, we need this T254311: Article Language list should have buttons instead of radio buttons to be resolved first, otherwise radio button looks bad.
It will be better but let's not make it a blocker. Many things look weird with mixed-directionality but it still works.
The overall radio list will follow the UI language (LTR) so the label is on the left and the radio button on the right. When the label is for a RTL language, its text is right aligned instead of left aligned. Setting dir on that node should do it.
Here's the status of this ticket :
The latest comparsion screenshot of LTR - RTL can be found here
https://github.com/wikimedia/wikipedia-kaios/pull/248#issuecomment-652994222
Receive feedback from Moriel
https://github.com/wikimedia/wikipedia-kaios/pull/248#issuecomment-655080447
Moving this back to Dev column as it requires one more update
Known issues to fix for the RTL content with LTR text
| (style*1) incorrect outline in the link | (style*1) incorrect outline in the link | Incorrect position of Reference [2] *2 |
 |  |  |
*1 : The outline should cover the whole part as the single link
*2 : It should be [2].Dantel
This is pushed in the PR https://github.com/wikimedia/wikipedia-kaios/pull/248
Regards the above issues, *2 has been fixed
*1 : The outline should cover the whole part as the single link
I can't find any solution for this in the firefox, as we use outline style for the border, and outline style has the issue when combining ltr and rtl in the sentence unless we change to border style, then border contains space which is not expected. This is not the serious issue and I recommend we fix it in another ticket T260391: Outline style broken in RTL language just within the styling issue.