Changing a value with unit: label and unit name mixed, see screenshot.
Browser. Firefox 77
Try to change the length on https://commons.wikimedia.org/wiki/File:Ship_Josephine_ENI_05109590_-_on_Spree,_Berlin-7662.jpg
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix overlapping text in qualifier quantity input | mediawiki/extensions/WikibaseMediaInfo | master | +1 -2 |
Event Timeline
Comment Actions
@Ramsey-WMF or @mwilliams, do either of you have a mockup of how the editing UI is supposed to look in this situation? I can see that some absolutely-positioned label text for "unit" and "metre" is colliding here, but I want to make sure I understand what is supposed to go where before fixing.
Comment Actions
@egardner It seems like it is supposed to look like this (height example):
The spacing there feels a bit weird though, I'd expect something like "Unit: Metre" since they look unrelated or two different things currently.
Comment Actions
Ok, I think that the labelPosition: "before" option that's being set for the QuantityInputWidget's EntityAutoCompleteInputWidget child (QuantityInputWidget.js L34) might be the source of this problem.
By removing that option, you get the layout that you see below. Does this seem correct? (Disregard my nonsensical local data)
Comment Actions
Change 603676 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix overlapping text in qualifier quantity input
Comment Actions
Change 603676 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix overlapping text in qualifier quantity input