No events are getting fired for username selection option
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Jun 17 2020, 12:17 AM

Description

This task is about making it so the correct event is fired when people interact with the "👤" icon in the Reply tool's visual text input mode.

Behavior

Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats?trackdebug=1
Click any "Reply" link
Open the Reply tool's visual mode
Click the the "👤" icon in the toolbar

Expected

✅ Observe the following event is shown in the console as being logged:

"editor_interface": "visualeditor"
"schema": "VisualEditorFeatureUse"
"feature": "mwUsernameCompletion"
"action": "window-open-from-tool"

Actual
5.❗️Observe no event is shown in the console as being logged.

Done

The Expected behavior has been implemented

Details

	Subject	Repo	Branch	Lines +/-
	Fire window-open-from-tool event for username completion from toolbar	mediawiki/extensions/DiscussionTools	master	+7 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T233443 [Epic] Reply Tool
Resolved	ppelberg	T244500 Instrument new replying workflow
Resolved	DLynch	T255638 No events are getting fired for username selection option

Event Timeline

Ryasmeen created this task.Jun 17 2020, 12:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2020, 12:17 AM

ppelberg edited projects, added OWC2020 (OWC2020 Replying 2.0), Editing-team (Q3 2019-2020 Kanban Board); removed OWC2020.Jun 17 2020, 7:08 PM

ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 2.0) board.

ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 18 2020, 2:41 AM

ppelberg updated the task description. (Show Details)Jun 18 2020, 11:02 PM

ppelberg added a parent task: T244500: Instrument new replying workflow.

ppelberg moved this task from Upcoming to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.

Task description updated

Fixed typo: changed from FROM window-open-from-sequence --TO--> window-open-from-tool

• Esanders assigned this task to DLynch.Jun 23 2020, 3:09 PM

Change 607302 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/DiscussionTools@master] Fire window-open-from-tool event for username completion from toolbar

https://gerrit.wikimedia.org/r/607302

gerritbot added a project: Patch-For-Review.Jun 23 2020, 3:24 PM

matmarex moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 23 2020, 10:41 PM

• Esanders added a project: DiscussionTools.Jun 25 2020, 12:49 PM

• Esanders moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 25 2020, 8:08 PM

Change 607302 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fire window-open-from-tool event for username completion from toolbar

https://gerrit.wikimedia.org/r/607302

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 25 2020, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2020, 9:10 PM

ppelberg added a project: Editing QA.Jun 26 2020, 4:03 PM

ppelberg moved this task from Inbox to High Priority on the Editing QA board.