Page MenuHomePhabricator
Create Task
Maniphest T255842

Restoring default settings is not working in all wikis
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Open en.wikipedia.org (or any WMF wiki);
  2. Make sure you are logged-in;
  3. Click on Preferences;
  4. Click Restore all default settings (in all sections).

Actual Results:
Default settings are not restored.

Expected Results:
Default settings should be restored.

Details

SubjectRepoBranchLines +/-
UserOptionsManager: fix options reset.mediawiki/coreREL1_35+18 -1
UserOptionsManager: fix options reset.mediawiki/coremaster+18 -1
Customize query in gerrit

Event Timeline

Agusbou2015 created this task.Jun 19 2020, 1:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2020, 1:58 AM
Agusbou2015 renamed this task from Restoring default settings is not working in all wikis to [BUG REPORT] Restoring default settings is not working in all wikis.Jun 19 2020, 2:00 AM
Agusbou2015 renamed this task from [BUG REPORT] Restoring default settings is not working in all wikis to Restoring default settings is not working in all wikis.
Agusbou2015 added a project: MediaWiki-Core-Preferences.
DannyS712 triaged this task as High priority.Jun 19 2020, 2:03 AM
DannyS712 added projects: Regression, Beta-Cluster-reproducible.
DannyS712 changed the subtype of this task from "Task" to "Bug Report".
Iniquity added a project: Tech Ambassadors & Translators.Jun 19 2020, 2:05 AM
Iniquity moved this task from Backlog to Mostly FYI (take action if you want) on the Tech Ambassadors & Translators board.
DannyS712 added projects: Contributors-Team, Platform Engineering.Jun 19 2020, 2:06 AM
• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jun 24 2020, 8:26 PM
• Pchelolo subscribed.

Probably a fallout of the recent user options management refactoring. Has to be fixed.

BPirkle moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.Jun 24 2020, 8:58 PM
gerritbot added a comment.Jun 24 2020, 10:49 PM

Change 607635 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/607635

gerritbot added a project: Patch-For-Review.Jun 24 2020, 10:49 PM
Agusbou2015 added a subscriber: Marostegui.Jul 4 2020, 2:32 AM

@Marostegui When will you plan to merge the patch?

Reedy subscribed.Jul 4 2020, 2:44 AM
In T255842#6278281, @Agusbou2015 wrote:

@Marostegui When will you plan to merge the patch?

I don't think Manuel is the correct person to be merging it

Aklapper removed a subscriber: Marostegui.Jul 4 2020, 6:31 AM

@Agusbou2015: Please don't subscribe or ping random people. You've been asked not to do this before. Thanks.

gerritbot added a comment.Aug 7 2020, 6:57 AM

Change 607635 merged by jenkins-bot:
[mediawiki/core@master] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/607635

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 7 2020, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 7 2020, 7:10 AM
tstarling closed this task as Resolved.Aug 10 2020, 4:09 AM
tstarling claimed this task.
gerritbot added a comment.Aug 10 2020, 2:19 PM

Change 619102 had a related patch set uploaded (by Reedy; owner: Ppchelko):
[mediawiki/core@REL1_35] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/619102

gerritbot added a project: Patch-For-Review.Aug 10 2020, 2:19 PM
gerritbot added a comment.Aug 14 2020, 2:09 AM

Change 619102 merged by jenkins-bot:
[mediawiki/core@REL1_35] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/619102

Maintenance_bot removed a project: Patch-For-Review.Aug 14 2020, 2:10 AM
ReleaseTaggerBot added a project: MW-1.35-notes.Aug 14 2020, 3:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits