Page MenuHomePhabricator

Restoring default settings is not working in all wikis
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Open en.wikipedia.org (or any WMF wiki);
  2. Make sure you are logged-in;
  3. Click on Preferences;
  4. Click Restore all default settings (in all sections).

Actual Results:
Default settings are not restored.

Expected Results:
Default settings should be restored.

Event Timeline

Agusbou2015 renamed this task from Restoring default settings is not working in all wikis to [BUG REPORT] Restoring default settings is not working in all wikis.Jun 19 2020, 2:00 AM
Agusbou2015 renamed this task from [BUG REPORT] Restoring default settings is not working in all wikis to Restoring default settings is not working in all wikis.
DannyS712 changed the subtype of this task from "Task" to "Bug Report".
Pchelolo added a subscriber: Pchelolo.

Probably a fallout of the recent user options management refactoring. Has to be fixed.

Change 607635 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/607635

@Marostegui When will you plan to merge the patch?

I don't think Manuel is the correct person to be merging it

@Agusbou2015: Please don't subscribe or ping random people. You've been asked not to do this before. Thanks.

Change 607635 merged by jenkins-bot:
[mediawiki/core@master] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/607635

tstarling claimed this task.

Change 619102 had a related patch set uploaded (by Reedy; owner: Ppchelko):
[mediawiki/core@REL1_35] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/619102

Change 619102 merged by jenkins-bot:
[mediawiki/core@REL1_35] UserOptionsManager: fix options reset.

https://gerrit.wikimedia.org/r/619102