Page MenuHomePhabricator

Alter return of SpecialPage::getDescription for Term related special pages when fed props is enabled
Closed, ResolvedPublic

Description

SpecialPage::getDescription is key here

	 * Returns the name that goes in the \<h1\> in the special page itself, and
	 * also the name that will be listed in Special:Specialpages

The getDescription method for the relevant special pages should be overridden to allow for use of a different description when federated properties is enabled.
(description in this context has nothing to do with wikibase descriptions)

Entity types (we need item) also already have i18n values.

	"wikibase-entity-item": "Item",

A decision for the implementor would be to decide if:

  • Some IF condition goes in the special pages switching on the config
  • Some message prefix (or the whole message?) is injected

Acceptance Criteria:

  • SetLabel done
  • SetDescription done
  • SetAliases done
  • SetLabelDescriptionAliases done
  • Paramertized message (for entity types) rather than hardcoding the "Item" type into the string.

Event Timeline

Change 608903 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: SpecialPages: Parameterize description

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608903

Change 608903 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: SpecialPages: Parameterize description

https://gerrit.wikimedia.org/r/608903

Resolved as it's in the Done column at the end of sprint 3 (start of sprint 4)