Modify Special:MediaSearch to use the MediaQueryBuilder
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Cparle
	Jul 7 2020, 10:05 AM

Description

ATM Special:MediaSearch uses an api that wraps the search api

When https://phabricator.wikimedia.org/T252685 is merged we need to change Special:MediaSearch to use the new backend. ATM the new backend will only be activated if mediasearch=1 is in the request url, and the search is in the File namespace

Acceptance criteria:

Special:MediaSearch uses MediaQueryBuilder (possibly via the search api) instead of making multiple calls to the search api using haswbstatement etc

This is not something that can be QAd, except for to make sure nothing has broken

Details

	Subject	Repo	Branch	Lines +/-
	Pass mediasearch API requests along to plain old search (with mediasearch profile)	mediawiki/extensions/WikibaseMediaInfo	master	+22 -279

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		matthiasmullie	T257295 Modify Special:MediaSearch to use the MediaQueryBuilder
		Resolved		matthiasmullie	T257304 Implement filtering by type in MediaQueryBuilder

Event Timeline

Cparle created this task.Jul 7 2020, 10:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2020, 10:05 AM

Cparle updated the task description. (Show Details)Jul 7 2020, 10:12 AM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jul 7 2020, 2:30 PM

Blocked on T257304

Aklapper added a subtask: T257304: Implement filtering by type in MediaQueryBuilder.Jul 8 2020, 10:50 AM

Change 610281 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Pass mediasearch API requests along to plain old search (with mediasearch profile)

https://gerrit.wikimedia.org/r/610281

gerritbot added a project: Patch-For-Review.Jul 8 2020, 12:29 PM

I've rewritten the existing API to proxy to the search API because it'd break the frontend rewrite.
Once that is complete, we can transition away from the old API endpoint altogether.

Nothing that this can be merged independently of the MediaSearch vue.js port (T251940).

Cparle mentioned this in T258453: [Spike] Comparison test cases - Commons Special:Search and Special:MediaSearch.Jul 21 2020, 11:10 AM

CBogen added a project: SDAW-MediaSearch (MediaSearch-Alpha).Jul 27 2020, 4:51 PM

CBogen mentioned this in T258063: [M] Remove ApiQueryMediaSearch.Jul 30 2020, 5:09 PM

Etonkovidova closed subtask T257304: Implement filtering by type in MediaQueryBuilder as Resolved.Sep 4 2020, 11:07 PM

This has taken too long to land & we no longer need this intermediate step because the Vue work has already been merged.
I've worked around the blocker for T258063, which makes this ticket obsolete.

Change 610281 abandoned by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@master] Pass mediasearch API requests along to plain old search (with mediasearch profile)

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/ /625892/