Page MenuHomePhabricator

Db-notability-* templates renamed
Closed, ResolvedPublic

Description

Per the discussion at en:Template talk:Db-notice:#Requested move 15 July 2020, the templates Template:Db-notability-notice-NPF and Template:Db-notability-notice have been moved to Template:Db-significance-notice-NPF and Template:Db-significance-notice. Per @DannyS712, this requires some changes to the page curation system.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Looks like someone needs to edit the files NewPagesFeed_Templates.xml and modules/ext.pageTriage.defaultDeletionTagsOptions/ext.pageTriage.defaultDeletionTagsOptions.js in the code repository mediawiki/extensions/PageTriage, as they include the string notability-notice.
If you are curious and interested in writing this software change, see https://www.mediawiki.org/wiki/Gerrit/Tutorial - thanks!

DannyS712 moved this task from Unsorted to Others on the User-DannyS712 board.

Actually, does this need an update? NewPagesFeed_Templates.xml is an export of enwiki's templates (that I can't figure out how to easily generate), and modules/ext.pageTriage.defaultDeletionTagsOptions/ext.pageTriage.defaultDeletionTagsOptions.js is based off of that. If we want to change the names, we should probably also export the tags again. Would it make more sense to just update https://en.wikipedia.org/wiki/MediaWiki:PageTriageExternalDeletionTagsOptions.js instead (I believe this would have to be done anyways)?

I've updated the .js file on enwiki - flag for revert if it broke anything, if this resolved this issue feel free to assign to me and mark closed

I've updated the .js file on enwiki - flag for revert if it broke anything, if this resolved this issue feel free to assign to me and mark closed

assuming this is https://en.wikipedia.org/w/index.php?title=MediaWiki:PageTriageExternalDeletionTagsOptions.js&diff=972035313&oldid=874921244
the stored version in the extension needs to be updated too though

Change 740258 had a related patch set uploaded (by Tol; author: Tol):

[mediawiki/extensions/PageTriage@master] Changed the template \"Db-notability-notice-NPF\" to \"Db-significance-notice-NPF\" as it was moved on enwiki.

https://gerrit.wikimedia.org/r/740258

I've just changed the JS config file and the XML to point to the new title.

Just since there is already attention of people who know about this extension here - I'm not a fan of having this "data" hard coded in the extension. Is there a good reason it couldn't be an on-project .json file (or something similar)?

Novem_Linguae moved this task from Soon to Backlog on the PageTriage board.
MPGuy2824 claimed this task.
MPGuy2824 added a subscriber: MPGuy2824.

Just since there is already attention of people who know about this extension here - I'm not a fan of having this "data" hard coded in the extension. Is there a good reason it couldn't be an on-project .json file (or something similar)?

@Xaosflux, i've created a new task (T318509: Move wiki-specific template names from PageTriage to an on-wiki .json) for this particular suggestion. Closing this ticket.

Change 740258 abandoned by Kosta Harlan:

[mediawiki/extensions/PageTriage@master] Update speedy deletion template title

Reason:

Cleaning up the code review backlog; please restore if you intend to work on it.

https://gerrit.wikimedia.org/r/740258

If someone wants me to make an on-wiki edit, please drop an edit request and ping me.

Looks like the edit was already made onwiki back in 2020. Thank you very much for offering though @Xaosflux. You will probably see some {{edit interface-protected}}s from us on those MediaWiki:PageTriage*.js pages in the future :)