Page MenuHomePhabricator

[reply] from diff creates very tight column
Closed, ResolvedPublic

Description

When I looks to some diff of discussion pages, there is (sometimes?) button [reply] visible in the diff.
But clicking creates very tight textarea

image.png (953×1 px, 60 KB)

Event Timeline

Don’t you use wikEd/wikEdDiff? T258815 is about them, although from a different perspective.

Don’t you use wikEd/wikEdDiff? T258815 is about them, although from a different perspective.

No, without WikiEd.
But I use

mediaWiki.loader.load('//en.wikipedia.org/w/index.php?title=User:Enterprisey/fancy-diffs.js&action=raw&ctype=text/javascript');

It looks like a different gadget that does the same thing (making wikitext links in the diffs clickable), and the result is similar.

@matmarex as @Tacsipacsi referenced above this issue is related to T258815 would @ppelberg be right to assume that this issue will be resolved once T252555 is?

The patch for T252555 is deployed now, and this should be fixed as well. @JAnD Can you confirm that the issue no longer occurs?

Hey @JAnD we will close this on 30-Oct if we do not hear from you. Please feel empowered to reopen the task if the issue persists.

The patch for T252555 is deployed now, and this should be fixed as well. @JAnD Can you confirm that the issue no longer occurs?

For now I have not [reply] in diffs, so I cannot confirm or reject.
But the external script was changed too.

ppelberg claimed this task.

The patch for T252555 is deployed now, and this should be fixed as well. @JAnD Can you confirm that the issue no longer occurs?

For now I have not [reply] in diffs, so I cannot confirm or reject.
But the external script was changed too.

Understood – thank you for following up, @JAnD. I'm going to mark this task is resolved. If at any point you observe otherwise, please let us know here.

The patch for T252555 is deployed now, and this should be fixed as well. @JAnD Can you confirm that the issue no longer occurs?

For now I have not [reply] in diffs, so I cannot confirm or reject.
But the external script was changed too.

Actually the fix was to remove the [reply] links from diffs—now they are generated server side and appear only in actual content. So not seeing the links means that the fix works.