⚓ T260314 Restrict making content (non-label/alias) changes to system-provided ZObjects to users with a special right

	Subject	Repo	Branch	Lines +/-
	Show a header on each ZPersistentObject page	mediawiki/extensions/WikiLambda	master	+445 -18

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T344206 Special:MathStatus exception error on Wikifunctions
Resolved		Jdforrester-WMF	T342865 Post-creation work for wikifunctionswiki
Resolved		BTullis	T289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
Resolved		Jdforrester-WMF	T275945 Create Wikifunctions.org
Resolved		Jdforrester-WMF	T299176 Phase Theta – Root task
Resolved		DVrandecic	T299598 Add security limits to the Wikifunctions system to maintain stability and integrity of the content
Resolved		gengh	T260314 Restrict making content (non-label/alias) changes to system-provided ZObjects to users with a special right
Resolved		DVrandecic	T260315 Create a file containing the core types to upload to wiki
Resolved		DVrandecic	T269182 Figure out validation and well-formedness
Resolved		gengh	T303338 The WikiLambda system understands the nature of changes being made and can react to them
Resolved		gengh	T303339 Provide a tree-diffing system for WikiLambda that allows us to compare changes to ZObjects
Resolved		gengh	T303340 Decide whether we're going to re-use an existing tree-diffing system or build our own
Resolved		gengh	T315882 WikiLambda: implement diffing algorithm
Resolved		gengh	T321183 Design an architecture proposal for user authorization that can use the data returned from WikilambdaDiff to restrict access
Resolved		gengh	T321186 Discuss and decide all areas for restricted access (high granularity)
Resolved		gengh	T321184 Implement user authorization base classes and one POC

DVrandecic created this task.Aug 13 2020, 1:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 1:08 AM

DVrandecic moved this task from Phase β to Phase α on the Abstract Wikipedia team board.Aug 13 2020, 1:11 AM

DVrandecic edited projects, added Abstract Wikipedia team (Phase α); removed Abstract Wikipedia team (Phase β).

DVrandecic triaged this task as Medium priority.Aug 13 2020, 1:13 AM

DVrandecic updated the task description. (Show Details)

DVrandecic added a subtask: T260315: Create a file containing the core types to upload to wiki.Aug 13 2020, 1:19 AM

Change 619281 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiLambda@master] [WIP] Show a header on each ZPersistentObject page

https://gerrit.wikimedia.org/r/619281

gerritbot added a project: Patch-For-Review.Aug 18 2020, 6:08 PM

This really shouldn't be in Phase α because most of the things that are inalienable here are the types and their keys. Without actually having those, we cannot ensure the hardcodedness. So moving this back to Phase β.

DVrandecic moved this task from Phase α to Phase β on the Abstract Wikipedia team board.Aug 20 2020, 12:10 AM

DVrandecic edited projects, added Abstract Wikipedia team (Phase β); removed Abstract Wikipedia team (Phase α).

Change 619281 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Show a header on each ZPersistentObject page

https://gerrit.wikimedia.org/r/619281

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2020, 5:10 PM

DVrandecic lowered the priority of this task from Medium to Low.Aug 27 2020, 9:24 PM

DVrandecic mentioned this in T260315: Create a file containing the core types to upload to wiki.

DVrandecic moved this task from Phase β to Phase γ on the Abstract Wikipedia team board.

DVrandecic edited projects, added Abstract Wikipedia team (Phase γ); removed Abstract Wikipedia team (Phase β).

Other hardcoded truths are the following basic types and their structure:

Z1/Object
Z2/Persistent object
Z3/Key
Z4/Type
Z5/Error
Z6/String
Z7/Function call
Z8/Function
Z9/Reference
Z10/List
Z11/Monolingual text
Z12/Multilingual text
Z14/Implementation

More may be added.

What it means to be hardcoded: if there is anything in the Wiki about these types, i.e. if there is a page Z2, then it can only be a type that has the keys as specified for Z2 according to the specification. The types of these keys cannot be changed, no new keys may be added, no keys may be removed. There do not *have* to be such pages representing these types, but if they exist, they must be consistent with the specification.

The pages are still editable, in particular, documentation, labels, etc. are editable as wished, but the inalienable truths are not.

Ideas and notes from task meeting:

On edit, check certain things against a hardcoded list. E.g. if ZID is in the above list, do the special check that only labels (or doc or aliases) is changeable. This needs to be kept up to date as we evolve.

Walk the tree of before and after to see if it is an allowed change.

Or: Two APIs for editing labels and for editing other things.

This sounds like protection levels? I.e. some things editable by anyone, some only by confirmed users, some only by admins, or other levels. However, you want it granular so that labels can be at a different protection level from other keys. Wikidata has desired something similar, to allow granular protection of some statements while allowing others within the same item to be editable by anyone. Anyway, would using standard Mediawiki protection procedures work for this for now?

See also T260315#6441028 for a way to implement this.

DVrandecic mentioned this in T263066: Upload initial ZObjects to wiki.Sep 16 2020, 9:53 PM

DVrandecic closed subtask T260315: Create a file containing the core types to upload to wiki as Resolved.Oct 7 2020, 12:38 AM

DVrandecic raised the priority of this task from Low to Medium.Oct 7 2020, 12:54 AM

DVrandecic mentioned this in T269182: Figure out validation and well-formedness.Dec 1 2020, 11:33 PM

DVrandecic added a subtask: T269182: Figure out validation and well-formedness.Jan 27 2021, 5:20 PM

DVrandecic added a parent task: T275940: Split out the nature of different edits to check against different rights.Feb 27 2021, 12:46 AM

I am changing the priority to High because not hardcoding them may cause errors.

@AnotherEditor144: Hi and welcome. Please see https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities and do not change priority. Thanks.

Jdforrester-WMF removed a parent task: T275940: Split out the nature of different edits to check against different rights.Mar 3 2021, 5:14 PM

Jdforrester-WMF added a subtask: T275940: Split out the nature of different edits to check against different rights.

DVrandecic moved this task from Phase γ to Phase η – Generic types on the Abstract Wikipedia team board.Mar 3 2021, 5:32 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team (Phase γ).

DVrandecic moved this task from Phase η – Generic types to Phase θ – Throttling on the Abstract Wikipedia team board.Mar 10 2021, 12:49 AM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team (Phase η – Generic types).

DVrandecic closed subtask T269182: Figure out validation and well-formedness as Resolved.Mar 24 2021, 5:52 PM

Jdforrester-WMF renamed this task from Hardcode certain inalienable truths to Restrict making content (non-label/alias) changes to system-provided ZObjects to users with a special right.Jan 19 2022, 10:26 PM

Jdforrester-WMF added a parent task: T299598: Add security limits to the Wikifunctions system to maintain stability and integrity of the content.

DVrandecic mentioned this in T299176: Phase Theta – Root task.Jan 19 2022, 11:01 PM

Jdforrester-WMF removed a subtask: T275940: Split out the nature of different edits to check against different rights.Mar 8 2022, 10:28 PM

Jdforrester-WMF added a subtask: T303338: The WikiLambda system understands the nature of changes being made and can react to them.

Jdforrester-WMF moved this task from Incoming to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Jul 19 2022, 3:14 PM

Jdforrester-WMF mentioned this in T282914: Provide user rights for editing of ZObjects at all, and specific ones for ZImplementations, ZTesters, and ZFunctions.Nov 30 2022, 10:21 PM

gengh claimed this task.Feb 22 2023, 11:56 AM

gengh moved this task from Ready: G6. Stable & secure to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Feb 28 2023, 10:08 AM

DVrandecic closed subtask T303338: The WikiLambda system understands the nature of changes being made and can react to them as Resolved.Mar 30 2023, 10:42 PM

Tested and works. Got scared for a moment when testing :D