Page MenuHomePhabricator

Echo notification clickable link area overlapping Homepage link
Closed, DuplicatePublic

Description

  1. On a betalabs log in and enable Homepage with the option "Default to newcomer homepage from username link in personal tools" (Special:Preferences in User profile tab in Newcomer homepage section).
  2. Hover over Echo notification badges - and see that areas to click for Notices and Alerts overlapping and the Alert click area overlaps the user name clickable area.

Screen Shot 2020-08-24 at 4.30.28 PM.png (130×307 px, 13 KB)

(click on the animated gif)
notfication_link_homepage4.gif (130×783 px, 36 KB)

Event Timeline

Demian subscribed.

This is caused by the notification (Echo) icons' hidden text (only used by screen readers). The shape that you see is where that short text ("Alerts (0)", "Notices (0)") would be.
The issue is caused by an unfortunate DOM design in the Echo extension, Vector has nothing to do with it.

The fix:
https://github.com/DemianX0/mediawiki-extensions-Echo/commit/888753f5442169a557a60e5b2ca959cc556144b5
https://github.com/DemianX0/mediawiki/commit/7f983f61f2ec26e2e99133a6b77c17aa8729896e

Fixing this also allows to use the standard browser focus outline on these buttons (also follows the shape of the text), removing the need for the hacky emulation of focus with the border, which results in the lighter focus outline compared to surrounding links.

It's also more easily fixed by overriding the #p-personal { text-align: right; … } rule back to left for the li elements.

It's also more easily fixed by overriding the #p-personal { text-align: right; … } rule back to left for the li elements.

Yes, that's right. I didn't think this line would be forgotten:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/585629/52/resources/skins.vector.styles/layout.less#95

In that case the immediate issue is not in Echo.

@Demian - I re-checked frwiki (also checking T264339) - the issue reported in this phab task is not present there. Has it been fixed with the fix in T264339? However, the issue is still present in betalabs.

Compare - in frwiki the cursor tip shows "Your homepage" when hovering over the username link, but in betalabs the cursor tip still displays "Your notices"

frwiki wmf.10betalabs
Screen Shot 2020-10-08 at 2.59.45 PM.png (104×880 px, 48 KB)
Screen Shot 2020-10-08 at 3.01.40 PM.png (103×1 px, 60 KB)