Error: Undefined constant 'ast\AST_LIST'
Fixed with T251346 needs to be released (one release of phan-taint-check-plugin and a new release of mediawiki/mediawiki-phan-config using the release of phan-taint-check-plugin)
to unstuck the libup updates form some extensions.
At the moment some extensions like LangConv does not get npm audit or other new package due to this error.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Bump mediawiki/mediawiki-phan-config to 0.10.3 | labs/libraryupgrader/config | master | +1 -1 |
I think taint-check master has some bugs with pass-by-refs, but it shouldn't block the release. I should also note that LibUp cannot upgrade mediawiki-phan-config, see T254571 (which also proposes a different approach, which should be implemented before tagging if we want to).
It should be possible to tag/branch a new release without the ConfigBuilder and only the version bump
Only needs https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/+/602499 on top of 0.10.2?
Change 629141 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[labs/libraryupgrader/config@master] Bump mediawiki/mediawiki-phan-config to 0.10.3
Change 629141 merged by jenkins-bot:
[labs/libraryupgrader/config@master] Bump mediawiki/mediawiki-phan-config to 0.10.3
This would update all extensions also to 0.10.3 which is not needed for the CI (from my point of view)
Should we list 0.10.2 and 0.10.3 as good release in releases.json to avoid the update from 0.10.2 to 0.10.3?
I was not aware of this task. Daimona and I had a quick talk about it and we went with a stable-0.10 branch with the two ConfigBuilder rolled back.
For MediaWiki core, extensions and skins we run Phan with php-ast and are thus not affected by the issue. So yeah 0.10.2 is fine for MediaWiki core, vendor, extensions and skins.
Anything running phan without php-ast (--allow-polyfill-parser) such as Parsoid, should be at 0.10.3.
We also now have some generic jobs intended for PHP libraries and that do have php-ast: