Page MenuHomePhabricator
Create Task
Maniphest T263745

Language name for Norwegian Bokmål Wikipedia incorrectly listed as "norsk"
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
jhsoby
Sep 24 2020, 12:44 PM
Tags
Referenced Files
F32411256: Screen Shot 2020-10-22 at 12.36.05 PM.png
Oct 22 2020, 7:36 PM
F32371676: Screen Shot 2020-10-02 at 2.42.59 PM.png
Oct 2 2020, 9:44 PM
F32371654: desktop.png
Oct 2 2020, 9:17 PM
F32371655: mobile.png
Oct 2 2020, 9:17 PM
F32371632: Screen Shot 2020-10-02 at 1.44.24 PM.png
Oct 2 2020, 8:48 PM
Subscribers
Aklapper
Danmichaelo
Jdlrobson
jeblad
jhsoby
Nikerabbit

Description

Per T263294#6487346. In the mobile web version of Wikipedia (*.m.wikipedia.org), the language name for the Norwegian Bokmål Wikipdia is listed as "norsk" when it should be "norsk bokmål". This was fixed for desktop back in November with the addition of the $wgInterlanguageLinkCodeMap in InitialiseSettings.php, but apparently mobile web doesn't recognize this setting. Ideally it would, so this doesn't have to be fixed in multiple places.

In summary, no should display the name for nb, but only for Wikipedia, not other Wikimedia projects.

Details

SubjectRepoBranchLines +/-
Apply InterlanguageLinkCodeMap in Action APImediawiki/coremaster+10 -3
Customize query in gerrit

Related Objects

Event Timeline

jhsoby created this task.Sep 24 2020, 12:44 PM
Restricted Application added subscribers: jeblad, Danmichaelo, Aklapper. · View Herald TranscriptSep 24 2020, 12:44 PM
Aklapper added a project: MobileFrontend.Sep 24 2020, 2:07 PM
Jdlrobson added a project: Language-Team.Oct 2 2020, 8:48 PM
Jdlrobson subscribed.

Hello! Could you please expand on this bug request as I'm not quite sure what it's referring to. Are you referring to the language results shown in this screenshot?:

If so the label comes from the API request so it's possible the issue actually lays inside the core API so adding the language team.

https://no.m.wikipedia.org/w/api.php?action=query&format=json&formatversion=2&meta=siteinfo&siprop=general&prop=langlinks&lllimit=max&titles=Oluf_M%C3%BCller&llprop=url%7Cautonym%7Clangname&llinlanguagecode=en

Screen Shot 2020-10-02 at 1.44.24 PM.png (946×2 px, 88 KB)

Thanks in advance for your help clarifying.

Jdlrobson assigned this task to ovasileva.Oct 2 2020, 8:48 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Danmichaelo added a comment.EditedOct 2 2020, 9:17 PM

Indeed. The language name is correct in the desktop version:

desktop.png (172×175 px, 9 KB)

But wrong in the mobile version:

mobile.png (203×293 px, 10 KB)

Jdlrobson added a comment.Oct 2 2020, 9:44 PM

Strangely I'm not seeing an entry for Norsk on
https://no.m.wikipedia.org/wiki/Oluf_M%C3%BCller#/languages

Screen Shot 2020-10-02 at 2.42.59 PM.png (888×2 px, 86 KB)

How can I get the Norsk item to show up on mobile?

jhsoby added a comment.Oct 2 2020, 9:46 PM

By not being on the Norwegian Wikipedia. ;)

Try https://en.m.wikipedia.org/wiki/Oluf_Christian_M%C3%BCller#/languages

Jdlrobson edited projects, added Platform Engineering; removed MobileFrontend.Oct 2 2020, 10:22 PM

Thanks for your patience with me!

The API response in the below URL needs to be updated to consider $wgInterlanguageLinkCodeMap
https://en.m.wikipedia.org/w/api.php?action=query&format=json&formatversion=2&meta=siteinfo&siprop=general&prop=langlinks&lllimit=max&titles=Oluf_Christian_M%C3%BCller&llprop=url|autonym|langname&llinlanguagecode=en&lang=en

I'm not sure who maintains this API, but no doubt we will need help from language team and/or platform engineer to fix the API here as Minerva is just rendering the data returned by the API.

Jdlrobson added a project: MinervaNeue (Tracking).Oct 2 2020, 10:22 PM
Nikerabbit added a project: User-Nikerabbit.Oct 3 2020, 8:32 AM
Nikerabbit subscribed.

This shouldn't be too difficult to fix, assuming there are no unexpected consequences of changing it there. I'll bring this up in our sprint planning.

Jdlrobson added a comment.Oct 5 2020, 4:31 PM

Thanks @Nikerabbit. I am happy to help review and test.

Pginer-WMF edited projects, added Language-Team (Language-2020-October-December); removed Language-Team.Oct 6 2020, 9:10 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2020-October-December) board.
Nikerabbit removed a project: User-Nikerabbit.Oct 6 2020, 12:45 PM
BPirkle moved this task from Inbox to Tracking/Watching on the Platform Engineering board.Oct 6 2020, 5:25 PM
Pginer-WMF triaged this task as Medium priority.Oct 7 2020, 1:14 PM
gerritbot added a comment.Oct 8 2020, 1:31 PM

Change 632916 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/core@master] Apply InterlanguageLinkCodeMap in Action API

https://gerrit.wikimedia.org/r/632916

gerritbot added a project: Patch-For-Review.Oct 8 2020, 1:31 PM
Nikerabbit moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-October-December) board.Oct 8 2020, 1:35 PM

There is a risk of breakage if someone uses the lang property in unexpected ways, link constructing the target url manually or indexing the results directly. I am not sure if it should be kept back and perhaps a new property be added.

gerritbot added a comment.Oct 13 2020, 9:48 PM

Change 632916 merged by jenkins-bot:
[mediawiki/core@master] Apply InterlanguageLinkCodeMap in Action API

https://gerrit.wikimedia.org/r/632916

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 13 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 13 2020, 10:10 PM
ovasileva edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Oct 14 2020, 8:42 AM
Jdlrobson closed this task as Resolved.Oct 22 2020, 7:36 PM

Screen Shot 2020-10-22 at 12.36.05 PM.png (918×2 px, 97 KB)

This is fixed! yay!

Arrbee moved this task from In Review to Done on the Language-Team (Language-2020-October-December) board.Nov 3 2020, 8:18 AM
Patafisik mentioned this in T328435: Entry point to suggest missing languages gets confused by "no" code.Feb 25 2023, 1:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL