Regression: New Vector adds all sidebar when exporting to PDF
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Theklan
	Oct 11 2020, 6:35 PM

Description

When exporting to PDF (i.e. [[:eu:Juan Sebastian Elkano]]) the sidebar is added as the first page of the file. This happens even if you are using the legacy vector mode.

Steps to reproduce confirmed problems:

Go to: https://en.wikipedia.org/wiki/Berlin with legacy vector off
Use browser print option

Expected: The sidebar menu does not appear in the print

Observed: The sidebar menu appears in print

Using a wiki where modern Vector is the default e.g. Basque Wikipedia
Use "download as pdf" in the sidebar

Expected: The sidebar menu does not appear in the print

Observed: The sidebar menu appears in print

Note: what user preference you have enabled should have no impact on the download as pdf link in this case.

Notes

This does not occur if the Download as PDF option is used in a site that has legacy mode as the default regardless of any user preference e.g. the sidebar will show on fr.wikipedia.org but not en.wikipedia.org

Note the comment in T265217#6576790 relates to T266559 a different problem to this one.

Developer notes

We need to update the print stylesheet for modern Vector.

I would recommend to fix that we add #mw-panel to the rules in https://github.com/wikimedia/mediawiki/blob/e49dd2476799cc042c74969bf427213f0606b958/resources/src/mediawiki.skinning/commonPrint.css#L31

QA Instructions

Download the dog pdf at https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:DownloadAsPdf&page=Dog&action=show-download-screen and ensure no sidebar shows in PDF
Click the "Printable Version" link in the sidebar of https://en.wikipedia.beta.wmflabs.org/wiki/Dog?useskinversion=2 . Ensure that no sidebar appears in the print preview.

QA Results - Beta

AC	Status	Details
1	✅	T265217#6783749
2	✅	T265217#6783749

QA Results - Prod

AC	Status	Details
1	✅	T265217#6841028
2	✅	T265217#6841028

Details

	Subject	Repo	Branch	Lines +/-
	Move #mw-panel into #mw-navigation	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T266559: PDF download generates invalid PDF files
T266244: Sidebar present in ElectronPdf print output

Event Timeline

Theklan created this task.Oct 11 2020, 6:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2020, 6:35 PM

Thanks! Indeed, random example URL: https://fr.wikipedia.org/api/rest_v1/page/pdf/Berlin . Also brought up in https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Questions_techniques#Probl%C3%A8me_de_contenu_lors_de_l'enregistrement_au_format_PDF but people didn't create a ticket.

I assume this needs fixes in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/Vector/+/refs/heads/master/resources/skins.vector.styles/layout-print.less or maybe https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/Vector/+/refs/heads/master/resources/skins.vector.styles/common/print.less

Aklapper added a project: CSS.Oct 16 2020, 2:23 PM

Copying tags and priority from duplicate T266244

Aklapper added a project: Electron-PDFs.Oct 24 2020, 9:20 PM

Problem with not only new vector. For example, enwiki, ruwiki.
But in some articles, everything is fine: enwiki.

ovasileva renamed this task from New Vector adds all sidebar when exporting to PDF to Regression: New Vector adds all sidebar when exporting to PDF.Oct 26 2020, 11:00 AM

ovasileva raised the priority of this task from Medium to High.

ovasileva updated the task description. (Show Details)Oct 26 2020, 11:10 AM

ovasileva updated the task description. (Show Details)

ovasileva updated the task description. (Show Details)Oct 26 2020, 11:12 AM

ovasileva updated the task description. (Show Details)

This does not occur if the Download as PDF option is used in modern mode

Indeed, it occurs in the modern mode. Test it at Basque Wikipedia.

I can only replicate in new Vector. For wikis that are running new vector as default (e.g. eu and fr) please note that user preference has no impact on the Download as pdf feature. If you have opted out of new Vector you are still printing via old Vector when using ElectronPdf.

It looks like what happened here is during the DOM changes the sidebar is no longer underneath #mw-navigation so the rule in core hiding it no longer applies

To fix this issue, we need to add a rule to resources/skins.vector.styles/common/print.less to hide #mw-panel

In T265217#6576790, @Iluvatar wrote:

Problem with not only new vector. For example, enwiki, ruwiki.
But in some articles, everything is fine: enwiki.

Can you expand on the issue you are seeing here @Iluvatar ? I can't see a sidebar in the PDF output of those links and that makes sense to me as both English and Russian are still using uses the default (old) Vector skin for anonymous users. Implementation-wize, DownloadAsPdf creates a session with an anonymous user and runs CTRL+P. Could you share some of the PDFs you have generated via DownloadAsPdf ?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 26 2020, 5:33 PM

Jdlrobson updated the task description. (Show Details)

Od1n unsubscribed.Oct 27 2020, 7:15 AM

In T265217#6579234, @Jdlrobson wrote:

Can you expand on the issue you are seeing here @Iluvatar ? I can't see a sidebar in the PDF output of those links and that makes sense to me as both English and Russian are still using uses the default (old) Vector skin for anonymous users. Implementation-wize, DownloadAsPdf creates a session with an anonymous user and runs CTRL+P. Could you share some of the PDFs you have generated via DownloadAsPdf ?

Several unregistered readers reported via social networks that export as PDF not working: files are broken (files cannot be opened). It doesn't work for me too (even via pdf repair tools), see links above and files.

Or is it another problem?

In T265217#6580962, @Iluvatar wrote:

In T265217#6579234, @Jdlrobson wrote:

Can you expand on the issue you are seeing here @Iluvatar ? I can't see a sidebar in the PDF output of those links and that makes sense to me as both English and Russian are still using uses the default (old) Vector skin for anonymous users. Implementation-wize, DownloadAsPdf creates a session with an anonymous user and runs CTRL+P. Could you share some of the PDFs you have generated via DownloadAsPdf ?

Several unregistered readers reported via social networks that export as PDF not working: files are broken (files cannot be opened). It doesn't work for me too (even via pdf repair tools), see links above and files.

Okay thanks for clarifying - this looks like a different problem - T266559 - as these PDFs seem to be corrupted files.

ovasileva set the point value for this task to 3.Oct 28 2020, 5:26 PM

Jdlrobson updated the task description. (Show Details)Oct 28 2020, 5:27 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 28 2020, 5:27 PM

This does not occur if the Download as PDF option is used in modern mode

I am seeing it in ~~both~~ modern mode

Jdlrobson updated the task description. (Show Details)Nov 24 2020, 4:34 PM

• nray claimed this task.Jan 21 2021, 5:00 PM

• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 658736 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/Vector@master] Move #mw-panel into #mw-navigation

https://gerrit.wikimedia.org/r/658736

gerritbot added a project: Patch-For-Review.Jan 27 2021, 2:30 AM

• nray removed • nray as the assignee of this task.Jan 27 2021, 6:04 PM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

• nray subscribed.

Jdlrobson assigned this task to Edtadros.Jan 27 2021, 8:05 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 658736 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Move #mw-panel into #mw-navigation

https://gerrit.wikimedia.org/r/658736

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 27 2021, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2021, 10:10 PM

• nray updated the task description. (Show Details)Jan 27 2021, 10:26 PM

• nray updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Download the dog pdf at https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:DownloadAsPdf&page=Dog&action=show-download-screen and ensure no sidebar shows in PDF

Screen Shot 2021-01-28 at 5.55.45 AM.png (1×794 px, 375 KB)

✅ AC2: Click the "Printable Version" link in the sidebar of https://en.wikipedia.beta.wmflabs.org/wiki/Dog?useskinversion=2 . Ensure that no sidebar appears in the print preview.

Screen Shot 2021-01-28 at 5.55.16 AM.png (940×1 px, 144 KB)

Edtadros updated the task description. (Show Details)Jan 28 2021, 1:58 PM

Edtadros updated the task description. (Show Details)Feb 8 2021, 2:35 PM

Edtadros updated the task description. (Show Details)Feb 8 2021, 2:37 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Download the dog pdf at https://en.wikipedia.org/w/index.php?title=Special:DownloadAsPdf&page=Dog&action=show-download-screen and ensure no sidebar shows in PDF

Screen Shot 2021-02-18 at 6.39.39 AM.png (1×1 px, 564 KB)

✅ AC2: Click the "Printable Version" link in the sidebar of https://en.wikipedia.org/wiki/Dog?useskinversion=2 . Ensure that no sidebar appears in the print preview.

Screen Shot 2021-02-18 at 6.40.59 AM.png (1×1 px, 565 KB)

Edtadros updated the task description. (Show Details)Feb 18 2021, 2:43 PM

All done!

	F34112406: Screen Shot 2021-02-18 at 6.40.59 AM.png
	Feb 18 2021, 2:42 PM

	F34112402: Screen Shot 2021-02-18 at 6.39.39 AM.png
	Feb 18 2021, 2:42 PM

	F34053661: Screen Shot 2021-01-28 at 5.55.45 AM.png
	Jan 28 2021, 1:56 PM

	F34053659: Screen Shot 2021-01-28 at 5.55.16 AM.png
	Jan 28 2021, 1:56 PM

Regression: New Vector adds all sidebar when exporting to PDFClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Description

Steps to reproduce confirmed problems:

Notes

Developer notes

QA Instructions

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Regression: New Vector adds all sidebar when exporting to PDF
Closed, ResolvedPublic3 Estimated Story Points
Actions