Page MenuHomePhabricator
Create Task
Maniphest T265262

[BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected
Closed, ResolvedPublicBUG REPORT
Actions

Description

This was first noticed during testing of T258005

Steps to Reproduce:
Open the newcomer homepage on Desktop and activate the Suggested edits task module.

Actual Results:
Dot is not centered (on any variant)

Variant A
Screen Shot 2020-10-08 at 10.19.24 AM.png (876×1 px, 291 KB)
Variant C/D
Screen Shot 2020-10-08 at 11.05.08 AM.png (779×642 px, 118 KB)

Expected Results:
Blue dot should be on the centre of the topics filter button

Details

SubjectRepoBranchLines +/-
SuggestedEdits: Center blue dot on desktopmediawiki/extensions/GrowthExperimentsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

RHo created this task.Oct 12 2020, 9:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2020, 9:30 AM
RHo renamed this task from [BUG][Regression] Newcomer tasks to [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected.Oct 12 2020, 9:33 AM
RHo added a project: Growth-Team (Sprint 0 (Growth Team)).
RHo updated the task description. (Show Details)
RHo added a subscriber: Growth-Team.
RHo mentioned this in T258005: Variant C/D: homepage layout changes.Oct 12 2020, 9:37 AM
kostajh subscribed.Oct 13 2020, 10:41 AM

This was implemented with right: 10% per T238611#5789718 and T238611#5790124, but I will make a patch to center it on desktop.

gerritbot added a comment.Oct 13 2020, 10:43 AM

Change 633708 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Center blue dot on desktop

https://gerrit.wikimedia.org/r/633708

gerritbot added a project: Patch-For-Review.Oct 13 2020, 10:43 AM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 13 2020, 10:43 AM
RHo added a comment.Oct 13 2020, 1:52 PM
In T265262#6538357, @kostajh wrote:

This was implemented with right: 10% per T238611#5789718 and T238611#5790124, but I will make a patch to center it on desktop.

Ah yes, I think I missed commenting on this, that in fact both on Desktop and Mobile it should centered. Thanks for the fix, this LGTM:

image.png (558×1 px, 43 KB)

gerritbot added a comment.Oct 13 2020, 2:01 PM

Change 633708 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Center blue dot on desktop

https://gerrit.wikimedia.org/r/633708

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2020, 2:10 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 13 2020, 5:50 PM
Etonkovidova closed this task as Resolved.Oct 14 2020, 4:15 PM
Etonkovidova claimed this task.
Etonkovidova subscribed.

Done .
Checked

  • A/C/D variants
  • mobile

Screen Shot 2020-10-14 at 9.13.11 AM.png (568×736 px, 52 KB)

Aklapper removed a subscriber: Growth-Team.May 16 2023, 10:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits