Page MenuHomePhabricator
Create Task
Maniphest T268012

Call to a member function getDifficulty() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.16

message
Call to a member function getDifficulty() on null

Impact

Server-side rendering of the suggested edits module fails, and the entire module does not display.

Notes

Seems to only be seen on kowiki. It's because we're trying to access the default "links" task type which doesn't exist on kowiki. The error was first seen on November 9.

Details

Request ID
c5b17458-bc92-46ad-859d-a93395027df0
Request URL
https://ko.wikipedia.org/w/index.php?title=%ED%8A%B9%EC%88%98:%ED%99%88%ED%8E%98%EC%9D%B4%EC%A7%80&source=specialwelcomesurvey
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php(371): GrowthExperiments\HomepageModules\SuggestedEdits->getFiltersButtonGroupWidget()
#1 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(143): GrowthExperiments\HomepageModules\SuggestedEdits->getBody()
#2 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(125): GrowthExperiments\HomepageModules\BaseModule->renderDesktop()
#3 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php(245): GrowthExperiments\HomepageModules\BaseModule->getHtml()
#4 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(85): GrowthExperiments\HomepageModules\SuggestedEdits->getHtml()
#5 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(313): GrowthExperiments\HomepageModules\BaseModule->render(string)
#6 /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(158): GrowthExperiments\Specials\SpecialHomepage->renderDesktop()
#7 /srv/mediawiki/php-1.36.0-wmf.16/includes/specialpage/SpecialPage.php(607): GrowthExperiments\Specials\SpecialHomepage->execute(NULL)
#8 /srv/mediawiki/php-1.36.0-wmf.16/includes/specialpage/SpecialPageFactory.php(1168): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.36.0-wmf.16/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.36.0-wmf.16/includes/MediaWiki.php(943): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.36.0-wmf.16/includes/MediaWiki.php(546): MediaWiki->main()
#12 /srv/mediawiki/php-1.36.0-wmf.16/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.36.0-wmf.16/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
SubjectRepoBranchLines +/-
Structure test for Job constructorsmediawiki/coremaster+75 -0
Suggested Edits: Guard against task type not existingmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.18+5 -2
Suggested Edits: Guard against task type not existingmediawiki/extensions/GrowthExperimentsmaster+5 -2
Suggested Edits: Guard against task type not existingmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.16+5 -2
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Nov 17 2020, 12:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2020, 12:24 PM
kostajh added projects: Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-NewcomerTasks.Nov 17 2020, 12:24 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh removed subscribers: NewcomerTasks Future Release , Growth-Team (Sprint 0 (Growth Team)), Growth-Team.
kostajh updated the task description. (Show Details)Nov 17 2020, 12:26 PM
Restricted Application added a subscriber: revi. · View Herald TranscriptNov 17 2020, 12:26 PM
kostajh added a comment.Nov 17 2020, 12:31 PM

See also https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-deploy-2020.11.17/mediawiki?id=AXXWFdbgBpCrxDVRWhDN&_g=h@8b5b71a

gerritbot added a comment.Nov 17 2020, 12:32 PM

Change 641419 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Guard against task type not existing

https://gerrit.wikimedia.org/r/641419

gerritbot added a project: Patch-For-Review.Nov 17 2020, 12:32 PM
gerritbot added a comment.Nov 17 2020, 12:36 PM

Change 641293 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.16] Suggested Edits: Guard against task type not existing

https://gerrit.wikimedia.org/r/641293

kostajh claimed this task.Nov 17 2020, 12:39 PM
kostajh moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh updated the task description. (Show Details)
gerritbot added a comment.Nov 17 2020, 12:45 PM

Change 641419 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Guard against task type not existing

https://gerrit.wikimedia.org/r/641419

gerritbot added a comment.Nov 17 2020, 12:50 PM

Change 641293 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.16] Suggested Edits: Guard against task type not existing

https://gerrit.wikimedia.org/r/641293

Stashbot added a comment.Nov 17 2020, 12:55 PM

Mentioned in SAL (#wikimedia-operations) [2020-11-17T12:55:16Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php: Backport: [[gerrit:641293|Suggested Edits: Guard against task type not existing (T268012)]] (duration: 00m 58s)

gerritbot added a comment.Nov 17 2020, 12:56 PM

Change 641294 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.18] Suggested Edits: Guard against task type not existing

https://gerrit.wikimedia.org/r/641294

Lucas_Werkmeister_WMDE mentioned this in T263184: 1.36.0-wmf.18 deployment blockers.Nov 17 2020, 12:58 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 17 2020, 1:00 PM
gerritbot added a comment.Nov 17 2020, 8:49 PM

Change 641294 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.18] Suggested Edits: Guard against task type not existing

https://gerrit.wikimedia.org/r/641294

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 17 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 17 2020, 9:10 PM
Stashbot added a comment.Nov 18 2020, 12:53 AM

Mentioned in SAL (#wikimedia-operations) [2020-11-18T00:53:02Z] <tgr_> also deployed [[gerrit:641294|Suggested Edits: Guard against task type not existing (T268012)]]

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 18 2020, 1:11 AM
Etonkovidova closed this task as Resolved.Nov 18 2020, 1:51 AM
Etonkovidova subscribed.

Checked in kowiki betalabs and kowiki .

gerritbot added a comment.Nov 18 2020, 4:02 AM

Change 641590 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Structure test for Job constructors

https://gerrit.wikimedia.org/r/641590

gerritbot added a project: Patch-For-Review.Nov 18 2020, 4:02 AM
Krinkle moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.Jul 29 2022, 11:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits