Change 624909 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Simplify menu code

https://gerrit.wikimedia.org/r/624909

This is going to be helpful for language work.

In T268157#6692044, @phuedx wrote:

The change will require various template changes given the data will be sourced from places with different names to those used by Vector so there is a small amount of risk, that can easily be mitigated by verifying the HTML before and after the change.

Will this be done manually? Should it be done prior to merging or when the task gets moved to Needs QA?

I was thinking as part of code review it would be helpful to confirm this is a NOOP in terms of generated HTML.

It's important for us to test on a page with languages and variants.

$wgLanguageCode = 'zh'; '// enable variants
$wgHooks['SkinAfterPortlet'][] = function ( $skin, $name, &$html ) {
        if ( $name === 'tb' ) {
                $html .= '<a>BaseTemplateAfterPortlet LocalSettings link</a>';
        }
};

Test wiki created on Patch Demo by Phuedx (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/9eaff8eff77c4d5d41d161665b5dc457/w/

In T268157#6692828, @Jdlrobson wrote:

In T268157#6692044, @phuedx wrote:

I was thinking as part of code review it would be helpful to confirm this is a NOOP in terms of generated HTML.

It's important for us to test on a page with languages and variants.

You patch has been merged and will soon be live on the Beta Cluster, which has wikis with language variants available IIRC. I'd be happy to work with @Edtadros on this as I think that we can use the tool I wrote to test your patch during code review.

Change 624909 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Simplify menu code

https://gerrit.wikimedia.org/r/624909

@Jdlrobson can you provide test steps please.

It was quite difficult to diff sets of elements between the Beta Cluster and the production wiki (the former being ahead of the latter at the time of writing). That being said, I diffed elements between de.wikipedia.org and the de.wikipedia.beta.wmflabs.org and I didn't see any classes out of place.