Page MenuHomePhabricator
Create Task
Maniphest T269719

Include version of WikiPEG that supports PHP 8.0 into Parsoid in REL1_35
Closed, ResolvedPublic
Actions

Description

https://github.com/wikimedia/mediawiki-vendor/blob/REL1_35/composer.lock#L2386

wikipeg 2.0.4 has "php": "^7.2".

wikipeg 2.0.5 has "php": ">=7.2".

Details

SubjectRepoBranchLines +/-
Update Parsoid to 0.12.2mediawiki/vendorREL1_35+66 -125
Delint two issues flagged by phan when run in PHP 8.0mediawiki/services/parsoidREL1_35+2 -2
Remove PHPUtils::coalescemediawiki/services/parsoidREL1_35+13 -61
Bump wikimedia/parsoid to 0.13.0-a21mediawiki/vendormaster+1 K -357
Zuul: [mediawiki/services/parsoid] Enable PHP 8.0 composer jobintegration/configmaster+6 -0
PHP 8.0 compatibilitymediawiki/services/parsoidmaster+14 -11
Remove PHPUtils::coalescemediawiki/services/parsoidmaster+13 -61
Delint two issues flagged by phan when run in PHP 8.0mediawiki/services/parsoidmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Dec 8 2020, 11:02 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.0 support board.Dec 9 2020, 12:07 AM
Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.Dec 16 2020, 12:52 AM
Jdforrester-WMF closed subtask T269720: Add PHP 8.0 support to WikiPEG as Resolved.Dec 17 2020, 9:40 PM
gerritbot added a comment.Dec 17 2020, 9:40 PM

Change 650265 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/services/parsoid@master] [WIP] PHP 8.0 compatibility

https://gerrit.wikimedia.org/r/650265

gerritbot added a project: Patch-For-Review.Dec 17 2020, 9:40 PM
gerritbot added a comment.Dec 19 2020, 6:04 PM

Change 650795 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Delint two issues flagged by phan when run in PHP 8.0

https://gerrit.wikimedia.org/r/650795

gerritbot added a comment.Dec 19 2020, 6:15 PM

Change 650799 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Remove PHPUtils::coalesce

https://gerrit.wikimedia.org/r/650799

gerritbot added a comment.Dec 19 2020, 6:23 PM

Change 650795 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Delint two issues flagged by phan when run in PHP 8.0

https://gerrit.wikimedia.org/r/650795

gerritbot added a comment.Dec 19 2020, 6:51 PM

Change 650799 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove PHPUtils::coalesce

https://gerrit.wikimedia.org/r/650799

gerritbot added a comment.Dec 20 2020, 2:35 PM

Change 650265 merged by jenkins-bot:
[mediawiki/services/parsoid@master] PHP 8.0 compatibility

https://gerrit.wikimedia.org/r/650265

gerritbot added a comment.Dec 22 2020, 6:12 PM

Change 651570 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a21

https://gerrit.wikimedia.org/r/651570

gerritbot added a comment.Dec 22 2020, 10:01 PM

Change 651570 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a21

https://gerrit.wikimedia.org/r/651570

Reedy moved this task from Wikimedia production to MediaWiki core on the PHP 8.0 support board.Dec 27 2020, 4:34 PM
alex-mashin subscribed.Dec 30 2020, 5:46 AM
gerritbot added a comment.Jan 3 2021, 11:13 PM

Change 653965 had a related patch set uploaded (by Reedy; owner: C. Scott Ananian):
[mediawiki/services/parsoid@REL1_35] Delint two issues flagged by phan when run in PHP 8.0

https://gerrit.wikimedia.org/r/653965

gerritbot added a comment.Jan 3 2021, 11:15 PM

Change 653986 had a related patch set uploaded (by Reedy; owner: C. Scott Ananian):
[mediawiki/services/parsoid@REL1_35] Remove PHPUtils::coalesce

https://gerrit.wikimedia.org/r/653986

Reedy added a comment.Jan 3 2021, 11:15 PM

rMWVDcae3cad1e182: Updating wikimedia/wikipeg (2.0.4 => 2.0.5) changed the php requirement ^7.2 for >=7.2 in MW 1.35....

Reedy added a comment.Jan 4 2021, 12:35 AM

I've backported two out of the 3 other changes tagged to this bug...

Question if https://gerrit.wikimedia.org/r/650265 needs backporting too ontop...

Jdforrester-WMF subscribed.Jan 4 2021, 12:36 AM

Probably. But we've not checked that PHP 8.0 passes tests on Parsoid master yet, let alone actually tested it.

Reedy updated the task description. (Show Details)Jan 4 2021, 12:36 AM
Reedy updated the task description. (Show Details)
Jdforrester-WMF added a comment.Jan 4 2021, 12:55 AM

Oh, right, yeah, we can't test Parsoid on PHP 8.0 until MW core is composer-installable on PHP 8.0, which means pulling the trigger on the monolog 2.1 upgrade. Let's wait until after the cut on Tuesday, at least?

gerritbot added a comment.Jan 4 2021, 1:03 AM

Change 654024 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] Zuul: [mediawiki/services/parsoid] Enable PHP 8.0 composer job

https://gerrit.wikimedia.org/r/654024

gerritbot added a comment.Jan 4 2021, 10:47 PM

Change 654024 merged by jenkins-bot:
[integration/config@master] Zuul: [mediawiki/services/parsoid] Enable PHP 8.0 composer job

https://gerrit.wikimedia.org/r/654024

Stashbot added a comment.Jan 4 2021, 10:48 PM

Mentioned in SAL (#wikimedia-releng) [2021-01-04T22:48:27Z] <James_F> Zuul: [mediawiki/services/parsoid] Enable PHP 8.0 composer job T269719

gerritbot added a comment.Jan 26 2021, 6:20 PM

Change 653965 merged by jenkins-bot:
[mediawiki/services/parsoid@REL1_35] Delint two issues flagged by phan when run in PHP 8.0

https://gerrit.wikimedia.org/r/653965

gerritbot added a comment.Jan 26 2021, 6:20 PM

Change 653986 merged by jenkins-bot:
[mediawiki/services/parsoid@REL1_35] Remove PHPUtils::coalesce

https://gerrit.wikimedia.org/r/653986

Reedy removed a project: Patch-For-Review.Mar 21 2021, 3:55 AM
gerritbot added a comment.Apr 8 2021, 5:48 PM

Change 677986 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_35] Update Parsoid to 0.12.2

https://gerrit.wikimedia.org/r/677986

gerritbot added a project: Patch-For-Review.Apr 8 2021, 5:48 PM
gerritbot added a comment.Apr 8 2021, 6:10 PM

Change 677986 merged by C. Scott Ananian:

[mediawiki/vendor@REL1_35] Update Parsoid to 0.12.2

https://gerrit.wikimedia.org/r/677986

Reedy removed a project: Patch-For-Review.May 19 2021, 10:32 PM
Reedy closed this task as Resolved.May 19 2021, 10:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits