MW 1.35 Library Bumps for PHP 8.0
Closed, ResolvedPublic
Actions

Description

For T266583: MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy, we'll no doubt need to bump various libraries, both Upstream and Wikimedia maintained to include PHP 8.0 support

At a quick glance, current constraints that explicty mean they won't work (or even install!) on PHP 8.0

~~semver "php": "^5.3.2 || ^7.0"~~
~~wikipeg "php": "^7.2"~~
~~hotp-php "php": "^5.3.3 || ^7.0"~~

Plus the core-only (dev-only) one:

~~dbal "php": "^7.2"~~

And then obviously the dependancy tree of stuff that depends on it...

Details

Subject	Repo	Branch	Lines +/-
build: Upgrade mediawiki/mediawiki-phan-config to 0.10.6	mediawiki/core	REL1_35	+39 -71
Updating jakobo/hotp-php (1.0.1 => 2.0.0)	mediawiki/extensions/OATHAuth	REL1_35	+1 -1
Updating jakobo/hotp-php (1.0.1 => 2.0.0)	mediawiki/vendor	REL1_35	+69 -216
Updating jakobo/hotp-php (1.0.1 => 2.0.0)	mediawiki/extensions/OATHAuth	master	+1 -1
Updating jakobo/hotp-php (1.0.1 => 2.0.0)	mediawiki/vendor	master	+69 -216
Updating composer/semver (1.5.2 => 1.7.2)	mediawiki/core	REL1_35	+2 -2
Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)	mediawiki/core	REL1_35	+3 -3
Updating composer/semver (1.5.2 => 1.7.2)	mediawiki/vendor	REL1_35	+98 -44

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T266583 MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy
Resolved	Jdforrester-WMF	T269710 MW 1.35 Library Bumps for PHP 8.0
Resolved	None	T269719 Include version of WikiPEG that supports PHP 8.0 into Parsoid in REL1_35
Resolved	Legoktm	T269720 Add PHP 8.0 support to WikiPEG

Event Timeline

Reedy created this task.Dec 8 2020, 9:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2020, 9:35 PM

Reedy added a parent task: T266583: MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy.Dec 8 2020, 9:36 PM

Reedy mentioned this in T269711: Document current PHP 8.0 support in MW 1.35 for 1.35.1.Dec 8 2020, 9:38 PM

Reedy updated the task description. (Show Details)Dec 8 2020, 9:54 PM

Change 647064 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_35] Updating composer/semver (1.5.1 => 1.7.2)

https://gerrit.wikimedia.org/r/647064

Change 647065 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating composer/semver (1.5.1 => 1.7.2)

https://gerrit.wikimedia.org/r/647065

Looks like we might need a MediaWiki-Codesniffer point release... Or just a bump to 34.0.0... Let's try that first

22:01:47   Problem 1
22:01:47     - Installation request for mediawiki/mediawiki-codesniffer 33.0.0 -> satisfiable by mediawiki/mediawiki-codesniffer[v33.0.0].
22:01:47     - mediawiki/mediawiki-codesniffer v33.0.0 requires composer/semver ~1.5.1|~2.0.0 -> satisfiable by composer/semver[1.5.1, 1.5.2, 2.0.0] but these conflict with your requirements or minimum-stability.

Change 647087 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

Reedy updated the task description. (Show Details)Dec 8 2020, 10:19 PM

Change 647087 merged by jenkins-bot:
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

Change 647064 merged by Reedy:
[mediawiki/vendor@REL1_35] Updating composer/semver (1.5.2 => 1.7.2)

https://gerrit.wikimedia.org/r/647064

ReleaseTaggerBot added a project: MW-1.35-notes.Dec 8 2020, 11:00 PM

Change 647065 merged by jenkins-bot:
[mediawiki/core@REL1_35] Updating composer/semver (1.5.2 => 1.7.2)

https://gerrit.wikimedia.org/r/647065

In T269710#6677816, @gerritbot wrote:

Change 647087 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

If I understand correctly, codesniffer 34 doesn't work with php8 - support was fixed earlier today in rMCSN78416209bfe3: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 and will go out in version 35

In T269710#6678087, @DannyS712 wrote:

In T269710#6677816, @gerritbot wrote:

Change 647087 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

If I understand correctly, codesniffer 34 doesn't work with php8 - support was fixed earlier today in rMCSN78416209bfe3: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 and will go out in version 35

Probably. But needed to bump 33 -> 34 to unblock the semver upgrade, as we needed to bump to 1.7.2 for 8.0 support :)

We can definitely bump further later

Reedy updated the task description. (Show Details)Dec 8 2020, 11:57 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Dec 9 2020, 12:07 AM

In T269710#6678087, @DannyS712 wrote:

If I understand correctly, codesniffer 34 doesn't work with php8 - support was fixed earlier today in rMCSN78416209bfe3: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 and will go out in version 35

Er, it should work fine. The tests that run against the codesniffer repo weren't compatible with PHP 8 until you fixed it, but the library itself should already have been.

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2020, 12:10 AM

Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.Dec 16 2020, 12:52 AM

Jdforrester-WMF updated the task description. (Show Details)Dec 23 2020, 12:55 AM

Reedy updated the task description. (Show Details)Dec 28 2020, 1:18 AM

Change 652017 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652017

Change 652018 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OATHAuth@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652018

alex-mashin subscribed.Dec 30 2020, 5:51 AM

Change 652017 merged by jenkins-bot:
[mediawiki/vendor@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652017

Change 652018 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652018

Change 652654 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652654

Change 652592 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OATHAuth@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652592

Change 652654 merged by Reedy:
[mediawiki/vendor@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652654

Change 652592 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652592

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 31 2020, 4:00 AM

Reedy updated the task description. (Show Details)Jan 4 2021, 12:30 AM

Reedy removed a project: Patch-For-Review.

Change 656594 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_35] [WIP] build: Upgrade mediawiki/mediawiki-phan-config to 0.10.6

https://gerrit.wikimedia.org/r/656594

gerritbot added a project: Patch-For-Review.Jan 17 2021, 3:57 AM

Change 656594 merged by jenkins-bot:
[mediawiki/core@REL1_35] build: Upgrade mediawiki/mediawiki-phan-config to 0.10.6

https://gerrit.wikimedia.org/r/656594