Page MenuHomePhabricator

MW 1.35 Library Bumps for PHP 8.0
Closed, ResolvedPublic

Description

For T266583: MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy, we'll no doubt need to bump various libraries, both Upstream and Wikimedia maintained to include PHP 8.0 support


At a quick glance, current constraints that explicty mean they won't work (or even install!) on PHP 8.0

  • semver "php": "^5.3.2 || ^7.0"
  • wikipeg "php": "^7.2"
  • hotp-php "php": "^5.3.3 || ^7.0"

Plus the core-only (dev-only) one:

  • dbal "php": "^7.2"

And then obviously the dependancy tree of stuff that depends on it...

Event Timeline

Change 647064 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_35] Updating composer/semver (1.5.1 => 1.7.2)

https://gerrit.wikimedia.org/r/647064

Change 647065 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating composer/semver (1.5.1 => 1.7.2)

https://gerrit.wikimedia.org/r/647065

Looks like we might need a MediaWiki-Codesniffer point release... Or just a bump to 34.0.0... Let's try that first

22:01:47   Problem 1
22:01:47     - Installation request for mediawiki/mediawiki-codesniffer 33.0.0 -> satisfiable by mediawiki/mediawiki-codesniffer[v33.0.0].
22:01:47     - mediawiki/mediawiki-codesniffer v33.0.0 requires composer/semver ~1.5.1|~2.0.0 -> satisfiable by composer/semver[1.5.1, 1.5.2, 2.0.0] but these conflict with your requirements or minimum-stability.

Change 647087 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

Change 647087 merged by jenkins-bot:
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

Change 647064 merged by Reedy:
[mediawiki/vendor@REL1_35] Updating composer/semver (1.5.2 => 1.7.2)

https://gerrit.wikimedia.org/r/647064

Change 647065 merged by jenkins-bot:
[mediawiki/core@REL1_35] Updating composer/semver (1.5.2 => 1.7.2)

https://gerrit.wikimedia.org/r/647065

Change 647087 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

If I understand correctly, codesniffer 34 doesn't work with php8 - support was fixed earlier today in rMCSN78416209bfe3: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 and will go out in version 35

Change 647087 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Updating mediawiki/mediawiki-codesniffer (33.0.0 => 34.0.0)

https://gerrit.wikimedia.org/r/647087

If I understand correctly, codesniffer 34 doesn't work with php8 - support was fixed earlier today in rMCSN78416209bfe3: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 and will go out in version 35

Probably. But needed to bump 33 -> 34 to unblock the semver upgrade, as we needed to bump to 1.7.2 for 8.0 support :)

We can definitely bump further later

If I understand correctly, codesniffer 34 doesn't work with php8 - support was fixed earlier today in rMCSN78416209bfe3: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 and will go out in version 35

Er, it should work fine. The tests that run against the codesniffer repo weren't compatible with PHP 8 until you fixed it, but the library itself should already have been.

Change 652017 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652017

Change 652018 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OATHAuth@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652018

Change 652017 merged by jenkins-bot:
[mediawiki/vendor@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652017

Change 652018 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652018

Change 652654 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652654

Change 652592 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OATHAuth@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652592

Change 652654 merged by Reedy:
[mediawiki/vendor@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652654

Change 652592 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_35] Updating jakobo/hotp-php (1.0.1 => 2.0.0)

https://gerrit.wikimedia.org/r/652592

Change 656594 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_35] [WIP] build: Upgrade mediawiki/mediawiki-phan-config to 0.10.6

https://gerrit.wikimedia.org/r/656594

Change 656594 merged by jenkins-bot:
[mediawiki/core@REL1_35] build: Upgrade mediawiki/mediawiki-phan-config to 0.10.6

https://gerrit.wikimedia.org/r/656594

Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I believe this is now done.