Page MenuHomePhabricator

Remove the edit summary field from the new discussion tool
Open, Needs TriagePublic

Description

This task is about removing the edit summary field from the new discussion tool. [i]

Background

The New Discussion Tool shares code with the Reply Tool. Doing this made building the New Discussion Tool and makes maintaining it in the long-term more straightforward.

This also means that certain aspects of the two tools are shared, by default. One such "component" is the currently named Comment summary field.

This task involves removing the aforementioned field from the New Discussion Tool considering the edit summaries that accompany new discussions being created on talk pages are [almost?] always generated using the discussion's title. [ii]


i.

//Note the Comment summary field in the screenshot below
Screen Shot 2020-12-18 at 5.45.00 PM.png (928×2 px, 115 KB)

ii. "When starting a new thread on a talk page by using the "New section" tab, the text you type into the "subject/headline" field becomes both the heading of your discussion topic, and the edit summary for that edit. via https://en.wikipedia.org/wiki/Help:Edit_summary#Automatic_summaries

Event Timeline

There is a task (can't find it now) to add this missing functionality to the standard action=edit&section=new to allow specifying a different edit summary, and it should be possible to continue to do so in the tool

There is a task (can't find it now) to add this missing functionality to the standard action=edit&section=new to allow specifying a different edit summary, and it should be possible to continue to do so in the tool

I couldn't find such a task either, but these two hint at that idea, without quite proposing it:

This task is about removing the edit summary field from the new discussion tool.

In my personal opinion, we shouldn't have an edit summary field in either the reply or new discussion tool – but, if we have it in one, then we should also have it in the other. It seems to me that all arguments for and against apply the same to both tools.

I would expect folks to want to copy-paste (or summarize) their comment in the edit summary when posting a new topic, just as they want to do that when posting a reply.

Adding some context @matej_suchanek shared on mediaiwki.org [i]:

What I find most problematic is that you are able to change the stuff between /* ... */, which is obviously meant to be nothing but the new topic title. Though I can see there are some means that try to keep it consistent. (Perhaps this is a point for future consultation.)


i. https://w.wiki/rdY

If you must prevent people from changing the summary, then show it but make it disabled/uneditable. At least that way users can see what they are going to get rather than being surprised. It's hidden under Advanced, so the only people who look there are who know and care; you won't be confusing the uninitiated.

(And for the record I would want to see the full summary shown in other interfaces where it currently isn't, like mobile. I already made another ticket for that somewhere.)

Having said that, synching the summary from the subject in the current prototype is shaping up. (Is there a specific task for that?) I hope it means you won't need to disallow editing of the summary.

Having said that, synching the summary from the subject in the current prototype is shaping up. (Is there a specific task for that?)

We were talking about synching the contents of the New Discussion Tool's subject field with the the summary field in T270539.

Although, as @matmarex noted in T270539#6705052, the syncing between the two fields seems to be working in ways we consider to be expected.

If you observe it to be behaving in ways that you do not consider to be expected, we would value you boldly re-opening T270539 and commenting the unexpected behavior you are noticing.

I hope it means you won't need to disallow editing of the summary.

We do not have have any current plans to remove the ability for people to edit the summary field from within the New Discussion Tool. With this said, if we notice a pattern where Junior Contributors are becoming confused/distracted by it, we will likely revise this position.

Note: the initial requirements [i] indicate, "Junior Contributors should not become distracted by the custom edit summary functionality nor should they feel an obligation to engage with it."


i. T249391