Page MenuHomePhabricator
Create Task
Maniphest T270648

Load style module for no-JS environments in VoterEligibilityPage (OT)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The VoterEligibilityPage uses OutputPage::addModules to add the module ext.securepoll: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/SecurePoll/+/8f16fffa7fc130b5975c7e61324f16700d429978/includes/Pages/VoterEligibilityPage.php#398

The ext.securepoll module loads the file ext.securepoll.css: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/SecurePoll/+/8f16fffa7fc130b5975c7e61324f16700d429978/extension.json#47

OutputPage::addModules only loads a module if JS is enabled, so the CSS isn't being loaded for users without JS.

This results in styling discrepancies such as the field labels not being bold, and margins being too small:

JS enabledJS disabled
image.png (162×382 px, 8 KB)
image.png (134×391 px, 8 KB)

This can be solved by using OutputPage::addModuleStyles.

Details

SubjectRepoBranchLines +/-
Replace addModule() with addModuleStyles()mediawiki/extensions/SecurePollmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Dec 21 2020, 8:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2020, 8:21 PM
Tchanders added a subscriber: STran.Dec 21 2020, 8:22 PM
• Niharika moved this task from Onboarding Tasks to Triage/To be Estimated on the Anti-Harassment board.Jan 5 2021, 7:34 PM
• Niharika renamed this task from Load style module for no-JS environments in VoterEligibilityPage to Load style module for no-JS environments in VoterEligibilityPage (OT).Jan 6 2021, 7:17 AM
• Niharika triaged this task as Medium priority.
ARamirez_WMF set the point value for this task to 2.Jan 6 2021, 5:33 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 13 2021, 5:54 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
ARamirez_WMF moved this task from The Letter Song to Cards ready for development on the Anti-Harassment board.Jan 13 2021, 9:48 PM
ARamirez_WMF edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 20 2021, 6:53 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
• wikitrent claimed this task.Jan 20 2021, 6:54 PM
• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Jan 21 2021, 2:21 PM
gerritbot added a comment.Jan 21 2021, 3:21 PM

Change 657622 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Replace addModule() with addModuleStyles()

https://gerrit.wikimedia.org/r/657622

gerritbot added a project: Patch-For-Review.Jan 21 2021, 3:21 PM
Tchanders added a comment.Jan 21 2021, 3:38 PM

Since this was done following T271150: Convert SecurePoll VoterEligibilityPage to use OOUI, the screenshots from the task description are no longer relevant. Updated screenshots of the bug before this patch:

JS enabledJS disabled
image.png (365×723 px, 13 KB)
image.png (309×722 px, 12 KB)

After the above patch, both should look like the picture on the left.

Tchanders added a comment.Jan 21 2021, 3:45 PM

While reviewing this I noticed that some rules in ext.securepoll.css appear unused, so here's a task for looking into that: T272611

Tchanders moved this task from In Progress 💪 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Jan 21 2021, 3:45 PM
gerritbot added a comment.Jan 21 2021, 3:49 PM

Change 657622 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Replace addModule() with addModuleStyles()

https://gerrit.wikimedia.org/r/657622

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 4:00 PM
• Prtksxna moved this task from Design Review 🔬 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Jan 21 2021, 4:03 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 21 2021, 4:11 PM
• Niharika closed this task as Resolved.Feb 8 2021, 12:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL