Page MenuHomePhabricator

Display map markers on Kartographer maps even in case of mapserver failures
Open, LowPublic

Description

If the fetching of mapserver data using https://maps.wikimedia.org/geoshape?getgeojson=... or https://maps.wikimedia.org/geoline?getgeojson=... fails then all map markers are not shown.

Both mapshapes and markers are created in several layers. Their definition is made in HTML document header using the JavaScript GeoJSON declaration of wgKartographerLiveData. The markers to display are directly defined in the document header and are therefore available at any time. Geolines and geoshapes are specified as external data by their Wikidata IDs and must be fetched from maps.wikimedia.org server. This is done with AJAX-call promises and can, of course, fail.

After a completely faultless retrieval the map-markers are added. Unluckily in case of any failure nothing is done although both the base map and the marker coordinates are available. This has to be changed in a manner that the markers should be shown in the case of failures, too.

The code should be work similar to the following example:

Promise.all( promiseArray )
	.then( function() { displayAllMarkers(); } )
	.catch( function() { displayAllMarkers(); } );

The map server failures can have different causes as reported for instance in T241644 and T226412. In that cases the map server is returning nothing or a error statement like "Cannot GET /geoline". These errors will prevent the drawing of map markers.

Event Timeline

Restricted Application added a project: SRE. · View Herald TranscriptMon, Dec 28, 9:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jbond triaged this task as Medium priority.Wed, Dec 30, 12:44 PM
jbond edited projects, added Maps; removed Traffic, Maps (Maps-data).

@RKemper can you double check i have tagged this correctly?

sdkim added a subscriber: sdkim.
sdkim lowered the priority of this task from Medium to Low.Mon, Jan 4, 2:45 PM