Page MenuHomePhabricator

User signatures should be wrapped in a span
Open, LowPublic

Description

Author: paxed

Description:
Currently there is no way to distinguish between user text and his signature eg. on talk pages, and therefore the signatures cannot be styled separately from the text either.


Version: unspecified
Severity: enhancement

Details

Reference
bz25141

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:17 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz25141.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 46855 has been marked as a duplicate of this bug. ***

(In reply to comment #1)

  • Bug 46855 has been marked as a duplicate of this bug. ***

This bug did not come up in my search, but it is extremely similar.
I'm requesting that all signatures be wrapped in a set of classed tags so that
those editors with vision problems (like myself) can add a little css or
javascript (or have a checkbox that lets it be done server side on their
preferences page) to remove custom signatures from everyone. I've seen on WP
talk:signatures there was a request to have all custom signatures removed from
this site, and my suggestion here would allow those people that think they
shouldn't be allowed for anyone if they are not fully customizable and allowed
for everyone to disable all signature customizations. To summarize, I am
requesting signatures be wrapped in an element to allow users to add something
like:
span.signature {background-color: #FFF; color: #000; text-decoration: none;
font-family: "Times New Roman", monospace;}

Allowing them to remove blinking, scrolling, and colors that are too bright and
fail to meet standards of contrast ratios without having to request every user
that has an obnoxious signature to fix it wasting time and causing conflicts
and edit wars.

I don't care what the element tag is and I don't care much what the class is. An expansion of <span class="before-localcomments"> to include the whole signature and not just the ) and times stamp would work fine for me.

Change 130094 had a related patch set uploaded by Gerrit Patch Uploader:
Wrap user signatures in a span

https://gerrit.wikimedia.org/r/130094

This could add a lot of extra text to pages for ~~~ and ~~~~. Thoughts?

My thought is: No, thanks.

+1 for this enhancement.

I'd suggest to add two classes: a specific class based on username or user ID (e.g. "user_john" or user_28746) and a general class (e.g. "user_signature") if <sig> or <author> can't be in use. Also, different user levels can have classes such "user_admin", "user_bureaucrat" etc.

This fix will add the extra text to pages but as far as I know text amount is not a concern, the issue here is to allow user do mute others signature styles while allowing everybody to custom them freely.

(In reply to Diana from comment #7)

+1 for this enhancement.
I'd suggest to add two classes: a specific class based on username or user
ID (e.g. "user_john" or user_28746) and a general class (e.g.
"user_signature") if <sig> or <author> can't be in use.

Why based on username? I think that would be too specific.

Also, different user
levels can have classes such "user_admin", "user_bureaucrat" etc.

Interesting idea, that I support.

This fix will add the extra text to pages but as far as I know text amount
is not a concern,

I don't see any reason this should add extra text to what readers or editors see, as these classes and whatnot can be added by the parser upon rendering.

the issue here is to allow user do mute others signature
styles while allowing everybody to custom them freely.

That is indeed the issue this ticket aims to offer a fix for.

(In reply to Technical 13 from comment #8)

(In reply to Diana from comment #7)

+1 for this enhancement.
I'd suggest to add two classes: a specific class based on username or user
ID (e.g. "user_john" or user_28746) and a general class (e.g.
"user_signature") if <sig> or <author> can't be in use.

Why based on username? I think that would be too specific.

Yes, as specific as signatures are. An username/ID-based class will allow users to style their signatures (and the others) through their user stylesheet. Also users can create scripts (through the user js) that can rely on classes more easily, e.g. a toc for comments in discussions.

Also, different user
levels can have classes such "user_admin", "user_bureaucrat" etc.

Interesting idea, that I support.

This fix will add the extra text to pages but as far as I know text amount
is not a concern,

I don't see any reason this should add extra text to what readers or editors
see, as these classes and whatnot can be added by the parser upon rendering.

If so, that's great!

the issue here is to allow user do mute others signature
styles while allowing everybody to custom them freely.

That is indeed the issue this ticket aims to offer a fix for.

Daimona added a subscriber: Daimona.Oct 9 2018, 4:02 PM
MJL added a subscriber: MJL.Apr 7 2019, 3:41 AM