Page MenuHomePhabricator

Clean up CodeMirror ResourceLoader modules
Closed, ResolvedPublicFeature

Description

Some nice-to-haves:

  • Convert modules to ResourceLoader "package files".
  • Move WikiEditor-specific code out of ext.CodeMirror.js and into ext.CodeMirror.WikiEditor.js
  • Reuse mw.track stanza as ExtCodeMirror.logUsage.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
WMDE-Fisch added a subscriber: WMDE-Fisch.

Adding our tag so we keep an eye on this.

TheresNoTime changed the subtype of this task from "Task" to "Feature Request".Aug 1 2022, 2:35 PM

@MusikAnimal, will this be resolved with the upgrade to CodeMirror 6?

[…] upgrade to CodeMirror 6?

I'm not sure what you are aiming at, but I'm relatively sure this is unrelated.

[…] upgrade to CodeMirror 6?

I'm not sure what you are aiming at, but I'm relatively sure this is unrelated.

It is unrelated, but it could make sense to do them in tandem as the upgrade would involve a lot of moving things around etc.

I'm just going to make it a sub-task, actually. You could totally do everything that's being asked here now, but ext.CodeMirror.js will largely have to rewritten anyway.

Yes, I meant to suggest as long as we are revisiting CodeMirror anyway, does it make sense to (and is it easy to) address this with the upgrade?

Change 950031 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] Convert applicable ResourceLoader modules to use packageFiles

https://gerrit.wikimedia.org/r/950031

Change 950031 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Convert applicable ResourceLoader modules to use packageFiles

https://gerrit.wikimedia.org/r/950031

Merged! I don't think this needs QA as it would be a "make sure nothing broke" sort of thing, which we'll quickly discover as it rolls out this week. Closing as resolved.