Some nice-to-haves:
- Convert modules to ResourceLoader "package files".
- Move WikiEditor-specific code out of ext.CodeMirror.js and into ext.CodeMirror.WikiEditor.js
- Reuse mw.track stanza as ExtCodeMirror.logUsage.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Convert applicable ResourceLoader modules to use packageFiles | mediawiki/extensions/CodeMirror | master | +463 -443 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T166098 Syntax sensitive and highlighting source code editor for template code wanted | ||
| Open | Feature | Bhsd | T95100 Add autocompletion to CodeMirror extension | ||
| Resolved | Feature | MusikAnimal | T181677 Implement syntax highlight for U+00A0 (no-break space, nbsp) | ||
| Resolved | Feature | MusikAnimal | T301615 Show syntax highlighting on View Source/protected pages | ||
| Resolved | MusikAnimal | T214989 Allow CodeMirror to be used for other textareas with WikiEditor | |||
| In Progress | Goal | None | T259059 Upgrade to CodeMirror 6 | ||
| Resolved | Feature | MusikAnimal | T272035 Clean up CodeMirror ResourceLoader modules |
Event Timeline
Comment Actions
[…] upgrade to CodeMirror 6?
I'm not sure what you are aiming at, but I'm relatively sure this is unrelated.
Comment Actions
[…] upgrade to CodeMirror 6?
I'm not sure what you are aiming at, but I'm relatively sure this is unrelated.
It is unrelated, but it could make sense to do them in tandem as the upgrade would involve a lot of moving things around etc.
Comment Actions
I'm just going to make it a sub-task, actually. You could totally do everything that's being asked here now, but ext.CodeMirror.js will largely have to rewritten anyway.
Comment Actions
Yes, I meant to suggest as long as we are revisiting CodeMirror anyway, does it make sense to (and is it easy to) address this with the upgrade?
Comment Actions
Change 950031 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/CodeMirror@master] Convert applicable ResourceLoader modules to use packageFiles
Comment Actions
Change 950031 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Convert applicable ResourceLoader modules to use packageFiles
Comment Actions
Merged! I don't think this needs QA as it would be a "make sure nothing broke" sort of thing, which we'll quickly discover as it rolls out this week. Closing as resolved.