Page MenuHomePhabricator

"Mentee changes" does not represent the purpose of "claimmentee" subtype correctly
Closed, DuplicatePublic

Description

I just noticed that there's a new message, log-action-filter-growthexperiments-claimmentee. However, claimmentee aren't mentee-requested claims; the mentee doesn't need to interact with them in any way. This message sounds to me like it's that way.

What about changing log-action-filter-growthexperiments-claimmentee to "Mentee claims" (or "Claiming mentees") and changing log-action-filter-growthexperiments-setmentor to "Setting mentor", to make the actual difference clearer?

@Tgr @kostajh What do you think?

Event Timeline

I would read "mentee changes" as "changes to mentees", although I guess you could also read it as "changes by mentees". (FWIW, I do wonder how many users even understand "mentee" which is an uncommon word.)

I would read "mentee changes" as "changes to mentees", although I guess you could also read it as "changes by mentees".

Didn't think about the first interpretation at all :). On the other hand, it's not the mentee what changes, it's the mentor (in both cases).

(FWIW, I do wonder how many users even understand "mentee" which is an uncommon word.)

I personally believe it's an understandable word, similar to other English words (trainee/trainer; employee/employer).

Well, both change in both cases, but I would think of it as a mentee choosing a mentor vs. a mentor choosing mentees. But yeah, it's not a clear way of differentiating. I have no problem with rewording.

Not working on this currently.