Page MenuHomePhabricator

Use HTMLForm submission infrastructure in TallyPage forms
Closed, ResolvedPublic

Description

HTMLForm provides infrastructure for handling form submission, which is currently not being used by the TallyPage.

This includes convenient wiring for:

  • passing form data through to submit callbacks
  • displaying errors with the correct styling
  • displaying the form again if there is an error, so that the user can correct it
Before (unstyled error message only)After

In T271830 we are adding new form fields and introducing new potential errors, and will need to make correcting these errors more convenient. We should do this ahead of solving that task.

Event Timeline

Tchanders renamed this task from Use submit callbacks in TallyPage forms to Use HTMLForm submission infrastructure in TallyPage forms.Jan 22 2021, 11:01 PM
Tchanders updated the task description. (Show Details)

Change 657922 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SecurePoll@master] TallyPage: Use submit callbacks in HTMLForms

https://gerrit.wikimedia.org/r/657922

Change 657922 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] TallyPage: Use submit callbacks in HTMLForms

https://gerrit.wikimedia.org/r/657922