Use HTMLForm submission infrastructure in TallyPage forms
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Jan 22 2021, 10:55 PM

Description

HTMLForm provides infrastructure for handling form submission, which is currently not being used by the TallyPage.

This includes convenient wiring for:

passing form data through to submit callbacks
displaying errors with the correct styling
displaying the form again if there is an error, so that the user can correct it

Before (unstyled error message only)	After

In T271830 we are adding new form fields and introducing new potential errors, and will need to make correcting these errors more convenient. We should do this ahead of solving that task.

Details

	Subject	Repo	Branch	Lines +/-
	TallyPage: Use submit callbacks in HTMLForms	mediawiki/extensions/SecurePoll	master	+67 -29

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T271355 Improve Tally functionality
Resolved	Tchanders	T271830 Allow election decryption key to be submitted via the TallyPage form
Resolved	Tchanders	T272758 Use HTMLForm submission infrastructure in TallyPage forms

Event Timeline

Tchanders created this task.Jan 22 2021, 10:55 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJan 22 2021, 10:55 PM

Tchanders renamed this task from Use submit callbacks in TallyPage forms to Use HTMLForm submission infrastructure in TallyPage forms.Jan 22 2021, 11:01 PM

Tchanders updated the task description. (Show Details)

Change 657922 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SecurePoll@master] TallyPage: Use submit callbacks in HTMLForms

https://gerrit.wikimedia.org/r/657922

gerritbot added a project: Patch-For-Review.Jan 22 2021, 11:08 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 22 2021, 11:08 PM

Change 657922 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] TallyPage: Use submit callbacks in HTMLForms

https://gerrit.wikimedia.org/r/657922

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 26 2021, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2021, 1:10 AM

ARamirez_WMF moved this task from Code Review 🔍 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Jan 26 2021, 5:09 PM

• AMooney removed a project: Platform Engineering.Jan 26 2021, 6:09 PM

• Prtksxna moved this task from Design Review 🔬 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Jan 28 2021, 4:32 PM

Niharika closed this task as Resolved.Feb 8 2021, 12:41 PM