Enable RESTbaseless validation in wikibase
Closed, ResolvedPublic
Actions

Description

Wikibase currently the RESTbase based texvcjs validation to check if formulae entered in wikibase are valid tex(vc) words. The first step towards RESTbaseless mathoid use in production is to replace the RESTbase "cache" with the WANObjectCache.

To do that, we need to ensure that the configuration of Wikidata does use a not-none implementation of ObjectCache and that the mathoid URL (wgMathMathMLUrl) is set. While I guess, given the low edit traffic of math statements in Wikidata, it would also work without cache. The default wgMathMathMLUrl points to a wmflabs instance which is probably not accessible from production.

ToDo:

review and merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/661186
set $wgMathUseRestBase=false on beta
test on beta. e.g., https://wikidata.beta.wmflabs.org/wiki/Q544686 change the value of the formula or create a new formula Property Property:P253105 - seems to work after change and config were deployed.

verify that cache is used - I wonder how would we do that..
wait for change to be deployed
enable on wikidata. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/679357
test on wikidata
verify caching in production
remove wgMathUseRestBase and old code path (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/691168)

Details

Subject	Repo	Branch	Lines +/-
Remove unused $wgMathUseRestBase	operations/mediawiki-config	master	+0 -2
Clean up temporary variable wgMathUseRestBase	operations/mediawiki-config	master	+0 -3
Remove wgMathUseRestBase	mediawiki/extensions/Math	master	+4 -17
Math: Enable RESTBase-less Wikidata math validation	operations/mediawiki-config	master	+1 -2
Use Mathoid to validate Wikibase formuale	mediawiki/extensions/Math	master	+20 -19
Math: talk to mathoid directly in labs.	operations/mediawiki-config	master	+6 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	Physikerwelt	T237516 Update to MathJax 3
Declined	None	T252389 Prepare Math extension for MathJax
Resolved	• Pchelolo	T274436 Enable RESTbaseless validation in wikibase

Event Timeline

Physikerwelt created this task.Feb 10 2021, 9:57 PM

Change 661186 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/extensions/Math@master] Use Mathoid to validate Wikibase formuale

https://gerrit.wikimedia.org/r/661186

gerritbot added a project: Patch-For-Review.Feb 10 2021, 10:03 PM

I can not find the mathoid url in https://github.com/wikimedia/operations-mediawiki-config/search?q=MathMathMLUrl

After asking in the ops chat I got the internal URL of mathoid
mathoid.discovery.wmnet:10042 per https://wikitech.wikimedia.org/wiki/Mathoid#Troubleshooting ?
It would be interesting to check if this actually works.
While checking that, the following would be interesting as well:
Does it use https://github.com/wikimedia/mathoid/blob/master/config.prod.yaml Especially is https://github.com/wikimedia/mathoid/blob/f4dac960e4eda6cdfcc3a6496cf8dd56901a3a9f/config.prod.yaml#L59 really true?
That would mean that the answer to an invalid request such as \invalid would result in a result which is different from mathoid.discovery.wmnet:10042/texvcinfo

In T274436#6824238, @Physikerwelt wrote:

I can not find the mathoid url in https://github.com/wikimedia/operations-mediawiki-config/search?q=MathMathMLUrl

After digging in the config, I get the impression that it is still properly set up. https://github.com/wikimedia/operations-mediawiki-config/blob/9db0bb9cc5307921c85c391695dca81cbb27ae8f/wmf-config/ProductionServices.php#L50
` // Automatic dc-local discovery
'parsoid' => 'http://localhost:6002/w/rest.php',
'mathoid' => 'http://localhost:6003',
`

Physikerwelt assigned this task to • Pchelolo.Feb 20 2021, 10:47 AM

Physikerwelt triaged this task as Medium priority.

Physikerwelt updated the task description. (Show Details)

Physikerwelt moved this task from Inbox to Doing on the Math board.

Change 666429 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/mediawiki-config@master] Math: talk to mathoid directly in labs.

https://gerrit.wikimedia.org/r/666429

Change 666429 merged by jenkins-bot:
[operations/mediawiki-config@master] Math: talk to mathoid directly in labs.

https://gerrit.wikimedia.org/r/666429

Mentioned in SAL (#wikimedia-operations) [2021-02-23T20:44:18Z] <ppchelko@deploy1001> Synchronized wmf-config/CommonSettings.php: No-op: math enable talking to mathoid directly in labs, T274436 (duration: 00m 57s)

• Pchelolo updated the task description. (Show Details)Feb 23 2021, 9:03 PM

Change 661186 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Use Mathoid to validate Wikibase formuale

https://gerrit.wikimedia.org/r/661186

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2021, 9:12 PM

• Pchelolo updated the task description. (Show Details)Feb 23 2021, 9:31 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 23 2021, 11:00 PM

Change 679357 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[operations/mediawiki-config@master] Math: Enable RESTBase-less Wikidata math validation

https://gerrit.wikimedia.org/r/679357

gerritbot added a project: Patch-For-Review.Apr 14 2021, 3:08 PM

• Pchelolo updated the task description. (Show Details)Apr 14 2021, 3:10 PM

Change 679357 merged by jenkins-bot:

[operations/mediawiki-config@master] Math: Enable RESTBase-less Wikidata math validation

https://gerrit.wikimedia.org/r/679357

Mentioned in SAL (#wikimedia-operations) [2021-04-19T18:39:36Z] <ppchelko@deploy1002> Synchronized wmf-config/CommonSettings.php: T274436 Math: Enable RESTBase-less Wikidata math validation (duration: 00m 56s)

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2021, 7:10 PM

Physikerwelt updated the task description. (Show Details)Apr 23 2021, 7:52 AM

@Pchelolo do you think the next step
"verify caching in production" is something you can do or does that need to be done by WMDE, or do we not need it altogether.
Btw, I did also rebase the subsequent step here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/665654

Change 691168 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Remove wgMathUseRestBase

https://gerrit.wikimedia.org/r/691168

gerritbot added a project: Patch-For-Review.May 14 2021, 12:39 PM

Physikerwelt updated the task description. (Show Details)May 14 2021, 12:40 PM

Physikerwelt added a project: Platform Engineering.May 14 2021, 12:43 PM

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptMay 14 2021, 12:43 PM

Change 691168 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove wgMathUseRestBase

https://gerrit.wikimedia.org/r/691168

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 15 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 15 2021, 6:10 PM

Physikerwelt closed this task as Resolved.May 15 2021, 8:56 PM

Lens0021 subscribed.May 31 2021, 12:27 PM

Change 710126 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[operations/mediawiki-config@master] Clean up temporary variable wgMathUseRestBase

https://gerrit.wikimedia.org/r/710126

gerritbot added a project: Patch-For-Review.Aug 4 2021, 11:51 PM

Maintenance_bot added a project: Wikidata.Aug 5 2021, 12:45 AM

akosiaris mentioned this in T247697: Rethink mathoids SVG to PNG conversion.Sep 16 2021, 7:40 AM

Change 710126 merged by jenkins-bot:

[operations/mediawiki-config@master] Clean up temporary variable wgMathUseRestBase

https://gerrit.wikimedia.org/r/710126

Mentioned in SAL (#wikimedia-operations) [2021-11-03T18:09:58Z] <ppchelko@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:710126|Clean up temporary variable wgMathUseRestBase (T274436)]] (duration: 01m 03s)

Mentioned in SAL (#wikimedia-operations) [2021-11-03T18:15:17Z] <ppchelko@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:710126|Clean up temporary variable wgMathUseRestBase (T274436)]] (duration: 01m 02s)

Change 820454 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove unused $wgMathUseRestBase

https://gerrit.wikimedia.org/r/820454

Change 820454 merged by jenkins-bot: