Page MenuHomePhabricator
Create Task
Maniphest T275085

Autocreate authevents log entries look odd
Closed, ResolvedPublic
Actions

Description

Seen in authevents.log in production

2021-02-17 22:34:35 [YC2Z9cQ2YOhijN5wRI08IgAAAFM] mw1269 loginwiki 1.36.0-wmf.31 authevents INFO: Autocreation attempt {"event":"autocreate","status":{"Status":"<OK, collected 1 error(s) on the way, no value set>
+------+---------------------------+------------------------------------------+
|    1 | userexists                |                                          |
+------+---------------------------+------------------------------------------+
"}}

Not sure if related to T269680: MediaWiki logging indexing conflict on 'session' for 'session-ip' channel

Details

SubjectRepoBranchLines +/-
Fix logging Status objects to 'authevents' channelmediawiki/coreREL1_40+15 -22
Fix logging Status objects to 'authevents' channelmediawiki/coreREL1_41+15 -23
Fix logging Status objects to 'authevents' channelmediawiki/coreREL1_39+15 -22
Fix logging Status objects to 'authevents' channelmediawiki/coremaster+15 -23
AuthManagerStatsdHandler: Remove support for Status objectsmediawiki/extensions/WikimediaEventsmaster+5 -43
Fix logging Status objects to 'authevents' channelmediawiki/extensions/CentralAuthmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Feb 17 2021, 10:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2021, 10:37 PM
Reedy added a comment.Feb 17 2021, 10:41 PM

Looks to be some result of calling StatusValue::__toString(), so guessing it might be T269680: MediaWiki logging indexing conflict on 'session' for 'session-ip' channel

Reedy added a comment.Feb 17 2021, 10:50 PM

I guess it's technically expected... Just feels a bit odd embedding a human readable version in the middle of a machine readable blob (ie the json)

Tgr mentioned this in T348206: Improve logging, monitoring and test coverage for MediaWiki Platform team authentication extensions.Oct 5 2023, 12:52 AM
matmarex added a parent task: T327046: Improve (or identify) monitoring for CentralAuth autologins on Wikimedia wikis.Oct 16 2023, 3:37 PM
gerritbot added a comment.Oct 16 2023, 3:37 PM

Change 965540 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/965540

gerritbot added a project: Patch-For-Review.Oct 16 2023, 3:37 PM

Change 965517 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/965517

gerritbot added a comment.Oct 16 2023, 3:37 PM

Change 965541 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaEvents@master] AuthManagerStatsdHandler: Remove support for Status objects

https://gerrit.wikimedia.org/r/965541

matmarex claimed this task.Oct 16 2023, 3:37 PM
gerritbot added a comment.Oct 21 2023, 4:49 AM

Change 965540 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/965540

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 21 2023, 5:00 AM
gerritbot added a comment.Oct 21 2023, 5:08 AM

Change 965517 merged by jenkins-bot:

[mediawiki/core@master] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/965517

gerritbot added a comment.Oct 21 2023, 5:08 AM

Change 965541 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] AuthManagerStatsdHandler: Remove support for Status objects

https://gerrit.wikimedia.org/r/965541

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2023, 5:10 AM
matmarex closed this task as Resolved.Oct 21 2023, 5:40 PM
Tgr subscribed.Nov 2 2023, 9:03 PM

The grafana chart is also fixed:

Screenshot Capture - 2023-11-02 - 14-02-53.png (528×1 px, 101 KB)

gerritbot added a comment.Nov 3 2023, 2:36 PM

Change 971300 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_41] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/971300

gerritbot added a project: Patch-For-Review.Nov 3 2023, 2:36 PM

Change 971301 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_40] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/971301

gerritbot added a comment.Nov 3 2023, 2:37 PM

Change 971302 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_39] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/971302

gerritbot added a comment.Nov 3 2023, 5:13 PM

Change 971302 merged by jenkins-bot:

[mediawiki/core@REL1_39] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/971302

gerritbot added a comment.Nov 3 2023, 5:16 PM

Change 971300 merged by jenkins-bot:

[mediawiki/core@REL1_41] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/971300

gerritbot added a comment.Nov 3 2023, 5:17 PM

Change 971301 merged by jenkins-bot:

[mediawiki/core@REL1_40] Fix logging Status objects to 'authevents' channel

https://gerrit.wikimedia.org/r/971301

Maintenance_bot removed a project: Patch-For-Review.Nov 3 2023, 5:30 PM
ReleaseTaggerBot added projects: MW-1.40-notes, MW-1.39-notes, MW-1.41-notes.Nov 3 2023, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits