Page MenuHomePhabricator

push-subscription-manager group is sometimes available at all wikis
Open, LowPublic

Description

Due to T275334: Changing user groups from $wgExtensionFunctions no longer works reliably, the code responsible for unsetting the group push-subscription-manager from all wikis but metawiki no longer runs reliably.

Impact

Limited, just visually clutters the interface.

Event Timeline

Legoktm subscribed.

I'm working on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/710136 to allow properly disabling groups, but I don't think the Echo extension should add this group by default. AFAICT it just allows sysadmins to manually delete a user's push subscriptions. On most wikis this will not be used since it's not enabled by default.

I propose: configuring the group and its permission explicitly in Meta-Wiki's configuration, add group messages to WikimediaMessages. Remove the group from Echo's extension.json and leave permission unassigned by default. Since you have to manually enable push notification support, sysadmins who enable it can configure the group then.

Looks like this is back in the wilds again

I propose: configuring the group and its permission explicitly in Meta-Wiki's configuration, add group messages to WikimediaMessages. Remove the group from Echo's extension.json and leave permission unassigned by default. Since you have to manually enable push notification support, sysadmins who enable it can configure the group then.

+1. If this is not needed but on Meta as documented (3513c64), probably having the group configured outside the extension sounds like a good idea until @Legoktm's proposed fix lands on MediaWiki. I guess this means removing "GroupPermissions" from extension.json but NOT AvailableRights.