Due to T275334: Changing user groups from $wgExtensionFunctions no longer works reliably, the code responsible for unsetting the group push-subscription-manager from all wikis but metawiki no longer runs reliably.
Limited, just visually clutters the interface.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use MediaWikiServices hook for push-subscription-manager changes | operations/mediawiki-config | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T275334 Changing user groups from $wgExtensionFunctions no longer works reliably | |||
| Resolved | Pppery | T275336 push-subscription-manager group is sometimes available at all wikis |
I'm working on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/710136 to allow properly disabling groups, but I don't think the Echo extension should add this group by default. AFAICT it just allows sysadmins to manually delete a user's push subscriptions. On most wikis this will not be used since it's not enabled by default.
I propose: configuring the group and its permission explicitly in Meta-Wiki's configuration, add group messages to WikimediaMessages. Remove the group from Echo's extension.json and leave permission unassigned by default. Since you have to manually enable push notification support, sysadmins who enable it can configure the group then.
Change #1123499 had a related patch set uploaded (by Pppery; author: Pppery):
[operations/mediawiki-config@master] Use MediaWikiServices hook for push-subscription-manager changes
Change #1123499 merged by jenkins-bot:
[operations/mediawiki-config@master] Use MediaWikiServices hook for push-subscription-manager changes
Mentioned in SAL (#wikimedia-operations) [2025-03-05T14:53:02Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1123499|Use MediaWikiServices hook for push-subscription-manager changes (T275336)]], [[gerrit:1124805|Unset unused IP reveal groups in properly (T387205)]]
Mentioned in SAL (#wikimedia-operations) [2025-03-05T14:55:55Z] <dreamyjazz@deploy2002> dreamyjazz, pppery: Backport for [[gerrit:1123499|Use MediaWikiServices hook for push-subscription-manager changes (T275336)]], [[gerrit:1124805|Unset unused IP reveal groups in properly (T387205)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2025-03-05T15:04:08Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1123499|Use MediaWikiServices hook for push-subscription-manager changes (T275336)]], [[gerrit:1124805|Unset unused IP reveal groups in properly (T387205)]] (duration: 11m 05s)