Editors of graphs please check your graphs for errors in developer console after editing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 26 2021, 12:39 AM

Description

Editors are invited to check any graphs they have recently edited for such errors and also review the list of graphs with known problems below:

Background

A large amount of graphs on deployed wikis were badly configured and were accounting for up to 50% of all JavaScript errors in Wikipedia wikis. As a result of this, we have stopped logging these errors and instead are sending a message to the browser developer console (e.g. Chrome dev tools). (see T274557)

Graphs with known errors

Fixed

Related Objects

Mentioned In: T274557: Broken graphs on wikis accounting for 45% of our client side errors
Mentioned Here: T270404: Validate graph data or inputs and present feedback to the editor/reader rather than rely on production error logs
T274557: Broken graphs on wikis accounting for 45% of our client side errors

Event Timeline

Jdlrobson created this task.Feb 26 2021, 12:39 AM

Restricted Application added subscribers: Danmichaelo, jhsoby, Aklapper. · View Herald TranscriptFeb 26 2021, 12:39 AM

Jdlrobson moved this task from Announce in next Tech/News to To Triage on the User-notice board.Feb 26 2021, 12:39 AM

Jdlrobson mentioned this in T274557: Broken graphs on wikis accounting for 45% of our client side errors.Feb 26 2021, 12:43 AM

Jdlrobson updated the task description. (Show Details)Feb 26 2021, 2:02 AM

Jdlrobson updated the task description. (Show Details)Mar 2 2021, 10:54 PM

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Mar 3 2021, 6:56 AM

Concerning the problems on it.wikipedia, I noticed that all the malfunctioning graphs depend on {{Tl|Grafico}}, so I left a note at our Tech Bar about it: link

Will keep you posted.

valerio.bozzolan subscribed.Mar 3 2021, 10:29 AM

This is an example of a broken graph:

<graph>{"legends":[{"stroke":"color","title":"Legenda","fill":"color"}],"scales":[{"type":"ordinal","name":"x","domain":{"data":"chart","field":"x"},"zero":false,"range":"width","nice":true},{"type":"linear","name":"y","domain":{"data":"aggregate","field":"sum"},"zero":true,"range":"height","nice":true},{"type":"ordinal","name":"color","range":["#3366CC","#66CCFF"]}],"version":2,"marks":[{"type":"group","marks":[{"properties":{"enter":{"y":{"scale":"y","field":"y"},"x":{"scale":"x","field":"x"},"y2":{"scale":"y","field":"y2"},"width":{"scale":"x","offset":-1,"band":true}},"update":{"fill":{"scale":"color","field":"series"}},"hover":{"fill":{"value":"red"}}},"type":"rect"}],"from":{"data":"chart","transform":[{"keys":["series"],"type":"facet"},{"height":"y","type":"stack","point":"x"}]}}],"height":300,"axes":[{"type":"x","scale":"x","layer":"back"},{"type":"y","scale":"y","layer":"back","grid":true}],"data":[{"name":"chart","values":[{"y":14000,"series":"y1","x":1905},{"y":60000,"series":"y1","x":1907},{"y":350000,"series":"y1","x":1917},{"y":786288,"series":"y1","x":1927},{"y":1453828,"series":"y1","x":1937},{"y":2490479,"series":"y1","x":1941},{"y":3965530,"series":"y1","x":1945},{"y":5510787,"series":"y1","x":1950},{"y":6610238,"series":"y1","x":1955},{"y":8017249,"series":"y1","x":1960},{"y":10811443,"series":"y1","x":1965},{"y":13395253,"series":"y1","x":1970},{"y":14109432,"series":"y1","x":1972},{"y":14330525,"series":"y1","x":1973},{"y":15365600,"series":"y1","x":1977},{"y":16732408,"series":"y1","x":1981},{"y":18288786,"series":"y1","x":1986},{"y":18827271,"series":"y1","x":1988},{"y":18975725,"series":"y1","x":1989},{"y":18856113,"series":"y1","x":1990},{"y":0,"series":"y2","x":1905},{"y":0,"series":"y2","x":1907},{"y":0,"series":"y2","x":1917},{"y":426217,"series":"y2","x":1927},{"y":527869,"series":"y2","x":1937},{"y":1381986,"series":"y2","x":1941},{"y":1794839,"series":"y2","x":1945},{"y":829396,"series":"y2","x":1950},{"y":346867,"series":"y2","x":1955},{"y":691418,"series":"y2","x":1960},{"y":946726,"series":"y2","x":1965},{"y":616531,"series":"y2","x":1970},{"y":521857,"series":"y2","x":1972},{"y":490506,"series":"y2","x":1973},{"y":628876,"series":"y2","x":1977},{"y":698005,"series":"y2","x":1981},{"y":715592,"series":"y2","x":1986},{"y":641515,"series":"y2","x":1988},{"y":512097,"series":"y2","x":1989},{"y":372104,"series":"y2","x":1990}]},{"transform":[{"keys":["x"],"type":"facet"},{"value":"y","type":"aggregate"}],"name":"aggregate","source":"chart"}],"width":600}</graph>

Dumped from https://it.wikipedia.org/w/index.php?title=Partito_Comunista_dell%27Unione_Sovietica&oldid=119009998

valerio.bozzolan updated the task description. (Show Details)Mar 3 2021, 11:11 AM

Jdlrobson updated the task description. (Show Details)Mar 3 2021, 4:53 PM

Module:Graph has been updated on it.wiki, we should be fine now.

Thank you @Sakretsu

Screen Shot 2021-03-03 at 1.40.43 PM.png (926×2 px, 174 KB)

eu.wikipedia appears to be the main source of errors now.

Jdlrobson updated the task description. (Show Details)Mar 4 2021, 2:55 AM

Johan moved this task from In current Tech/News draft to To Triage on the User-notice board.Mar 4 2021, 1:27 PM

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Mar 4 2021, 5:15 PM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 10 2021, 2:27 PM

Are there any steps to share, or URL, to get an updated list of Graphs with known errors?

i don't think this tech notice was very effective sadly. I've resorted to manually fixing these myself. If anyone is reading this Phabricator ticket and keen to help, I urge they subscribe to T270404 and help us get that prioritized.

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM

	F34135138: Screen Shot 2021-03-03 at 1.40.43 PM.png
	Mar 3 2021, 9:42 PM

Editors of graphs please check your graphs for errors in developer console after editingClosed, ResolvedPublicActions