Page MenuHomePhabricator

Editors of graphs please check your graphs for errors in developer console after editing
Closed, ResolvedPublic

Description

Editors are invited to check any graphs they have recently edited for such errors and also review the list of graphs with known problems below:

Background

A large amount of graphs on deployed wikis were badly configured and were accounting for up to 50% of all JavaScript errors in Wikipedia wikis. As a result of this, we have stopped logging these errors and instead are sending a message to the browser developer console (e.g. Chrome dev tools). (see T274557)

Graphs with known errors

Fixed

Event Timeline

Concerning the problems on it.wikipedia, I noticed that all the malfunctioning graphs depend on {{Tl|Grafico}}, so I left a note at our Tech Bar about it: link

Will keep you posted.

This is an example of a broken graph:

<graph>{"legends":[{"stroke":"color","title":"Legenda","fill":"color"}],"scales":[{"type":"ordinal","name":"x","domain":{"data":"chart","field":"x"},"zero":false,"range":"width","nice":true},{"type":"linear","name":"y","domain":{"data":"aggregate","field":"sum"},"zero":true,"range":"height","nice":true},{"type":"ordinal","name":"color","range":["#3366CC","#66CCFF"]}],"version":2,"marks":[{"type":"group","marks":[{"properties":{"enter":{"y":{"scale":"y","field":"y"},"x":{"scale":"x","field":"x"},"y2":{"scale":"y","field":"y2"},"width":{"scale":"x","offset":-1,"band":true}},"update":{"fill":{"scale":"color","field":"series"}},"hover":{"fill":{"value":"red"}}},"type":"rect"}],"from":{"data":"chart","transform":[{"keys":["series"],"type":"facet"},{"height":"y","type":"stack","point":"x"}]}}],"height":300,"axes":[{"type":"x","scale":"x","layer":"back"},{"type":"y","scale":"y","layer":"back","grid":true}],"data":[{"name":"chart","values":[{"y":14000,"series":"y1","x":1905},{"y":60000,"series":"y1","x":1907},{"y":350000,"series":"y1","x":1917},{"y":786288,"series":"y1","x":1927},{"y":1453828,"series":"y1","x":1937},{"y":2490479,"series":"y1","x":1941},{"y":3965530,"series":"y1","x":1945},{"y":5510787,"series":"y1","x":1950},{"y":6610238,"series":"y1","x":1955},{"y":8017249,"series":"y1","x":1960},{"y":10811443,"series":"y1","x":1965},{"y":13395253,"series":"y1","x":1970},{"y":14109432,"series":"y1","x":1972},{"y":14330525,"series":"y1","x":1973},{"y":15365600,"series":"y1","x":1977},{"y":16732408,"series":"y1","x":1981},{"y":18288786,"series":"y1","x":1986},{"y":18827271,"series":"y1","x":1988},{"y":18975725,"series":"y1","x":1989},{"y":18856113,"series":"y1","x":1990},{"y":0,"series":"y2","x":1905},{"y":0,"series":"y2","x":1907},{"y":0,"series":"y2","x":1917},{"y":426217,"series":"y2","x":1927},{"y":527869,"series":"y2","x":1937},{"y":1381986,"series":"y2","x":1941},{"y":1794839,"series":"y2","x":1945},{"y":829396,"series":"y2","x":1950},{"y":346867,"series":"y2","x":1955},{"y":691418,"series":"y2","x":1960},{"y":946726,"series":"y2","x":1965},{"y":616531,"series":"y2","x":1970},{"y":521857,"series":"y2","x":1972},{"y":490506,"series":"y2","x":1973},{"y":628876,"series":"y2","x":1977},{"y":698005,"series":"y2","x":1981},{"y":715592,"series":"y2","x":1986},{"y":641515,"series":"y2","x":1988},{"y":512097,"series":"y2","x":1989},{"y":372104,"series":"y2","x":1990}]},{"transform":[{"keys":["x"],"type":"facet"},{"value":"y","type":"aggregate"}],"name":"aggregate","source":"chart"}],"width":600}</graph>

Dumped from https://it.wikipedia.org/w/index.php?title=Partito_Comunista_dell%27Unione_Sovietica&oldid=119009998

Module:Graph has been updated on it.wiki, we should be fine now.

Jdlrobson added subscribers: Assar, Theklan.

Thank you @Sakretsu

eu.wikipedia appears to be the main source of errors now.

Are there any steps to share, or URL, to get an updated list of Graphs with known errors?

Jdlrobson claimed this task.

i don't think this tech notice was very effective sadly. I've resorted to manually fixing these myself. If anyone is reading this Phabricator ticket and keen to help, I urge they subscribe to T270404 and help us get that prioritized.