Prevent <pre> formatting signatures on new lines
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Whatamidoing-WMF
	Mar 5 2021, 6:56 PM

Description

In the Reply tool and the New Discussion tool, there is no good reason for my automagically added signature to ever be preceded by a blank space on a new line (which triggers <pre> formatting). Please don't allow me to do things that produce these results.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Trim wikitext for preview	mediawiki/extensions/DiscussionTools	master	+7 -3
	Trim signatures when added in an empty existing node, too	mediawiki/extensions/DiscussionTools	master	+69 -2

Customize query in gerrit

Related Objects

Mentioned In: rEDTO566d4d92dbf7: Trim wikitext for preview
rEDTO44f2209abf55: Trim signatures when added in an empty existing node, too
T255741: Signature appears de-indented when comment ends in multi-line template
Mentioned Here: T255741: Signature appears de-indented when comment ends in multi-line template

Event Timeline

• Whatamidoing-WMF created this task.Mar 5 2021, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2021, 6:56 PM

I wonder: @Esanders, how – if at all – is this issue related to T255741?

Additional context:

In T255741#6885029, @ppelberg wrote:

In T255741#6853922, @Esanders wrote:

As we usually insert spaces before signatures, incorrectly setup templates can cause the signature to appear preformatted (monospace, with a grey box around);

This seems to have happened again to @Patriccck at cs.wiki. [i]

Although this time, the "preformatting" seems to have been caused by the topic's author inserting a blank line [by pressing ⏎] in the New Discussion Tool's Description field.

Note: I've been able to reproduce this as well.[ii]

i. https://cs.wikipedia.org/w/index.php?diff=19529578&oldid=19529565&title=Diskuse_s_wikipedistou:Patka&curid=371991&diffmode=source
ii. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk%3ACats&type=revision&diff=480481&oldid=476829

Change 669120 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Trim signatures when added in an empty existing node, too

https://gerrit.wikimedia.org/r/669120

gerritbot added a project: Patch-For-Review.Mar 6 2021, 6:18 PM

matmarex mentioned this in T255741: Signature appears de-indented when comment ends in multi-line template.Mar 6 2021, 6:19 PM

matmarex added a project: Editing-team (Kanban Board).Mar 6 2021, 6:23 PM

In T276612#6887362, @ppelberg wrote:

I wonder: @Esanders, how – if at all – is this issue related to T255741?

Unrelated as there are no templates here. I think it's a new issue with the new topic tool.

matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Mar 6 2021, 6:31 PM

In T276612#6889459, @Esanders wrote:

In T276612#6887362, @ppelberg wrote:

I wonder: @Esanders, how – if at all – is this issue related to T255741?

Unrelated as there are no templates here. I think it's a new issue with the new topic tool.

Roger that. Thanks, Ed.

Change 669120 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Trim signatures when added in an empty existing node, too

https://gerrit.wikimedia.org/r/669120

matmarex mentioned this in rEDTO44f2209abf55: Trim signatures when added in an empty existing node, too.Mar 9 2021, 11:05 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 11:10 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 9 2021, 11:20 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 10 2021, 12:00 AM

The preview section is still showing the signature as pre-formatted when I add a new line in the description field while adding a new discussion.

Screen Shot 2021-03-18 at 1.44.59 PM.png (1×1 px, 124 KB)

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 18 2021, 8:56 PM

Ryasmeen moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

Ryasmeen edited projects, added Verified; removed Editing QA.Mar 18 2021, 8:59 PM

Change 674642 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Trim wikitext for preview

https://gerrit.wikimedia.org/r/674642

gerritbot added a project: Patch-For-Review.Mar 24 2021, 4:48 PM

matmarex claimed this task.Mar 24 2021, 4:49 PM

matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.

Change 674642 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Trim wikitext for preview

https://gerrit.wikimedia.org/r/674642

matmarex mentioned this in rEDTO566d4d92dbf7: Trim wikitext for preview.Mar 24 2021, 10:06 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2021, 10:10 PM

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 24 2021, 11:00 PM

Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 25 2021, 2:32 PM

Esanders added a project: Editing QA.

Ryasmeen removed a project: Editing QA.Apr 1 2021, 10:39 PM