Page MenuHomePhabricator

hewiki users seem to get variant C on desktop which breaks the UI
Closed, ResolvedPublic

Description

I just noticed that hewiki users seem to create variant C on desktop, while it's supposed to be mobile-only for now. See screencast attached:

This makes the suggested edits UI really broken. Not sure if this is a Regression or not.

Event Timeline

Urbanecm_WMF added a subscriber: Etonkovidova.

@Etonkovidova Hi, could you look on this when you have some time? Thanks!

Can confirm that it happens with variant C but not D (and only on RTL wikis I guess? not happening on testwiki, at least). $wgGEHomepageNewAccountVariants is still [ "C" => 50, "D" => 50, "A" => 0 ], so reconfiguring that to [ "D" => 100 ] should be a quick fix.

Can confirm that it happens with variant C but not D (and only on RTL wikis I guess? not happening on testwiki, at least). $wgGEHomepageNewAccountVariants is still [ "C" => 50, "D" => 50, "A" => 0 ], so reconfiguring that to [ "D" => 100 ] should be a quick fix.

It's not specific to RTL wikis, I can reproduce locally. "suggested-edits" should only render for desktop when activated, I'm not sure how we missed this earlier. The variant assignment should have nothing to do with it as we don't look at "C" / "D" any more but if the user is in desktop/mobile context and what their activation status is. I think I see the problem, anyway, and will have a patch later today.

Urbanecm renamed this task from hewiki users seem to get variant C on desktop to hewiki users seem to get variant C on desktop which breaks the UI.Mar 18 2021, 8:06 AM

Change 673216 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Fix StartEditing breakage for variant C users

https://gerrit.wikimedia.org/r/673216

Change 673218 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Remove variant C from list of valid variants

https://gerrit.wikimedia.org/r/673218

Urbanecm_WMF raised the priority of this task from High to Unbreak Now!.Mar 18 2021, 10:37 AM

Promoting to train blocker. This breaks the newcomer homepage (a central place for newcomer orientation).

Change 673107 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.35] Remove variant C from list of valid variants

https://gerrit.wikimedia.org/r/673107

Change 673224 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[operations/mediawiki-config@master] GrowthExperiments: set $wgGEHomepageNewAccountVariants to D only

https://gerrit.wikimedia.org/r/673224

Change 673224 merged by jenkins-bot:
[operations/mediawiki-config@master] GrowthExperiments: set $wgGEHomepageNewAccountVariants to D only

https://gerrit.wikimedia.org/r/673224

Change 673218 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove variant C from list of valid variants

https://gerrit.wikimedia.org/r/673218

Mentioned in SAL (#wikimedia-operations) [2021-03-18T11:11:35Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 0005676e704cad907655a4a0bca7bd2164714b1c: GrowthExperiments: set $wgGEHomepageNewAccountVariants to D only (T277727) (duration: 01m 10s)

Change 673107 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.35] Remove variant C from list of valid variants

https://gerrit.wikimedia.org/r/673107

Mentioned in SAL (#wikimedia-operations) [2021-03-18T11:20:35Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.35/extensions/GrowthExperiments/includes/HomepageHooks.php: 3b2aa1aa28e9d204f32ae937a84ec211137cbb2e: Remove variant C from list of valid variants (T277727) (duration: 01m 09s)

Urbanecm_WMF lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 18 2021, 11:27 AM
kostajh triaged this task as Medium priority.Mar 18 2021, 11:28 AM

Still another patch on here for review.

Change 673216 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix StartEditing breakage for variant C users

https://gerrit.wikimedia.org/r/673216