Page MenuHomePhabricator
Create Task
Maniphest T279445

PHP Notice: Trying to get property 'tagName' of non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

A burst of tens-of-thousands of these errors happened.

MediaWiki version: 1.36.0-wmf.37

message
PHP Notice: Trying to get property 'tagName' of non-object
message
PHP Notice: Trying to get property 'parentNode' of non-object
message
PHP Notice: Trying to get property 'nextSibling' of non-object
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.37/extensions/DiscussionTools/includes/CommentModifier.php(208)
#0 /srv/mediawiki/php-1.36.0-wmf.37/extensions/DiscussionTools/includes/CommentModifier.php(208): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.37/extensions/DiscussionTools/includes/CommentModifier.php(507): MediaWiki\Extension\DiscussionTools\CommentModifier::addListItem(MediaWiki\Extension\DiscussionTools\CommentItem)
#2 /srv/mediawiki/php-1.36.0-wmf.37/extensions/DiscussionTools/includes/CommentModifier.php(538): MediaWiki\Extension\DiscussionTools\CommentModifier::addReply(MediaWiki\Extension\DiscussionTools\CommentItem, DOMElement)
#3 /srv/mediawiki/php-1.36.0-wmf.37/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php(176): MediaWiki\Extension\DiscussionTools\CommentModifier::addWikitextReply(MediaWiki\Extension\DiscussionTools\CommentItem, string)
#4 /srv/mediawiki/php-1.36.0-wmf.37/includes/api/ApiMain.php(1647): MediaWiki\Extension\DiscussionTools\ApiDiscussionToolsEdit->execute()
#5 /srv/mediawiki/php-1.36.0-wmf.37/includes/api/ApiMain.php(617): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.36.0-wmf.37/includes/api/ApiMain.php(588): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.36.0-wmf.37/api.php(90): ApiMain->execute()
#8 /srv/mediawiki/php-1.36.0-wmf.37/api.php(45): wfApiMain()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}

Details

Request ID
bb6b716c-1ed5-4d8b-b5ec-9582d805f7ab
Request URL
https://ar.wikipedia.org/w/api.php
SubjectRepoBranchLines +/-
Fix adding comments in lists containing <dt> tagsmediawiki/extensions/DiscussionToolsmaster+544 -2
modifier: Guard against infinite loopmediawiki/extensions/DiscussionToolsmaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

dancy created this task.Apr 6 2021, 3:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2021, 3:29 PM
dancy updated the task description. (Show Details)Apr 6 2021, 3:31 PM
Krinkle updated the task description. (Show Details)Apr 6 2021, 3:49 PM
Krinkle edited Stack Trace. (Show Details)
Krinkle added a project: Editing-team.
Krinkle added subscribers: Esanders, matmarex.
matmarex added a comment.Apr 6 2021, 7:34 PM

It happened only in a single request to a single page on ar.wp. We should investigate but I don't think we need to do it right now.

Esanders added a comment.Apr 6 2021, 8:31 PM

I'm surprised phan doesn't detect this.

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Apr 8 2021, 3:18 PM
ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.
Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 14 2021, 7:13 PM
matmarex claimed this task.Apr 21 2021, 11:29 AM

Minimal test case: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:T279445

== test1 ==
a [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
:b [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
;d [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
:e [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)

== test2 ==
a [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
:b [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
::c [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
;d [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)
:e [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 10:25, 21 April 2021 (UTC)

To reproduce the bug, you need a comment with multiple replies, where a middle reply is incorrect indented with ; instead of :.

When replying to the last existing reply:

  • test1: You get a JavaScript error "Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': Only one element on document allowed."
  • test2: The reply widget seems to work, but posting the reply times out, causing the numerous PHP notices (there's an infinite loop)

(Arguably, the PHP code should also throw a similar exception, but PHP is happy to have a document node with multiple children: https://3v4l.org/v84np)

The JS version works in test2 because it runs on old PHP Parser HTML, which is different than Parsoid HTML for this case!

gerritbot added a comment.Apr 21 2021, 2:06 PM

Change 681686 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] modifier: Guard against infinite loop

https://gerrit.wikimedia.org/r/681686

gerritbot added a project: Patch-For-Review.Apr 21 2021, 2:06 PM

Change 681687 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix adding comments in lists containing <dt> tags

https://gerrit.wikimedia.org/r/681687

matmarex mentioned this in T280793: Parser output has a "list gap" for nested definition lists.Apr 21 2021, 2:18 PM
matmarex moved this task from Upcoming to Code Review on the Editing-team (Kanban Board) board.Apr 27 2021, 8:48 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Apr 28 2021, 5:40 PM
matmarex mentioned this in T283178: DiscussionTools overlaps text when replying on an RfA.May 19 2021, 4:36 PM
Frostly subscribed.May 20 2021, 5:17 PM
gerritbot added a comment.May 25 2021, 7:17 PM

Change 681686 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] modifier: Guard against infinite loop

https://gerrit.wikimedia.org/r/681686

gerritbot added a comment.May 25 2021, 7:19 PM

Change 681687 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix adding comments in lists containing <dt> tags

https://gerrit.wikimedia.org/r/681687

Maintenance_bot removed a project: Patch-For-Review.May 25 2021, 8:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 25 2021, 8:53 PM
matmarex added a project: Editing QA.

For test instructions, see an earlier comment: T279445#7023793

matmarex added parent tasks: T283178: DiscussionTools overlaps text when replying on an RfA, T283180: DiscussionTools displays error when replying on a RfA: Error: Call to a member function insertBefore() on null.May 25 2021, 8:54 PM
matmarex mentioned this in T283180: DiscussionTools displays error when replying on a RfA: Error: Call to a member function insertBefore() on null.May 25 2021, 9:01 PM
Ryasmeen edited projects, added Verified; removed Editing QA.May 26 2021, 7:20 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 26 2021, 10:15 PM
ppelberg closed this task as Resolved.May 27 2021, 3:31 PM
matmarex mentioned this in T261885: Uncaught TypeError: Cannot read property 'tagName' of null.Oct 28 2021, 6:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits